Bug 2296105 - Review Request: rust-cryptographic-message-syntax - Pure Rust implementation of Crypographic Message Syntax (RFC 5652)
Summary: Review Request: rust-cryptographic-message-syntax - Pure Rust implementation ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2296103
Blocks: 2296106
TreeView+ depends on / blocked
 
Reported: 2024-07-06 15:04 UTC by Davide Cavalca
Modified: 2024-09-21 01:37 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-09-12 17:47:47 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2024-07-06 15:04:59 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-cryptographic-message-syntax/rust-cryptographic-message-syntax.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-cryptographic-message-syntax/rust-cryptographic-message-syntax-0.26.0-1.fc41.src.rpm

Description:
A pure Rust implementation of Crypographic Message Syntax (RFC 5652).

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2024-07-06 15:05:38 UTC
$ cat rust2rpm.toml 
[package]
extra-sources = [
  { number = 2, file = "https://github.com/indygreg/cryptography-rs/raw/cfaafe05892ce5c617dcac593a9224613bf88a0e/LICENSE", comments = ["https://github.com/indygreg/cryptography-rs/pull/23"]},
]

[scripts]
prep.pre = ["cp -p %SOURCE2 ."]

[tests]
skip = [
  "time_stamp_protocol::test::simple_request",
  "signing::tests::time_stamp_url",
]
comments = ["Skip tests requiring Internet access"]

Comment 2 Fabio Valentini 2024-09-12 16:12:03 UTC
Package looks good to me.
Just please verify that the test data is something that we can redistribute.

It looks like it's just some certificates and stuff, so I think it should be fine.
But you also might want to exclude src/testdata folder from being installed.

===

Package was generated with rust2rpm, simplifying the review.

❓ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files (temporarily manually included from upstream)
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 3 Fedora Admin user for bugzilla script actions 2024-09-12 17:31:21 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cryptographic-message-syntax

Comment 4 Davide Cavalca 2024-09-12 17:34:55 UTC
> Just please verify that the test data is something that we can redistribute.

I did a pass on this and afaict it's all fine, they're just some certificate bundles.

Comment 5 Fedora Update System 2024-09-12 17:44:31 UTC
FEDORA-2024-5397ea612f (rust-cryptographic-message-syntax-0.26.0-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-5397ea612f

Comment 6 Fedora Update System 2024-09-12 17:47:47 UTC
FEDORA-2024-5397ea612f (rust-cryptographic-message-syntax-0.26.0-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Fedora Update System 2024-09-12 17:56:42 UTC
FEDORA-2024-6ddb74e8cc (rust-cryptographic-message-syntax-0.26.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-6ddb74e8cc

Comment 8 Fedora Update System 2024-09-12 18:07:49 UTC
FEDORA-2024-121885247d (rust-cryptographic-message-syntax-0.26.0-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-121885247d

Comment 9 Fedora Update System 2024-09-12 18:27:10 UTC
FEDORA-2024-56cfb6b8db (rust-cryptographic-message-syntax-0.26.0-1.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-56cfb6b8db

Comment 10 Fedora Update System 2024-09-13 02:39:36 UTC
FEDORA-2024-56cfb6b8db has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-56cfb6b8db \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-56cfb6b8db

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2024-09-13 02:41:55 UTC
FEDORA-2024-121885247d has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-121885247d \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-121885247d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2024-09-13 04:29:00 UTC
FEDORA-2024-6ddb74e8cc has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-6ddb74e8cc \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-6ddb74e8cc

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2024-09-21 00:16:26 UTC
FEDORA-2024-6ddb74e8cc (rust-cryptographic-message-syntax-0.26.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2024-09-21 01:27:45 UTC
FEDORA-2024-56cfb6b8db (rust-cryptographic-message-syntax-0.26.0-1.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 15 Fedora Update System 2024-09-21 01:37:02 UTC
FEDORA-2024-121885247d (rust-cryptographic-message-syntax-0.26.0-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.