Spec URL: https://dcavalca.fedorapeople.org/review/rust-rc2/rust-rc2.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-rc2/rust-rc2-0.8.1-1.fc41.src.rpm Description: RC2 block cipher. Fedora Account System Username: dcavalca
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=120085875
Summary seems to be mangled by rust2rpm, please fix (and possibly file a bug against rust2rpm / cargo2rpm to improve the heuristics).
Filed https://pagure.io/fedora-rust/rust2rpm/issue/280 for this, will update the package shortly
Spec URL: https://dcavalca.fedorapeople.org/review/rust-rc2/rust-rc2.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-rc2/rust-rc2-0.8.1-1.fc41.src.rpm Changelog: - fix summary
$ cat rust2rpm.toml [package] # https://pagure.io/fedora-rust/rust2rpm/issue/280 summary = "RC2 block cypher"
Spec URL: https://dcavalca.fedorapeople.org/review/rust-rc2/rust-rc2.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-rc2/rust-rc2-0.8.1-1.fc41.src.rpm Changelog: - fix typo
$ cat rust2rpm.toml [package] # https://pagure.io/fedora-rust/rust2rpm/issue/280 summary = "RC2 block cipher"
Copr build: https://copr.fedorainfracloud.org/coprs/build/7715739 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2296110-rust-rc2/fedora-rawhide-x86_64/07715739-rust-rc2/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Copr build: https://copr.fedorainfracloud.org/coprs/build/7715745 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2296110-rust-rc2/fedora-rawhide-x86_64/07715745-rust-rc2/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Two issues: - The Apache-2.0 license text is not included. The LICENSE-APACHE file contains only the license header, not the full text. - Please exclude binary test vectors from the -devel package.
Spec URL: https://dcavalca.fedorapeople.org/review/rust-rc2/rust-rc2.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-rc2/rust-rc2-0.8.1-1.fc41.src.rpm Changelog: - include missing license text - exclude binary vectors from -devel
$ cat rust2rpm.toml [package] # https://pagure.io/fedora-rust/rust2rpm/issue/280 summary = "RC2 block cipher" extra-sources = [ { number = 2, file = "https://www.apache.org/licenses/LICENSE-2.0", comments = ["Referenced by LICENSE-APACHE"]}, ] [scripts] prep.pre = ["cp -p %SOURCE2 ."]
Thank you, looks good to me. Can you please file an upstream issue and / or PR to include the full license text in published crates? It is probably an oversight that it currently doesn't contain the full text, most other crates in https://github.com/RustCrypto/block-ciphers do. === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license files are included with %license in %files (full Apache-2.0 license text included manually) ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
(In reply to Fabio Valentini from comment #13) > Thank you, looks good to me. > > Can you please file an upstream issue and / or PR to include the full > license text in published crates? It is probably an oversight that it > currently doesn't contain the full text, most other crates in > https://github.com/RustCrypto/block-ciphers do. https://github.com/RustCrypto/block-ciphers/pull/428
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-rc2
FEDORA-2024-7b3425a6d4 (rust-rc2-0.8.1-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-7b3425a6d4
FEDORA-2024-9c7d005698 (rust-rc2-0.8.1-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-9c7d005698
FEDORA-2024-3ac3cdf734 (rust-rc2-0.8.1-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-3ac3cdf734
FEDORA-2024-7b3425a6d4 (rust-rc2-0.8.1-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-3ac3cdf734 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-3ac3cdf734 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-3ac3cdf734 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-9c7d005698 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-9c7d005698 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-9c7d005698 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-3ac3cdf734 (rust-rc2-0.8.1-1.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-9c7d005698 (rust-rc2-0.8.1-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.