Spec URL: https://wojnilowicz.fedorapeople.org/rust-devise.spec SRPM URL: https://wojnilowicz.fedorapeople.org/rust-devise-0.4.2-1.fc39.src.rpm Description: A library for devising derives and other procedural macros. Fedora Account System Username: wojnilowicz I plan on packaging https://github.com/ActivityWatch/aw-server-rust and devise package is in its requirements chain. The chain is as follows: aw-server-rust->rocket->rocket_codegen->rust-devise.
Copr build: https://copr.fedorainfracloud.org/coprs/build/7715796 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2296168-rust-devise/fedora-rawhide-x86_64/07715796-rust-devise/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Copr build: https://copr.fedorainfracloud.org/coprs/build/7716226 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2296168-rust-devise/fedora-rawhide-x86_64/07716226-rust-devise/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Copr build: https://copr.fedorainfracloud.org/coprs/build/7716354 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2296168-rust-devise/fedora-rawhide-x86_64/07716354-rust-devise/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Do you know where devise 0.4.1 was published from? The git repo only shows history up to 0.4.0: https://github.com/SergioBenitez/Devise/blob/master/lib/Cargo.toml It would also be great if upstream could release new versions that contain the license files that you added.
(In reply to Fabio Valentini from comment #4) > Do you know where devise 0.4.1 was published from? > The git repo only shows history up to 0.4.0: > https://github.com/SergioBenitez/Devise/blob/master/lib/Cargo.toml I don't. It was released from 104e797d440d6fb7e8ba107cca27714a71cc368a that doesn't exist in GitHub. The mentioned commit changed the line at https://github.com/SergioBenitez/Devise/blob/master/core/src/from_meta/meta_item.rs#L147 from "let msg = match self.name() {" to "let msg = match self.name().map(|i| i.to_string()) {" It goes into devise_core though. I think, I'll just create a MR, so that it won't be missed for eventual 0.4.2. > It would also be great if upstream could release new versions that contain > the license files that you added. Last time it took a bit time and follow-up reminders until he accepted my MR with licenses. Going this route again may halt my going up the dependency chain for aw-server-rust for a bit longer. Is a new create with licenses important for you, before approving this package?
In this case, the upstream project provides license files, they're just not included in the published crate. So including them manually from GitHub is fine for now. The bigger problem for me is that the published crate doesn't match the state of the repo. But having the maintainer push their local-only changes should be an easier thing to accomplish ("git push") than poking them with a PR about licenses.
(In reply to Fabio Valentini from comment #6) > In this case, the upstream project provides license files, they're just not > included in the published crate. > So including them manually from GitHub is fine for now. The bigger problem > for me is that the published crate doesn't match the state of the repo. But > having the maintainer push their local-only changes should be an easier > thing to accomplish ("git push") than poking them with a PR about licenses. git push of 104e797d440d6fb7e8ba107cca27714a71cc368a won't work, because I already pushed https://github.com/SergioBenitez/Devise/commit/b2999b2d3adc5cbea75461bbcb081e0446924650 with licenses 104e797d440d6fb7e8ba107cca27714a71cc368a would have to be recreated under a new SHA1. A PR with 0.4.1 would be the same struggle as the PR with licenses. The same poking, and the same waiting. Would you like to wait till I'll manage with the upstream to release 0.4.2 before approving this package?
Ah. You're right. This is kind of messy then. Let's not wait for new releases, but it would be good to have *some* kind of acknowledgement from upstream that they need to push the sources corresponding to 0.4.1 and publish a new version (whether that happens or not in the future is not our problem then).
(In reply to Fabio Valentini from comment #8) > Ah. You're right. This is kind of messy then. > > Let's not wait for new releases, but it would be good to have *some* kind of > acknowledgement from upstream that they need to push the sources > corresponding to 0.4.1 and publish a new version (whether that happens or > not in the future is not our problem then). I've created a PR at https://github.com/SergioBenitez/Devise/pull/7 Could we somehow include it in the spec file to show that this represents what is actually in the crate file and move forward with the review?
Could you review it again? The package has been updated to 0.4.2, which should fix all the issues. [fedora-review-service-build]
Spec URL: https://wojnilowicz.fedorapeople.org/rust-devise.spec SRPM URL: https://wojnilowicz.fedorapeople.org/rust-devise-0.4.2-1.fc39.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/7974542 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2296168-rust-devise/fedora-rawhide-x86_64/07974542-rust-devise/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Copr build: https://copr.fedorainfracloud.org/coprs/build/7974561 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2296168-rust-devise/fedora-rawhide-x86_64/07974561-rust-devise/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Thanks, looks good to me! === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-devise
Thank you for the review!
FEDORA-2024-160526de96 (rust-devise-0.4.2-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-160526de96
FEDORA-2024-160526de96 (rust-devise-0.4.2-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.