Spec URL: https://wojnilowicz.fedorapeople.org/python-aw-qt.spec SRPM URL: https://wojnilowicz.fedorapeople.org/python-aw-qt-0^20240903.43864b2-1.fc39.src.rpm Description: A service manager and tray icon managing aw-server and watchers, built with Qt. Fedora Account System Username: wojnilowicz I plan on packaging https://github.com/ActivityWatch/aw-server-rust and python-aw-qt is it's GUI.
Copr build: https://copr.fedorainfracloud.org/coprs/build/7716499 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2296174-python-aw-qt/fedora-rawhide-x86_64/07716499-python-aw-qt/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://wojnilowicz.fedorapeople.org/python-aw-qt.spec SRPM URL: https://wojnilowicz.fedorapeople.org/python-aw-qt-0^20240903.43864b2-1.fc39.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/7974665 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2296174-python-aw-qt/fedora-rawhide-x86_64/07974665-python-aw-qt/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed 1. The manpage generated by help2man contains a traceback: > ModuleNotFoundError: No module named 'aw_qt' I suggest adding the location of the module installed in buildroot to PYTHONPATH before calling help2man. 2. It looks like the module includes tests, but they are not executed. See tests/integration_tests.py. ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Mozilla Public License 2.0". 19 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/python-aw-qt/licensecheck.txt [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor/128x128/apps, /usr/share/icons/hicolor, /usr/lib/python3.13/site-packages, /usr/share/icons/hicolor/512x512, /usr/share/icons/hicolor/512x512/apps, /usr/lib/python3.13, /usr/share/icons/hicolor/128x128 [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 486 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: python3-aw-qt-0^20240903.43864b2-1.fc42.noarch.rpm python-aw-qt-0^20240903.43864b2-1.fc42.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpip73_99g')] checks: 32, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 11 filtered, 0 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- =========================== rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 7 filtered, 0 badness; has taken 0.1 s Source checksums ---------------- https://raw.githubusercontent.com/ActivityWatch/media/cb597f7c2e2b135505fe5d6b3042960a638892cf/logo/logo-128.png : CHECKSUM(SHA256) this package : 01f830d4d3ac61e9f8902f19aef80a9d4cd5fdb0eb8845d38b331235fd297f79 CHECKSUM(SHA256) upstream package : 01f830d4d3ac61e9f8902f19aef80a9d4cd5fdb0eb8845d38b331235fd297f79 https://raw.githubusercontent.com/ActivityWatch/media/cb597f7c2e2b135505fe5d6b3042960a638892cf/logo/logo.png : CHECKSUM(SHA256) this package : 7110564f480d5cc900c92149c82bdf21ef96c7f988d8d89aa65baea6691e0bd4 CHECKSUM(SHA256) upstream package : 7110564f480d5cc900c92149c82bdf21ef96c7f988d8d89aa65baea6691e0bd4 https://github.com/ActivityWatch/aw-qt/archive/43864b2f7ec3b71d5b181eafb47b4ded6c197b8f/aw-qt-43864b2.tar.gz : CHECKSUM(SHA256) this package : 2395837fc6004e04ff3458713d534eff59a1a4e42c6082c15241f6ddeee2ddef CHECKSUM(SHA256) upstream package : 2395837fc6004e04ff3458713d534eff59a1a4e42c6082c15241f6ddeee2ddef Requires -------- python3-aw-qt (rpmlib, GLIBC filtered): (python3.13dist(aw-core) < 0.6~~ with python3.13dist(aw-core) >= 0.5) (python3.13dist(pyqt6) < 7~~ with python3.13dist(pyqt6) >= 6.5.3) /usr/bin/python3 python(abi) python3.13dist(click) python3.13dist(setuptools) Provides -------- python3-aw-qt: application() application(aw-qt.desktop) python-aw-qt python3-aw-qt python3.13-aw-qt python3.13dist(aw-qt) python3dist(aw-qt) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name python-aw-qt --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Python Disabled plugins: PHP, C/C++, Ocaml, Java, Haskell, SugarActivity, Perl, R, fonts Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Please review bug 2283064 in return if you can.
(In reply to Dominik 'Rathann' Mierzejewski from comment #4) > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > [ ] = Manual review needed > > 1. The manpage generated by help2man contains a traceback: > > ModuleNotFoundError: No module named 'aw_qt' > I suggest adding the location of the module installed in buildroot to > PYTHONPATH before calling help2man. Done. > 2. It looks like the module includes tests, but they are not executed. > See tests/integration_tests.py. I see no possibility for it to work. It seems that I need a display (undoable even locally on my PC with rpmbuild) to make this test pass. I added following lines to the spec though: # The following integration test couldn't be run due to the following error # "qt.qpa.xcb: could not connect to display" # %{python3} tests/integration_tests.py --no-modules Is it OK to leave it like that?
You can use (In reply to wojnilowicz from comment #6) > (In reply to Dominik 'Rathann' Mierzejewski from comment #4) > > Package Review > > ============== ... > > 2. It looks like the module includes tests, but they are not executed. > > See tests/integration_tests.py. > > I see no possibility for it to work. It seems that I need a display > (undoable even locally on my PC with rpmbuild) to make this test pass. It is quite possible. Use Xvfb (via xvfb-run). See: https://sourcegraph.com/search?q=context%3Aglobal+repo%3Afedora*+Xvfb&patternType=standard&sm=1&groupBy=repo for examples.
Please do not remove the fedora-review? flag. It marks this ticket as "package under review" for tracking purposes.
(In reply to Dominik 'Rathann' Mierzejewski from comment #7) > You can use (In reply to wojnilowicz from comment #6) > > (In reply to Dominik 'Rathann' Mierzejewski from comment #4) > > > Package Review > > > ============== > ... > > > 2. It looks like the module includes tests, but they are not executed. > > > See tests/integration_tests.py. > > > > I see no possibility for it to work. It seems that I need a display > > (undoable even locally on my PC with rpmbuild) to make this test pass. > > It is quite possible. Use Xvfb (via xvfb-run). See: > https://sourcegraph.com/ > search?q=context%3Aglobal+repo%3Afedora*+Xvfb&patternType=standard&sm=1&group > By=repo > for examples. I've just read on Matrix in #devel:fedoraproject.org that: [...] with Qt, you can often get by without using xvfb-run or a successor by setting QT_QPA_PLATFORM=offscreen in the environment. There's also xwfb-run and wlheadless-run, which, apparently, is the only supported method under RHEL10.
(In reply to Dominik 'Rathann' Mierzejewski from comment #9) > (In reply to Dominik 'Rathann' Mierzejewski from comment #7) > > You can use (In reply to wojnilowicz from comment #6) > > > (In reply to Dominik 'Rathann' Mierzejewski from comment #4) > > > > Package Review > > > > ============== > > ... > > > > 2. It looks like the module includes tests, but they are not executed. > > > > See tests/integration_tests.py. > > > > > > I see no possibility for it to work. It seems that I need a display > > > (undoable even locally on my PC with rpmbuild) to make this test pass. > > > > It is quite possible. Use Xvfb (via xvfb-run). See: > > https://sourcegraph.com/ > > search?q=context%3Aglobal+repo%3Afedora*+Xvfb&patternType=standard&sm=1&group > > By=repo > > for examples. > > I've just read on Matrix in #devel:fedoraproject.org that: [...] with Qt, > you can often get by without using xvfb-run or a successor by setting > QT_QPA_PLATFORM=offscreen in the environment. Done. Thanks for your support in this. Does it look good now? Spec URL: https://wojnilowicz.fedorapeople.org/python-aw-qt.spec SRPM URL: https://wojnilowicz.fedorapeople.org/python-aw-qt-0^20240903.43864b2-1.fc39.src.rpm
Created attachment 2048498 [details] The .spec file difference from Copr build 7974665 to 8066354
Copr build: https://copr.fedorainfracloud.org/coprs/build/8066354 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2296174-python-aw-qt/fedora-rawhide-x86_64/08066354-python-aw-qt/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Created attachment 2048499 [details] The .spec file difference from Copr build 8066354 to 8066409
Copr build: https://copr.fedorainfracloud.org/coprs/build/8066409 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2296174-python-aw-qt/fedora-rawhide-x86_64/08066409-python-aw-qt/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Created attachment 2048500 [details] The .spec file difference from Copr build 8066409 to 8066432
Copr build: https://copr.fedorainfracloud.org/coprs/build/8066432 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2296174-python-aw-qt/fedora-rawhide-x86_64/08066432-python-aw-qt/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
(In reply to wojnilowicz from comment #10) > (In reply to Dominik 'Rathann' Mierzejewski from comment #9) [...] > > I've just read on Matrix in #devel:fedoraproject.org that: [...] with Qt, > > you can often get by without using xvfb-run or a successor by setting > > QT_QPA_PLATFORM=offscreen in the environment. > > Done. Thanks for your support in this. Does it look good now? > > Spec URL: https://wojnilowicz.fedorapeople.org/python-aw-qt.spec > SRPM URL: https://wojnilowicz.fedorapeople.org/python-aw-qt-0^20240903.43864b2-1.fc39.src.rpm It does! The help2man issue is fixed and the tests are executed. Not sure if the stderr output of the integration tests indicates anything was tested, but they exit with 0, so you tell me. ;) ========== stderr ========== 2024-09-24 16:38:40 [INFO ]: Started aw-qt... (aw_qt.main:53) 2024-09-24 16:38:40 [WARNING]: Found matching file but was not executable: /builddir/build/BUILD/python-aw-qt-0_20240903.43864b2-build/aw-qt-43864b2f7ec3b71d5b181eafb47b4ded6c197b8f/aw-qt.spec (aw_qt.manager:64) 2024-09-24 16:38:40 [INFO ]: Found 0 bundled modules (aw_qt.manager:85) 2024-09-24 16:38:40 [INFO ]: Found 0 system modules (aw_qt.manager:119) 2024-09-24 16:38:40 [INFO ]: Creating trayicon... (aw_qt.trayicon:208) ============================ APPROVED.
(In reply to Dominik 'Rathann' Mierzejewski from comment #19) > (In reply to wojnilowicz from comment #10) > > (In reply to Dominik 'Rathann' Mierzejewski from comment #9) > [...] > > > I've just read on Matrix in #devel:fedoraproject.org that: [...] with Qt, > > > you can often get by without using xvfb-run or a successor by setting > > > QT_QPA_PLATFORM=offscreen in the environment. > > > > Done. Thanks for your support in this. Does it look good now? > > > > Spec URL: https://wojnilowicz.fedorapeople.org/python-aw-qt.spec > > SRPM URL: https://wojnilowicz.fedorapeople.org/python-aw-qt-0^20240903.43864b2-1.fc39.src.rpm > > It does! The help2man issue is fixed and the tests are executed. > > Not sure if the stderr output of the integration tests indicates anything > was tested, but they exit with 0, so you tell me. ;) > ========== stderr ========== > 2024-09-24 16:38:40 [INFO ]: Started aw-qt... (aw_qt.main:53) > 2024-09-24 16:38:40 [WARNING]: Found matching file but was not executable: > /builddir/build/BUILD/python-aw-qt-0_20240903.43864b2-build/aw-qt- > 43864b2f7ec3b71d5b181eafb47b4ded6c197b8f/aw-qt.spec (aw_qt.manager:64) > 2024-09-24 16:38:40 [INFO ]: Found 0 bundled modules (aw_qt.manager:85) > 2024-09-24 16:38:40 [INFO ]: Found 0 system modules (aw_qt.manager:119) > 2024-09-24 16:38:40 [INFO ]: Creating trayicon... (aw_qt.trayicon:208) > > ============================ > > APPROVED. The author prints the stderr output at https://github.com/ActivityWatch/aw-qt/blob/d20a9419c5d94479a633c611c68138886a3ff135/tests/integration_tests.py#L42. It is printed also outside of rpmbuild, so I think it's harmless. I believe it might be intended and comes from the line at https://github.com/ActivityWatch/aw-core/blob/3b83ab542406349b3d5e601318289b77d23d906f/aw_core/log.py#L27 Anyhow, thanks for the review.
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-aw-qt
FEDORA-2024-c70fa12634 (python-aw-qt-0^20240903.43864b2-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-c70fa12634
FEDORA-2024-c70fa12634 (python-aw-qt-0^20240903.43864b2-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.