Spec URL: http://people.redhat.com/tscherf/rpms/fedora/Democracy.spec SRPM URL: http://people.redhat.com/tscherf/rpms/fedora/Democracy-0.9.5-1.src.rpm Description: Democracy player is a free application that turns your computer into an internet TV video player.
Awesome! A couple quick comments: 1. No need to %ghost .pyo files anymore, as a matter of fact, it is discouraged: http://fedoraproject.org/wiki/Packaging/Python 2. Use %find_lang instead of manually including locale bits: %{_datadir}/locale/*/LC_MESSAGES/democracyplayer.mo 3. You include %post update-desktop-database %{_datadir}/applications but not for %postun ?
(In reply to comment > A couple quick comments: > 1. No need to %ghost .pyo files anymore, as a matter of fact, it is > discouraged: > http://fedoraproject.org/wiki/Packaging/Python moreover, I think the python-abi require line could go away. > 3. You include > %post > update-desktop-database %{_datadir}/applications > but not for %postun ? and those lines should probably end with "&> /dev/null ||:" as specified in: http://fedoraproject.org/wiki/Packaging/ScriptletSnippets Moreover, do they fixed the x86_64 issues present in earlier versions?
> Moreover, do they fixed the x86_64 issues present in earlier versions? "they" being who? democracy devs? "the x86_64 issues" being what exactly? didn't build? didn't run properly?
please, use %{_mandir}/man1/ instead of %{_datadir}/man/man1/ > # Include files and dirs below %{python_sitelib} (for noarch packages) Where ? the use of cd platform/gtk-x11 looks good. personnaly, i prefer to use pushd-command to enter in some directory and popd-command to exit this one (same thing for %build section). such as: ---- pushd gtk-x11 python setup.py install -O1 --skip-build --root $RPM_BUILD_ROOT popd ---- i think it's better for a clean review.
(In reply to comment #3) > > Moreover, do they fixed the x86_64 issues present in earlier versions? > > "they" being who? democracy devs? > "the x86_64 issues" being what exactly? didn't build? didn't run properly? sorry for the out-of-context comment. I was referring to this: https://www.redhat.com/archives/fedora-extras-list/2006-November/msg00104.html
1) removed %ghost from files section 2) used find_lang 3) created a postun 4) added "&> /dev/null ||:" to the Scriptlet 5) AFAIK the x86_64 bug should be fixed, can't test it myself, maybe someone else can verify this http://people.redhat.com/tscherf/rpms/fedora/Democracy.spec http://people.redhat.com/tscherf/rpms/fedora/Democracy-0.9.5-2.src.rpm
Looking good, I can review this. 1. SHOULD simplify things and just include in %files: %{python_sitearch}/democracy/ instead of all the %dirs and * globbing. 2. Requires: firefox Other apps that build against firefox-devel need/use a *versioned* requires here, in effect Require'ing the same version of firefox they were built against. Is that the case here? (or maybe not worry about it (: ) 3. Requires: python-abi ... shouldn't be explictly required (when using python >= 2.4 anyway). 4. Requires: xine-lib gnome-python2-gtkmozembed libfame gnome-python2-gconf dbus-python Are *all* of these really explicitly required? In particular, xine-lib libfame should get auto'req'd by rpm (if not, it's ok to keep the Requires).
1) simplified the files section 3) removed python-abi req 4) rpm should take care about this, true, removed the req about 2) not sure if we need a versioned firefox requirement. I tested this package on 2 difeerent machines with different firefox versions without problems, so it should work. could you verify this? http://people.redhat.com/tscherf/rpms/fedora/Democracy.spec http://people.redhat.com/tscherf/rpms/fedora/Democracy-0.9.5-3.src.rpm
mock build failed on Democracy-0.9.5-3.src.rpm ... Package config error: pkg-config --list-all outputted the following error: Package xfixes was not found in the pkg-config search path. Perhaps you should add the directory containing `xfixes.pc' to the PKG_CONFIG_PATH environment variable Package 'xfixes', required by 'Xcursor', not found error: Bad exit status from /var/tmp/rpm-tmp.89920 (%build) Either a missing BR or an X-dep missing/bug.
after adding BuildRequires: libXcursor-devel libXfixes-devel now I see RuntimeError: pkg-config --cflags --libs gtk+-2.0 glib-2.0 pygtk-2.0 firefox-gtkmozembed firefox-xpcom outputted the following error: Package gtk+-2.0 was not found in the pkg-config search path. Perhaps you should add the directory containing `gtk+-2.0.pc' to the PKG_CONFIG_PATH environment variable No package 'gtk+-2.0' found adding BuildRequires: gtk2-devel iterating again... finished build. So, looks like we need to add: BuildRequires: libXcursor-devel libXfixes-devel BuildRequires: gtk2-devel
These look mostly harmless: $ rpmlint Democracy-0.9.5-3.fc7.i386.rpm E: Democracy non-executable-script /usr/lib/python2.5/site-packages/democracy/coverage.py 0644 E: Democracy non-executable-script /usr/lib/python2.5/site-packages/democracy/timetemplates.py 0644 W: Democracy wrong-file-end-of-line-encoding /usr/share/doc/Democracy-0.9.5/CREDITS E: Democracy non-executable-script /usr/lib/python2.5/site-packages/democracy/feedparser.py 0644 Add the missing BR's and looks like we have a winner.
Looks like we figured out the same thing during the same time. :) Was also looking for addional BR after Mock building failed. Added the necessary BR and now it builds in Mock without problems. http://people.redhat.com/tscherf/rpms/fedora/Democracy.spec http://people.redhat.com/tscherf/rpms/fedora/Democracy-0.9.5-4.src.rpm
Democracy rules, APPROVED. Be careful about removing some of the python runtime Req's, I didn't verify if those are still Required or not: gnome-python2-gtkmozembed gnome-python2-gconf dbus-python
New Package CVS Request ======================= Package Name: Democracy Short Description: Internet TV and video player Owners: tscherf Branches: FC-5 FC-6 devel InitialCC:
branched
Is there a good reason why the spec does unusual manual installation of documentation via %_defaultdocdir instead of simply doing %doc README license.txt CREDITS in the %files section?
> Is there a good reason... not really, is it a problem?
It makes installation of additional files via short %doc impossible, because both techniques conflict with eachother. Using the %doc macro to include files located in the extracted tarball in $RPM_BUILD_DIR deletes %_defaultdocdir.
I corrected the doc installation style. updated package (0.9.5.1-3) is now in devel and fc6 branch available. will close here.