Spec URL: https://github.com/LecrisUT/tonic-rpmspec/raw/f7b19948b281b06bae4abaed199dfac901547333/rust-tonic-build/rust-tonic-build.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/LecrisUT-tonic-rpmspec-main/fedora-rawhide-x86_64/07718143-rust-tonic-build/rust-tonic-build-0.12.0-1.fc41.src.rpm Description: Dependency for `atuin` Fedora Account System Username: lecris rust2rpm.toml: default
Spec URL: https://lecris.fedorapeople.org/reviews/rust-tonic-build/rust-tonic-build.spec SRPM URL: https://lecris.fedorapeople.org/reviews/rust-tonic-build/rust-tonic-build-0.12.2-1.fc42.src.rpm Bumped to 0.12.2 and switched to permanent links
Copr build: https://copr.fedorainfracloud.org/coprs/build/7947943 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2296541-rust-tonic-build/fedora-rawhide-x86_64/07947943-rust-tonic-build/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
There's a missing optional dependency: Problem: conflicting requests - nothing provides (crate(prost-build/cleanup-markdown) >= 0.13.0 with crate(prost-build/cleanup-markdown) < 0.14.0~) needed by rust-tonic-build+cleanup-markdown-devel-0.12.2-1.fc42.noarch from @commandline If you don't need this feature, I would suggest to patch it out.
Spec URL: https://lecris.fedorapeople.org/reviews/rust-tonic-build/rust-tonic-build.spec SRPM URL: https://lecris.fedorapeople.org/reviews/rust-tonic-build/rust-tonic-build-0.12.2-1.fc42.src.rpm Done. I thought I had run these with `features.all`, but I guess not.
Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
Thank you for the review, Fabio
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-tonic-build
FEDORA-2024-9b6bea25e4 (rust-tonic-build-0.12.2-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-9b6bea25e4
FEDORA-2024-9b6bea25e4 (rust-tonic-build-0.12.2-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-16549d7b87 (rust-tonic-build-0.12.2-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-16549d7b87
FEDORA-2024-c22c4f29c9 (rust-tonic-build-0.12.2-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-c22c4f29c9
FEDORA-2024-16549d7b87 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-16549d7b87` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-16549d7b87 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-d1b4d41abc has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-d1b4d41abc` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-d1b4d41abc See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-c22c4f29c9 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-c22c4f29c9` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-c22c4f29c9 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-16549d7b87 (rust-tonic-build-0.12.2-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-c22c4f29c9 (rust-tonic-build-0.12.2-1.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-d1b4d41abc (rust-tonic-build-0.12.2-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.