Bug 2296615 - Review Request: golang-github-jwalton-gchalk - Terminal string styling for go
Summary: Review Request: golang-github-jwalton-gchalk - Terminal string styling for go
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mark E. Fuller
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2296614
Blocks: 2296618
TreeView+ depends on / blocked
 
Reported: 2024-07-09 13:56 UTC by Mikel Olasagasti Uranga
Modified: 2024-07-14 18:51 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-07-14 18:51:25 UTC
Type: ---
Embargoed:
mark.e.fuller: fedora-review+


Attachments (Terms of Use)

Description Mikel Olasagasti Uranga 2024-07-09 13:56:27 UTC
Spec URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-jwalton-gchalk.spec
SRPM URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-jwalton-gchalk-1.3.0-1.fc40.src.rpm
Description: Terminal string styling for go
Fedora Account System Username: mikelo2

Comment 1 Mark E. Fuller 2024-07-14 17:49:02 UTC
Golang Package Review
==============

This package was generated using go2rpm, which simplifies the review.
Package is library / devel, so straightforward

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86.
- [x] The package complies with the Golang and general Packaging Guidelines.

APPROVED


On import, please:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
- [ ] Consider configuring Packit service to help with maintenance

Thank you

Comment 2 Fedora Admin user for bugzilla script actions 2024-07-14 18:21:09 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-jwalton-gchalk

Comment 3 Fedora Update System 2024-07-14 18:47:49 UTC
FEDORA-2024-4e2e6e8d3e (golang-github-jwalton-gchalk-1.3.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-4e2e6e8d3e

Comment 4 Fedora Update System 2024-07-14 18:51:25 UTC
FEDORA-2024-4e2e6e8d3e (golang-github-jwalton-gchalk-1.3.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.