Bug 2296787 - Review Request: ghc-indexed-profunctors - Utilities for indexed profunctors
Summary: Review Request: ghc-indexed-profunctors - Utilities for indexed profunctors
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jens Petersen
QA Contact: Fedora Extras Quality Assurance
URL: https://hackage.haskell.org/package/i...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-07-09 17:50 UTC by Frank Dedden
Modified: 2024-10-21 09:44 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-10-21 09:44:47 UTC
Type: ---
Embargoed:
petersen: fedora-review+


Attachments (Terms of Use)

Description Frank Dedden 2024-07-09 17:50:26 UTC
Spec URL: https://fdedden.fedorapeople.org/ghc-indexed-profunctors.spec
SRPM URL: https://fdedden.fedorapeople.org/ghc-indexed-profunctors-0.1.1.1-1.fc41.src.rpm

Description:
This package contains basic definitions related to indexed profunctors.
These are primarily intended as internal utilities to support the 'optics' and
'generic-lens' package families.

Fedora Account System Username: fdedden

Comment 1 Frank Dedden 2024-07-09 17:50:29 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=120244920

Comment 2 Fedora Review Service 2024-07-09 19:12:23 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7720527
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2296787-ghc-indexed-profunctors/fedora-rawhide-x86_64/07720527-ghc-indexed-profunctors/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Jens Petersen 2024-08-15 16:09:40 UTC
According to the LICENSE file (and licensecheck output)
this package is actually BSD-3-Clause AND BSD-2-Clause.
(I think at least older Cabal syntax was not able to carry should level of detail.)

Please fix that when importing the package.

Otherwise looks good:

- pristine spec file generated by cabal-rpm
- complies with Packaging Policy
- builds and installs

Package is APPROVED (with the the above license tag fix)

Comment 4 Fedora Admin user for bugzilla script actions 2024-08-22 18:29:34 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/ghc-indexed-profunctors


Note You need to log in before you can comment on or make changes to this bug.