Red Hat Bugzilla – Bug 229691
Add enable switches for optional/experimental features
Last modified: 2015-12-07 12:11:57 EST
For Fedora DS, we want to have the latest and greatest features, but we need to
be able to turn off certain features for the RHDS release.
Created attachment 148613 [details]
Created attachment 148614 [details]
Created attachment 148627 [details]
Created attachment 148631 [details]
Looks good to me.
Created attachment 148636 [details]
cvs commit log
Reviewed by: nhosoi, nkinder, prowley (Thanks!)
Files: see diff
Fix Description: Added --enable-pam-passthru, --enable-dna, and --enable-ldapi.
They are all on by default and must be explicitly disabled
(--disable-pam-passthru). These all cause ENABLE_xxx to be defined for C code
so that we can enclose the code in #ifdef ENABLE_PAM_PASSTHRU blocks, for
example. For the first two, these also cause the plugins to be built - so that
if you specify --disable-pam-passthru, the plugin code will not be built at
all. I discovered a nifty autoconf macro called AS_HELP_STRING - this nicely
formats the help messages output by configure --help. I don't know if it's
worth going through all of our m4 code to use this, but I went ahead and fixed
configure.ac. Create instance will now add plugin configuration entries (but
disabled) for pam passthru and dna if the corresponding ENABLE_ macros are
defined. I also fixed a bug with passthru (not pam passthru) - the plugin
configuration entry was not being added.
Platforms tested: RHEL4, FC6
Flag Day: no
Doc impact: no
Verified that configure supports all of these options (as well as --enable-bitwise).