Bug 229691
| Summary: | Add enable switches for optional/experimental features | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Retired] 389 | Reporter: | Rich Megginson <rmeggins> | ||||||||||||
| Component: | Directory Server | Assignee: | Rich Megginson <rmeggins> | ||||||||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Viktor Ashirov <vashirov> | ||||||||||||
| Severity: | medium | Docs Contact: | |||||||||||||
| Priority: | medium | ||||||||||||||
| Version: | 1.0.4 | ||||||||||||||
| Target Milestone: | --- | ||||||||||||||
| Target Release: | --- | ||||||||||||||
| Hardware: | All | ||||||||||||||
| OS: | Linux | ||||||||||||||
| Whiteboard: | |||||||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||||||
| Doc Text: | Story Points: | --- | |||||||||||||
| Clone Of: | Environment: | ||||||||||||||
| Last Closed: | 2015-12-07 17:11:57 UTC | Type: | --- | ||||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||||
| Documentation: | --- | CRM: | |||||||||||||
| Verified Versions: | Category: | --- | |||||||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||||
| Embargoed: | |||||||||||||||
| Bug Depends On: | |||||||||||||||
| Bug Blocks: | 152373, 240316, 427409 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Rich Megginson
2007-02-22 19:54:32 UTC
Created attachment 148613 [details]
diffs
Created attachment 148614 [details]
new diffs
Created attachment 148627 [details]
better diffs
Created attachment 148631 [details]
diffs
Looks good to me. Looks good. Created attachment 148636 [details]
cvs commit log
Reviewed by: nhosoi, nkinder, prowley (Thanks!)
Files: see diff
Branch: HEAD
Fix Description: Added --enable-pam-passthru, --enable-dna, and --enable-ldapi.
They are all on by default and must be explicitly disabled
(--disable-pam-passthru). These all cause ENABLE_xxx to be defined for C code
so that we can enclose the code in #ifdef ENABLE_PAM_PASSTHRU blocks, for
example. For the first two, these also cause the plugins to be built - so that
if you specify --disable-pam-passthru, the plugin code will not be built at
all. I discovered a nifty autoconf macro called AS_HELP_STRING - this nicely
formats the help messages output by configure --help. I don't know if it's
worth going through all of our m4 code to use this, but I went ahead and fixed
configure.ac. Create instance will now add plugin configuration entries (but
disabled) for pam passthru and dna if the corresponding ENABLE_ macros are
defined. I also fixed a bug with passthru (not pam passthru) - the plugin
configuration entry was not being added.
Platforms tested: RHEL4, FC6
Flag Day: no
Doc impact: no
Verified that configure supports all of these options (as well as --enable-bitwise). |