Bug 2297188 - Review Request: rust-open-enum-derive - Attribute for generating "open" fieldless enums that accept any integer value
Summary: Review Request: rust-open-enum-derive - Attribute for generating "open" field...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/open-enum-de...
Whiteboard:
Depends On:
Blocks: rust-open-enum
TreeView+ depends on / blocked
 
Reported: 2024-07-10 18:52 UTC by Oliver Steffen
Modified: 2025-04-01 21:58 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-04-01 21:58:08 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Oliver Steffen 2024-07-10 18:52:31 UTC
Spec URL: https://osteffen.fedorapeople.org/packages/rust-open-enum-derive/rust-open-enum-derive.spec
SRPM URL: https://osteffen.fedorapeople.org/packages/rust-open-enum-derive/rust-open-enum-derive-0.5.2-1.fc41.src.rpm
Description: Attribute for generating "open" fieldless enums that accept any integer value
Fedora Account System Username: osteffen

This crate is packaged directly from crates.io.

It is needed as a dependency for rust-open-enum.

This is part of the effort to add the Coconut-SVSM paravisor to Fedora.
It would enables Fedora virtualization hosts to launch confidential
virtual machines using AMD's SEV-SNP technology.
See https://fedoraproject.org/wiki/Changes/ConfidentialVirtHostAMDSEVSNP

Comment 1 Fedora Review Service 2024-07-10 21:46:38 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7723510
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2297188-open-enum-derive/fedora-rawhide-x86_64/07723510-rust-open-enum-derive/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2025-03-29 22:15:28 UTC
Looks like this was missed by Rust SIG members because it was missing the rust- prefix in the package name in the bug title. :)

Comment 3 Fabio Valentini 2025-03-31 16:21:32 UTC
Package looks good to me. Please regenerate with rust2rpm v27 before importing.

You can use a rust2rpm.toml config file with these contents to preserve the shortened Summary:

```
[package]
summary = "Attribute for generating \"open\" fieldless enums that accept any integer value"
```

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)

Comment 4 Fedora Admin user for bugzilla script actions 2025-04-01 19:42:39 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-open-enum-derive

Comment 5 Fedora Update System 2025-04-01 19:58:54 UTC
FEDORA-2025-0812a3eb6d (rust-open-enum-derive-0.5.2-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-0812a3eb6d

Comment 6 Fedora Update System 2025-04-01 21:58:08 UTC
FEDORA-2025-0812a3eb6d (rust-open-enum-derive-0.5.2-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.