Spec URL: https://github.com/LecrisUT/atuin-rpmspec/raw/f63a0e4ad8e84cf1fd4533abacecf3fa353c4936/rust-minspan/rust-minspan.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/SriRamanujam-atuin-rpmspec-7/fedora-rawhide-x86_64/07725261-rust-minspan/rust-minspan-0.1.1-1.fc41.src.rpm Description: Dependency for `atuin` Fedora Account System Username: lecris rust2rpm.toml: default --- Note: this crate is missing license file, among other issue. PR opened [1], but need advice if it's ok to add that license file. [1]: https://github.com/mwotton/minspan/pull/1
Copr build: https://copr.fedorainfracloud.org/coprs/build/7726787 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2297302-rust-minspan/fedora-rawhide-x86_64/07726787-rust-minspan/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Let's wait for https://github.com/mwotton/minspan/pull/1 to be resolved. see also https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text
Finally this got resolved :) --- Spec URL: https://github.com/LecrisUT/atuin-rpmspec/raw/eda666cdde9df26a30ce09735426c71e47231e3f/rust-minspan/rust-minspan.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/SriRamanujam-atuin-rpmspec-7/fedora-rawhide-x86_64/07799751-rust-minspan/rust-minspan-0.1.2-1.fc41.src.rpm rust2rpm.toml: default
[fedora-review-service-build]
Sorry for the wait - the SRPM URL is no longer available, can you update it please?
Spec URL: https://lecris.fedorapeople.org/reviews/rust-minspan/rust-minspan.spec SRPM URL: https://lecris.fedorapeople.org/reviews/rust-minspan/rust-minspan-0.1.2-1.fc42.src.rpm Uploaded via `fbrnch`
Thank you! Looks good to me. === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
Thank you for the review, Fabio
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-minspan
https://pagure.io/releng/fedora-scm-requests/issue/66718 https://pagure.io/releng/fedora-scm-requests/issue/66719
FEDORA-2024-d9a60d5fb8 (rust-minspan-0.1.2-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-d9a60d5fb8
FEDORA-2024-423c05957d (rust-minspan-0.1.2-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-423c05957d
FEDORA-2024-d9a60d5fb8 (rust-minspan-0.1.2-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-423c05957d has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-423c05957d` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-423c05957d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-ad14361b8b (rust-minspan-0.1.2-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-ad14361b8b
FEDORA-2024-9d86b6c662 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-9d86b6c662` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-9d86b6c662 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-ad14361b8b has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-ad14361b8b` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-ad14361b8b See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-423c05957d (rust-minspan-0.1.2-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-9d86b6c662 (rust-minspan-0.1.2-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-ad14361b8b (rust-minspan-0.1.2-1.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.