Spec URL: https://github.com/LecrisUT/atuin-rpmspec/raw/f63a0e4ad8e84cf1fd4533abacecf3fa353c4936/rust-interim/rust-interim.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/SriRamanujam-atuin-rpmspec-7/fedora-rawhide-x86_64/07725262-rust-interim/rust-interim-0.1.2-1.fc41.src.rpm Description: Dependency for `atuin` Fedora Account System Username: lecris rust2rpm.toml ```toml [package] summary = "Parses simple English dates, inspired by Linux date command" cargo-toml-patch-comments = [ "- Relax logos dependency" ] [features] enable-all = true ``` interim-fix-metadata.diff ``` --- interim-0.1.2/Cargo.toml 1970-01-01T00:00:01+00:00 +++ interim-0.1.2/Cargo.toml 2024-07-11T11:53:17.355598+00:00 @@ -33,7 +33,7 @@ default-features = false [dependencies.logos] -version = "0.14.0" +version = ">=0.13.0" [dependencies.time] version = "0.3.9" ```
Copr build: https://copr.fedorainfracloud.org/coprs/build/7726791 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2297303-rust-interim/fedora-rawhide-x86_64/07726791-rust-interim/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Notes: - logos is currently a leaf package in Fedora. It would be better to update it to 0.14 than to patch this package. - open-ended dependencies like >=0.13 are really bad. If something is compatible with both 0.13.x and 0.14.x, then use ">=0.13,<0.15" instead.
Spec URL: https://lecris.fedorapeople.org/reviews/rust-interim/rust-interim.spec SRPM URL: https://lecris.fedorapeople.org/reviews/rust-interim/rust-interim-0.1.2-1.fc40.src.rpm Using an upper bound for now since logos update will be more tricky. The commit where the version is bumped, doesn't seem related: https://github.com/conradludgate/interim/commit/bce19ca97a5cf36aad04eabb59f298b2d036b51c
Thanks, looks good to me! Note that the crate contains the readme file twice (readme.md, README.md), that should be fixable. === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version (*NOT* pre-release) filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-interim
Thank you for the review, Fabio. Upstream accidentally fixed the issue a while ago :D
FEDORA-2024-9b5e4d9303 (rust-interim-0.1.2-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-9b5e4d9303
FEDORA-2024-9b5e4d9303 (rust-interim-0.1.2-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-704b713ef8 (rust-interim-0.1.2-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-704b713ef8
FEDORA-2024-e1a0d7d1f9 (rust-interim-0.1.2-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-e1a0d7d1f9
FEDORA-2024-704b713ef8 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-704b713ef8` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-704b713ef8 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-e1a0d7d1f9 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-e1a0d7d1f9` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-e1a0d7d1f9 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-f7196d054e has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-f7196d054e` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-f7196d054e See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-e1a0d7d1f9 (rust-interim-0.1.2-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-f7196d054e (rust-interim-0.1.2-1.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-704b713ef8 (rust-interim-0.1.2-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.