Spec URL: https://yselkowitz.fedorapeople.org/rust-cargo-vendor-filterer.spec SRPM URL: https://yselkowitz.fedorapeople.org/rust-cargo-vendor-filterer-0.5.14-1.fc41.src.rpm Description: `cargo vendor`, but with filtering for platforms and more. Fedora Account System Username: yselkowitz
[fedora-review-service-build]
Taking this review General comments: - Spec file was generated with rust2rpm - vendored openssl feature was disabled --> OK - Tests were disabled because they require an active internet connection --> OK - Some dependencies were updated to match the available crate versions in Fedora --> OK APPROVED Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0". 19 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/rust-cargo-vendor- filterer/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr, /usr/share, /usr/bin, /usr/src, /usr/share/cargo, /usr/share/doc, /usr/share/cargo/registry, /usr/lib, /usr/share/licenses, /usr/src/debug [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/licenses, /usr, /usr/share/cargo, /usr/share/doc, /usr/src/debug, /usr/bin, /usr/share/cargo/registry, /usr/src, /usr/share, /usr/lib [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 3449 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in cargo- vendor-filterer , rust-cargo-vendor-filterer-devel , rust-cargo- vendor-filterer+default-devel [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define autorelease(e:s:pb:n) %{?-p:0.}%{lua: [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: cargo-vendor-filterer-0.5.14-1.fc41.x86_64.rpm rust-cargo-vendor-filterer-devel-0.5.14-1.fc41.noarch.rpm rust-cargo-vendor-filterer+default-devel-0.5.14-1.fc41.noarch.rpm rust-cargo-vendor-filterer-debugsource-0.5.14-1.fc41.x86_64.rpm rust-cargo-vendor-filterer-0.5.14-1.fc41.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpb8c2s1iv')] checks: 32, packages: 5 cargo-vendor-filterer.x86_64: W: no-manual-page-for-binary cargo-vendor-filterer rust-cargo-vendor-filterer+default-devel.noarch: W: no-documentation 5 packages and 0 specfiles checked; 0 errors, 2 warnings, 19 filtered, 0 badness; has taken 0.5 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "cargo-vendor-filterer". (none): E: there is no installed rpm "rust-cargo-vendor-filterer-debugsource". (none): E: there is no installed rpm "rust-cargo-vendor-filterer-devel". (none): E: there is no installed rpm "rust-cargo-vendor-filterer+default-devel". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://crates.io/api/v1/crates/cargo-vendor-filterer/0.5.14/download#/cargo-vendor-filterer-0.5.14.crate : CHECKSUM(SHA256) this package : b157f1dd2716933df396f083bff6d55375b1a6c49826fcdc89adee113d747040 CHECKSUM(SHA256) upstream package : b157f1dd2716933df396f083bff6d55375b1a6c49826fcdc89adee113d747040 Requires -------- cargo-vendor-filterer (rpmlib, GLIBC filtered): ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3)(64bit) libgcc_s.so.1(GCC_4.2.0)(64bit) libm.so.6()(64bit) libssl.so.3()(64bit) libssl.so.3(OPENSSL_3.0.0)(64bit) rtld(GNU_HASH) rust-cargo-vendor-filterer-devel (rpmlib, GLIBC filtered): (crate(anyhow/default) >= 1.0.0 with crate(anyhow/default) < 2.0.0~) (crate(camino/default) >= 1.0.0 with crate(camino/default) < 2.0.0~) (crate(cargo-lock/default) >= 9.0.0 with crate(cargo-lock/default) < 10.0.0~) (crate(cargo_metadata/default) >= 0.18.0 with crate(cargo_metadata/default) < 0.19.0~) (crate(clap/default) >= 4.1.0 with crate(clap/default) < 5.0.0~) (crate(clap/derive) >= 4.1.0 with crate(clap/derive) < 5.0.0~) (crate(clap/wrap_help) >= 4.1.0 with crate(clap/wrap_help) < 5.0.0~) (crate(either/default) >= 1.7.0 with crate(either/default) < 2.0.0~) (crate(flate2/default) >= 1.0.0 with crate(flate2/default) < 2.0.0~) (crate(hex/default) >= 0.4.0 with crate(hex/default) < 0.5.0~) (crate(openssl/default) >= 0.10.40 with crate(openssl/default) < 0.11.0~) (crate(serde/default) >= 1.0.0 with crate(serde/default) < 2.0.0~) (crate(serde/derive) >= 1.0.0 with crate(serde/derive) < 2.0.0~) (crate(serde_ignored/default) >= 0.1.7 with crate(serde_ignored/default) < 0.2.0~) (crate(serde_json/default) >= 1.0.80 with crate(serde_json/default) < 2.0.0~) (crate(smallvec/default) >= 1.9.0 with crate(smallvec/default) < 2.0.0~) (crate(tar/default) >= 0.4.38 with crate(tar/default) < 0.5.0~) (crate(tempfile/default) >= 3.3.0 with crate(tempfile/default) < 4.0.0~) (crate(toml/default) >= 0.7.0 with crate(toml/default) < 0.8.0~) (crate(walkdir/default) >= 2.3.3 with crate(walkdir/default) < 3.0.0~) cargo rust rust-cargo-vendor-filterer+default-devel (rpmlib, GLIBC filtered): cargo crate(cargo-vendor-filterer) rust-cargo-vendor-filterer-debugsource (rpmlib, GLIBC filtered): Provides -------- cargo-vendor-filterer: cargo-vendor-filterer cargo-vendor-filterer(x86-64) rust-cargo-vendor-filterer-devel: crate(cargo-vendor-filterer) rust-cargo-vendor-filterer-devel rust-cargo-vendor-filterer+default-devel: crate(cargo-vendor-filterer/default) rust-cargo-vendor-filterer+default-devel rust-cargo-vendor-filterer-debugsource: rust-cargo-vendor-filterer-debugsource rust-cargo-vendor-filterer-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name rust-cargo-vendor-filterer --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, Ocaml, Python, fonts, C/C++, Haskell, Perl, R, PHP, SugarActivity Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cargo-vendor-filterer
FEDORA-2024-ec1a77f01c (rust-cargo-vendor-filterer-0.5.14-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-ec1a77f01c
FEDORA-2024-e128c263ea (rust-cargo-vendor-filterer-0.5.14-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-e128c263ea
FEDORA-2024-e128c263ea has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-e128c263ea \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-e128c263ea See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2024-54a6b8bd84 has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-54a6b8bd84 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-ec1a77f01c has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-ec1a77f01c \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-ec1a77f01c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-ec1a77f01c (rust-cargo-vendor-filterer-0.5.14-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-e128c263ea (rust-cargo-vendor-filterer-0.5.14-1.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-EPEL-2024-54a6b8bd84 (rust-cargo-vendor-filterer-0.5.14-1.el9) has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report.