Spec URL: https://petersen.fedorapeople.org/reviews/ghc-safe-exceptions/ghc-safe-exceptions.spec SRPM URL: https://petersen.fedorapeople.org/reviews/ghc-safe-exceptions/ghc-safe-exceptions-0.1.7.4-1.fc41.src.rpm Description: This package provides additional safety and simplicity versus `Control.Exception` by having its functions recognize the difference between synchronous and asynchronous exceptions. As described below, synchronous exceptions are treated as _recoverable_, allowing you to catch and handle them as well as clean up after them, whereas asynchronous exceptions can only be cleaned up after. In particular, this library prevents you from making the following mistakes: * Catching and swallowing an asynchronous exception * Throwing an asynchronous exception synchronously * Throwing a synchronous exception asynchronously * Swallowing asynchronous exceptions via failing cleanup handlers Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=120826533
Copr build: https://copr.fedorainfracloud.org/coprs/build/7767672 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2299082-ghc-safe-exceptions/fedora-rawhide-x86_64/07767672-ghc-safe-exceptions/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I'll review it.
LGTM (except for noisy rpmlint output which we discussed recently). Here is my formal Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [-]: Development (unversioned) .so files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license (MIT). [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [?]: I did not test if the package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources arre not verified with gpgverify since upstream does not publish signatures. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: No %check section. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: ghc-safe-exceptions-0.1.7.4-1.fc41.x86_64.rpm ghc-safe-exceptions-devel-0.1.7.4-1.fc41.x86_64.rpm ghc-safe-exceptions-prof-0.1.7.4-1.fc41.x86_64.rpm ghc-safe-exceptions-0.1.7.4-1.fc41.src.rpm =========================================================================================================================================== rpmlint session starts ========================================================================================================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp_3_4jxw5')] checks: 32, packages: 4 ghc-safe-exceptions-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/ghc-9.4.5/lib/safe-exceptions-0.1.7.4/libHSsafe-exceptions-0.1.7.4-8XVKrMBchTjCLhdcvBwBNb.a ghc-safe-exceptions-prof.x86_64: E: static-library-without-debuginfo /usr/lib64/ghc-9.4.5/lib/safe-exceptions-0.1.7.4/libHSsafe-exceptions-0.1.7.4-8XVKrMBchTjCLhdcvBwBNb_p.a ghc-safe-exceptions.x86_64: W: no-documentation ghc-safe-exceptions-prof.x86_64: W: no-documentation ===================================================================================================== 4 packages and 0 specfiles checked; 2 errors, 2 warnings, 19 filtered, 2 badness; has taken 1.5 s ===================================================================================================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 ghc-safe-exceptions.x86_64: E: unused-direct-shlib-dependency /usr/lib64/ghc-9.4.5/lib/libHSsafe-exceptions-0.1.7.4-8XVKrMBchTjCLhdcvBwBNb-ghc9.4.5.so /lib64/libm.so.6 ghc-safe-exceptions.x86_64: E: unused-direct-shlib-dependency /usr/lib64/ghc-9.4.5/lib/libHSsafe-exceptions-0.1.7.4-8XVKrMBchTjCLhdcvBwBNb-ghc9.4.5.so /usr/lib64/ghc-9.4.5/lib/x86_64-linux-ghc-9.4.5/libHStemplate-haskell-2.19.0.0-ghc9.4.5.so ghc-safe-exceptions.x86_64: E: unused-direct-shlib-dependency /usr/lib64/ghc-9.4.5/lib/libHSsafe-exceptions-0.1.7.4-8XVKrMBchTjCLhdcvBwBNb-ghc9.4.5.so /usr/lib64/ghc-9.4.5/lib/x86_64-linux-ghc-9.4.5/libHSpretty-1.1.3.6-ghc9.4.5.so ghc-safe-exceptions.x86_64: E: unused-direct-shlib-dependency /usr/lib64/ghc-9.4.5/lib/libHSsafe-exceptions-0.1.7.4-8XVKrMBchTjCLhdcvBwBNb-ghc9.4.5.so /usr/lib64/ghc-9.4.5/lib/x86_64-linux-ghc-9.4.5/libHSghc-boot-th-9.4.5-ghc9.4.5.so ghc-safe-exceptions.x86_64: E: unused-direct-shlib-dependency /usr/lib64/ghc-9.4.5/lib/libHSsafe-exceptions-0.1.7.4-8XVKrMBchTjCLhdcvBwBNb-ghc9.4.5.so /usr/lib64/ghc-9.4.5/lib/x86_64-linux-ghc-9.4.5/libHSstm-2.5.1.0-ghc9.4.5.so ghc-safe-exceptions.x86_64: E: unused-direct-shlib-dependency /usr/lib64/ghc-9.4.5/lib/libHSsafe-exceptions-0.1.7.4-8XVKrMBchTjCLhdcvBwBNb-ghc9.4.5.so /usr/lib64/ghc-9.4.5/lib/x86_64-linux-ghc-9.4.5/libHSmtl-2.2.2-ghc9.4.5.so ghc-safe-exceptions.x86_64: E: unused-direct-shlib-dependency /usr/lib64/ghc-9.4.5/lib/libHSsafe-exceptions-0.1.7.4-8XVKrMBchTjCLhdcvBwBNb-ghc9.4.5.so /usr/lib64/ghc-9.4.5/lib/x86_64-linux-ghc-9.4.5/libHStransformers-0.5.6.2-ghc9.4.5.so ghc-safe-exceptions.x86_64: E: unused-direct-shlib-dependency /usr/lib64/ghc-9.4.5/lib/libHSsafe-exceptions-0.1.7.4-8XVKrMBchTjCLhdcvBwBNb-ghc9.4.5.so /usr/lib64/ghc-9.4.5/lib/x86_64-linux-ghc-9.4.5/libHSdeepseq-1.4.8.0-ghc9.4.5.so ghc-safe-exceptions.x86_64: E: unused-direct-shlib-dependency /usr/lib64/ghc-9.4.5/lib/libHSsafe-exceptions-0.1.7.4-8XVKrMBchTjCLhdcvBwBNb-ghc9.4.5.so /usr/lib64/ghc-9.4.5/lib/x86_64-linux-ghc-9.4.5/libHSarray-0.5.4.0-ghc9.4.5.so ghc-safe-exceptions.x86_64: E: unused-direct-shlib-dependency /usr/lib64/ghc-9.4.5/lib/libHSsafe-exceptions-0.1.7.4-8XVKrMBchTjCLhdcvBwBNb-ghc9.4.5.so /usr/lib64/ghc-9.4.5/lib/x86_64-linux-ghc-9.4.5/libHSghc-bignum-1.3-ghc9.4.5.so ghc-safe-exceptions.x86_64: E: unused-direct-shlib-dependency /usr/lib64/ghc-9.4.5/lib/libHSsafe-exceptions-0.1.7.4-8XVKrMBchTjCLhdcvBwBNb-ghc9.4.5.so /lib64/libgmp.so.10 ghc-safe-exceptions.x86_64: E: undefined-non-weak-symbol /usr/lib64/ghc-9.4.5/lib/libHSsafe-exceptions-0.1.7.4-8XVKrMBchTjCLhdcvBwBNb-ghc9.4.5.so stg_thawArrayzh (/usr/lib64/ghc-9.4.5/lib/x86_64-linux-ghc-9.4.5/libHSghc-prim-0.9.0-ghc9.4.5.so) ... <skipped more than 100 of lines> ... ghc-safe-exceptions.x86_64: E: undefined-non-weak-symbol /usr/lib64/ghc-9.4.5/lib/libHSsafe-exceptions-0.1.7.4-8XVKrMBchTjCLhdcvBwBNb-ghc9.4.5.so newCAF (/usr/lib64/ghc-9.4.5/lib/libHSsafe-exceptions-0.1.7.4-8XVKrMBchTjCLhdcvBwBNb-ghc9.4.5.so) ghc-safe-exceptions-prof.x86_64: E: static-library-without-debuginfo /usr/lib64/ghc-9.4.5/lib/safe-exceptions-0.1.7.4/libHSsafe-exceptions-0.1.7.4-8XVKrMBchTjCLhdcvBwBNb_p.a ghc-safe-exceptions-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/ghc-9.4.5/lib/safe-exceptions-0.1.7.4/libHSsafe-exceptions-0.1.7.4-8XVKrMBchTjCLhdcvBwBNb.a ghc-safe-exceptions-prof.x86_64: W: no-documentation ghc-safe-exceptions.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 619 errors, 2 warnings, 15 filtered, 619 badness; has taken 1.2 s Unversioned so-files -------------------- ghc-safe-exceptions: /usr/lib64/ghc-9.4.5/lib/libHSsafe-exceptions-0.1.7.4-8XVKrMBchTjCLhdcvBwBNb-ghc9.4.5.so Source checksums ---------------- https://hackage.haskell.org/package/safe-exceptions-0.1.7.4/safe-exceptions.cabal#/safe-exceptions-0.1.7.4.cabal : CHECKSUM(SHA256) this package : 8bb7261bd54bd58acfcb154be6a161fb6d0d31a1852aadc8e927d2ad2d7651d1 CHECKSUM(SHA256) upstream package : 8bb7261bd54bd58acfcb154be6a161fb6d0d31a1852aadc8e927d2ad2d7651d1 https://hackage.haskell.org/package/safe-exceptions-0.1.7.4/safe-exceptions-0.1.7.4.tar.gz : CHECKSUM(SHA256) this package : 3c51d8d50c9b60ff8bf94f942fd92e3bea9e62c5afa778dfc9f707b79da41ef6 CHECKSUM(SHA256) upstream package : 3c51d8d50c9b60ff8bf94f942fd92e3bea9e62c5afa778dfc9f707b79da41ef6 Requires -------- ghc-safe-exceptions (rpmlib, GLIBC filtered): libHSarray-0.5.4.0-ghc9.4.5.so()(64bit) libHSbase-4.17.1.0-ghc9.4.5.so()(64bit) libHSdeepseq-1.4.8.0-ghc9.4.5.so()(64bit) libHSexceptions-0.10.5-ghc9.4.5.so()(64bit) libHSghc-bignum-1.3-ghc9.4.5.so()(64bit) libHSghc-boot-th-9.4.5-ghc9.4.5.so()(64bit) libHSghc-prim-0.9.0-ghc9.4.5.so()(64bit) libHSmtl-2.2.2-ghc9.4.5.so()(64bit) libHSpretty-1.1.3.6-ghc9.4.5.so()(64bit) libHSstm-2.5.1.0-ghc9.4.5.so()(64bit) libHStemplate-haskell-2.19.0.0-ghc9.4.5.so()(64bit) libHStransformers-0.5.6.2-ghc9.4.5.so()(64bit) libc.so.6()(64bit) libgmp.so.10()(64bit) libm.so.6()(64bit) rtld(GNU_HASH) ghc-safe-exceptions-devel (rpmlib, GLIBC filtered): ghc-compiler ghc-devel(base-4.17.1.0) ghc-devel(deepseq-1.4.8.0) ghc-devel(exceptions-0.10.5) ghc-devel(transformers-0.5.6.2) ghc-safe-exceptions(x86-64) ghc-safe-exceptions-prof (rpmlib, GLIBC filtered): ghc-prof(base-4.17.1.0) ghc-prof(deepseq-1.4.8.0) ghc-prof(exceptions-0.10.5) ghc-prof(transformers-0.5.6.2) ghc-safe-exceptions-devel(x86-64) Provides -------- ghc-safe-exceptions: ghc-safe-exceptions ghc-safe-exceptions(x86-64) libHSsafe-exceptions-0.1.7.4-8XVKrMBchTjCLhdcvBwBNb-ghc9.4.5.so()(64bit) ghc-safe-exceptions-devel: ghc-devel(safe-exceptions-0.1.7.4-8XVKrMBchTjCLhdcvBwBNb) ghc-safe-exceptions-devel ghc-safe-exceptions-devel(x86-64) ghc-safe-exceptions-static ghc-safe-exceptions-static(x86-64) ghc-safe-exceptions-prof: ghc-prof(safe-exceptions-0.1.7.4-8XVKrMBchTjCLhdcvBwBNb) ghc-safe-exceptions-prof ghc-safe-exceptions-prof(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2299082 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Haskell, Shell-api, Generic Disabled plugins: Perl, Ocaml, SugarActivity, Python, R, fonts, PHP, Java Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH I don't see any other issues so this package is ================ === APPROVED === ================
The Pagure repository was created at https://src.fedoraproject.org/rpms/ghc-safe-exceptions
Thank you very much for the review, Peter