Bug 2299112 - Review Request: rust-spin_sleep - Rust accurate sleeping
Summary: Review Request: rust-spin_sleep - Rust accurate sleeping
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/spin_sleep
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-07-21 10:53 UTC by Ryan
Modified: 2024-09-25 00:50 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-09-25 00:50:39 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 7767707 to 8032189 (306 bytes, patch)
2024-09-18 19:24 UTC, Fedora Review Service
no flags Details | Diff

Description Ryan 2024-07-21 10:53:03 UTC
Spec URL: https://errornointernet.fedorapeople.org/review-requests/rust-spin_sleep/rust-spin_sleep.spec
SRPM URL: https://errornointernet.fedorapeople.org/review-requests/rust-spin_sleep/rust-spin_sleep-1.2.0-1.fc40.src.rpm
Description: Rust accurate sleeping. Only use native sleep as far as it can be trusted, then spin.
Fedora Account System Username: errornointernet

Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=120830243

Unmodified spec file generated by rust2rpm.
This is a re-review request for a retired package.

Comment 1 Fedora Review Service 2024-07-21 18:50:31 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7767707
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2299112-rust-spin_sleep/fedora-rawhide-x86_64/07767707-rust-spin_sleep/fedora-review/review.txt

Found issues:

- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/rust-spin_sleep
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2024-09-15 12:59:50 UTC
Version 1.2.1 was released, can you update the package?

Comment 4 Fedora Review Service 2024-09-18 19:24:49 UTC
Created attachment 2047462 [details]
The .spec file difference from Copr build 7767707 to 8032189

Comment 5 Fedora Review Service 2024-09-18 19:24:52 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8032189
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2299112-rust-spin_sleep/fedora-rawhide-x86_64/08032189-rust-spin_sleep/fedora-review/review.txt

Found issues:

- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/rust-spin_sleep
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 6 Fabio Valentini 2024-09-23 10:53:45 UTC
Looks good to me, thanks!

===

Package was generated with rust2rpm, simplifying the review.

✅❌❓🫤

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

-> skip those that don't make sense for unretirements

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version (*NOT* pre-release) filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 7 Fedora Update System 2024-09-25 00:46:15 UTC
FEDORA-2024-d933646926 (rust-spin_sleep-1.2.1-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-d933646926

Comment 8 Fedora Update System 2024-09-25 00:50:39 UTC
FEDORA-2024-d933646926 (rust-spin_sleep-1.2.1-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.