Spec URL: https://peter.fedorapeople.org/packages/erlang-gpb.spec SRPM URL: https://peter.fedorapeople.org/packages/erlang-gpb-4.21.1-1.fc40.src.rpm Description: A Google Protobuf implementation for Erlang. Fedora Account System Username: peter Koji scratch build: * https://koji.fedoraproject.org/koji/taskinfo?taskID=120920324
Copr build: https://copr.fedorainfracloud.org/coprs/build/7778024 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2299556-erlang-gpb/fedora-rawhide-x86_64/07778024-erlang-gpb/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU Lesser General Public License, Version 2.1", "GNU Lesser General Public License v2.1 or later", "BSD 3-Clause License". 119 files have unknown license. Detailed output of licensecheck in /home/jon/Reviews/erlang-gpb/licensecheck.txt [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/erlang/lib, /usr/share/erlang, /usr, /usr/share/doc, /usr/share/licenses, /usr/share, /usr/bin [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/erlang/lib, /usr/share/erlang, /usr, /usr/share/doc, /usr/share/licenses, /usr/share, /usr/bin [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 49100 bytes in 8 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: erlang-gpb-4.21.1-1.fc41.noarch.rpm erlang-gpb-4.21.1-1.fc41.src.rpm =============================================== rpmlint session starts =============================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp9cat67zy')] checks: 32, packages: 2 erlang-gpb.noarch: W: no-manual-page-for-binary protoc-erl erlang-gpb.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gpb-4.21.1/ebin/gpb.beam /builddir/build/BUILD/erlang-gpb-4.21.1-build/gpb-4.21.1/src/gpb.erl erlang-gpb.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gpb-4.21.1/ebin/gpb_analyzer.beam /builddir/build/BUILD/erlang-gpb-4.21.1-build/gpb-4.21.1/src/gpb_analyzer.erl erlang-gpb.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gpb-4.21.1/ebin/gpb_codegen.beam /builddir/build/BUILD/erlang-gpb-4.21.1-build/gpb-4.21.1/src/gpb_codegen.erl erlang-gpb.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gpb-4.21.1/ebin/gpb_codemorpher.beam /builddir/build/BUILD/erlang-gpb-4.21.1-build/gpb-4.21.1/src/gpb_codemorpher.erl erlang-gpb.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gpb-4.21.1/ebin/gpb_compile.beam /builddir/build/BUILD/erlang-gpb-4.21.1-build/gpb-4.21.1/src/gpb_compile.erl erlang-gpb.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gpb-4.21.1/ebin/gpb_compile_descr.beam /builddir/build/BUILD/erlang-gpb-4.21.1-build/gpb-4.21.1/descr_src/gpb_compile_descr.erl erlang-gpb.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gpb-4.21.1/ebin/gpb_decoders_lib.beam /builddir/build/BUILD/erlang-gpb-4.21.1-build/gpb-4.21.1/src/gpb_decoders_lib.erl erlang-gpb.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gpb-4.21.1/ebin/gpb_defs.beam /builddir/build/BUILD/erlang-gpb-4.21.1-build/gpb-4.21.1/src/gpb_defs.erl erlang-gpb.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gpb-4.21.1/ebin/gpb_descriptor.beam /builddir/build/BUILD/erlang-gpb-4.21.1-build/gpb-4.21.1/descr_src/gpb_descriptor.erl erlang-gpb.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gpb-4.21.1/ebin/gpb_gen_decoders.beam /builddir/build/BUILD/erlang-gpb-4.21.1-build/gpb-4.21.1/src/gpb_gen_decoders.erl erlang-gpb.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gpb-4.21.1/ebin/gpb_gen_encoders.beam /builddir/build/BUILD/erlang-gpb-4.21.1-build/gpb-4.21.1/src/gpb_gen_encoders.erl erlang-gpb.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gpb-4.21.1/ebin/gpb_gen_introspect.beam /builddir/build/BUILD/erlang-gpb-4.21.1-build/gpb-4.21.1/src/gpb_gen_introspect.erl erlang-gpb.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gpb-4.21.1/ebin/gpb_gen_json_decoders.beam /builddir/build/BUILD/erlang-gpb-4.21.1-build/gpb-4.21.1/src/gpb_gen_json_decoders.erl erlang-gpb.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gpb-4.21.1/ebin/gpb_gen_json_encoders.beam /builddir/build/BUILD/erlang-gpb-4.21.1-build/gpb-4.21.1/src/gpb_gen_json_encoders.erl erlang-gpb.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gpb-4.21.1/ebin/gpb_gen_mergers.beam /builddir/build/BUILD/erlang-gpb-4.21.1-build/gpb-4.21.1/src/gpb_gen_mergers.erl erlang-gpb.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gpb-4.21.1/ebin/gpb_gen_nif.beam /builddir/build/BUILD/erlang-gpb-4.21.1-build/gpb-4.21.1/src/gpb_gen_nif.erl erlang-gpb.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gpb-4.21.1/ebin/gpb_gen_translators.beam /builddir/build/BUILD/erlang-gpb-4.21.1-build/gpb-4.21.1/src/gpb_gen_translators.erl erlang-gpb.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gpb-4.21.1/ebin/gpb_gen_types.beam /builddir/build/BUILD/erlang-gpb-4.21.1-build/gpb-4.21.1/src/gpb_gen_types.erl erlang-gpb.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gpb-4.21.1/ebin/gpb_gen_verifiers.beam /builddir/build/BUILD/erlang-gpb-4.21.1-build/gpb-4.21.1/src/gpb_gen_verifiers.erl erlang-gpb.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gpb-4.21.1/ebin/gpb_lib.beam /builddir/build/BUILD/erlang-gpb-4.21.1-build/gpb-4.21.1/src/gpb_lib.erl erlang-gpb.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gpb-4.21.1/ebin/gpb_names.beam /builddir/build/BUILD/erlang-gpb-4.21.1-build/gpb-4.21.1/src/gpb_names.erl erlang-gpb.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gpb-4.21.1/ebin/gpb_parse.beam /builddir/build/BUILD/erlang-gpb-4.21.1-build/gpb-4.21.1/src/gpb_parse.erl erlang-gpb.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gpb-4.21.1/ebin/gpb_parse_descr.beam /builddir/build/BUILD/erlang-gpb-4.21.1-build/gpb-4.21.1/descr_src/gpb_parse_descr.erl erlang-gpb.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gpb-4.21.1/ebin/gpb_scan.beam /builddir/build/BUILD/erlang-gpb-4.21.1-build/gpb-4.21.1/src/gpb_scan.erl ========= 2 packages and 0 specfiles checked; 0 errors, 25 warnings, 7 filtered, 0 badness; has taken 1.6 s ========== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 erlang-gpb.noarch: W: no-manual-page-for-binary protoc-erl 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 3 filtered, 0 badness; has taken 0.9 s Source checksums ---------------- https://github.com/tomas-abrahamsson/gpb/archive/4.21.1/gpb-4.21.1.tar.gz : CHECKSUM(SHA256) this package : 9d0474a156fd65b77ea6acbf1421b1cc0a0328ff6fe367880ce5307c22b8fe9b CHECKSUM(SHA256) upstream package : 9d0474a156fd65b77ea6acbf1421b1cc0a0328ff6fe367880ce5307c22b8fe9b Requires -------- erlang-gpb (rpmlib, GLIBC filtered): /usr/bin/escript erlang-compiler(x86-64) erlang-erts(x86-64) erlang-eunit(x86-64) erlang-kernel(x86-64) erlang-stdlib(x86-64) erlang-syntax_tools(x86-64) Provides -------- erlang-gpb: erlang-gpb Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -r -n erlang-gpb-4.21.1-1.fc40.src.rpm Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: fonts, Python, SugarActivity, C/C++, R, Java, Perl, Ocaml, Haskell, PHP Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
[!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. BSD 3-Clause License is not included. However, it is included in full on each of the source files. I don't know if that counts. Additionally, I don't know the consequence of "erlang-gpb.noarch: W: beam-was-not-recompiled" and if it's okay or not.
(In reply to Jonathan Steffan from comment #3) > [!]: If the source package does not include license text(s) as a separate > file from upstream, the packager SHOULD query upstream to include it. > > BSD 3-Clause License is not included. However, it is included in full on > each of the source files. I don't know if that counts. I think it's ok. However in such a cases we have a policy that we should contact upstream and ask them to provide licensing terms in a separate file which I've just done here: * https://github.com/tomas-abrahamsson/gpb/pull/235 > Additionally, I don't know the consequence of "erlang-gpb.noarch: W: > beam-was-not-recompiled" and if it's okay or not. This is a false positive. I'll look into this someday. My wild guess our build tool which we're using for Erlang stuff (rebar3) doesn't care about preserving timestamps at all or messes up with meta-information in some other ways.
APPROVED
The Pagure repository was created at https://src.fedoraproject.org/rpms/erlang-gpb
Thank you!
FEDORA-2024-676c47b2b2 (erlang-gpb-4.21.1-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-676c47b2b2
FEDORA-2024-676c47b2b2 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-676c47b2b2 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-676c47b2b2 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-914570eebf has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-914570eebf \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-914570eebf See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-914570eebf (erlang-gpb-4.21.1-1.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-676c47b2b2 (erlang-gpb-4.21.1-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.