Spec URL: https://principis.fedorapeople.org/qzxing.spec SRPM URL: https://principis.fedorapeople.org/qzxing-3.3.0-1.fc41.src.rpm Description: Qt/QML wrapper library for the ZXing barcode image processing library. Fedora Account System Username: principis
I'll review it (as soon as Fedorapeople will be back online).
Looks Good to Me. Hoewver I see you have "%bcond_without tests" line and yet you're not using this condition anywhere. Either remove it or add %check section. Also looks like this package bundles zxing library. We had it in Fedora repos while ago but now it's retired. Anyway a proper "Provides: bundled(zxing)" should be added. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license (Apache-2.0). [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [!]: Package contains no bundled libraries without FPC exception. See my comment above. [x]: Changelog in prescribed format (%autochangelog). [x]: Sources contain only permissible code or content. [-]: Package is not a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: No large documentation files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: I did not test if the package functions as described. [x]: Latest version is packaged (3.3.0). [-]: Package does not include license text files separate from upstream. [-]: No extra patches. [-]: Unstream does not offer GPG signatures. [?]: I did not test if the package compiles and builds into binary rpms on all supported architectures. [!]: %check is present and all tests pass. See my comment above. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: qzxing-3.3.0-1.fc41.x86_64.rpm qzxing-devel-3.3.0-1.fc41.x86_64.rpm qzxing-debuginfo-3.3.0-1.fc41.x86_64.rpm qzxing-debugsource-3.3.0-1.fc41.x86_64.rpm qzxing-3.3.0-1.fc41.src.rpm =========================================================================================================================================== rpmlint session starts ========================================================================================================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp_by8fuk9')] checks: 32, packages: 5 qzxing.src: E: spelling-error ('barcode', '%description -l en_US barcode -> bar code, bar-code, barcarole') qzxing.x86_64: E: spelling-error ('barcode', '%description -l en_US barcode -> bar code, bar-code, barcarole') qzxing.spec: W: patch-not-applied Patch1: 0001-fix-libdir.patch qzxing.spec: W: patch-not-applied Patch2: 0002-match-badly-printed-QR-codes.patch qzxing-devel.x86_64: W: no-documentation qzxing.spec:48: W: mixed-use-of-spaces-and-tabs (spaces: line 11, tab: line 48) ===================================================================================================== 5 packages and 0 specfiles checked; 2 errors, 4 warnings, 30 filtered, 2 badness; has taken 3.8 s ===================================================================================================== Rpmlint (debuginfo) ------------------- Checking: qzxing-debuginfo-3.3.0-1.fc41.x86_64.rpm =========================================================================================================================================== rpmlint session starts ========================================================================================================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp7pizzed0')] checks: 32, packages: 1 ====================================================================================================== 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.7 s ===================================================================================================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4 qzxing.x86_64: E: spelling-error ('barcode', '%description -l en_US barcode -> bar code, bar-code, barcarole') qzxing-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 1 errors, 1 warnings, 26 filtered, 1 badness; has taken 2.5 s Source checksums ---------------- https://github.com/ftylitak/qzxing/archive/v3.3.0/qzxing-3.3.0.tar.gz : CHECKSUM(SHA256) this package : 2cb1c8889544e1c2d8ce77ef607db0219bd947322eb550faed636b4853072fa2 CHECKSUM(SHA256) upstream package : 2cb1c8889544e1c2d8ce77ef607db0219bd947322eb550faed636b4853072fa2 Requires -------- qzxing (rpmlib, GLIBC filtered): libQt6Core.so.6()(64bit) libQt6Core.so.6(Qt_6)(64bit) libQt6Core.so.6(Qt_6.7)(64bit) libQt6Gui.so.6()(64bit) libQt6Gui.so.6(Qt_6)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) qzxing-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libQZXing.so.3()(64bit) qzxing(x86-64) qzxing-debuginfo (rpmlib, GLIBC filtered): qzxing-debugsource (rpmlib, GLIBC filtered): Provides -------- qzxing: libQZXing.so.3()(64bit) qzxing qzxing(x86-64) qzxing-devel: pkgconfig(QZXing) qzxing-devel qzxing-devel(x86-64) qzxing-debuginfo: debuginfo(build-id) libQZXing.so.3.3.0-3.3.0-1.fc41.x86_64.debug()(64bit) qzxing-debuginfo qzxing-debuginfo(x86-64) qzxing-debugsource: qzxing-debugsource qzxing-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2299900 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, C/C++, Shell-api Disabled plugins: Java, Python, SugarActivity, PHP, R, fonts, Ocaml, Perl, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Please address my comments before uploading. That said this package is ================ === APPROVED === ================
(In reply to Peter Lemenkov from comment #2) > Looks Good to Me. Hoewver I see you have "%bcond_without tests" line and > yet you're not using this condition anywhere. Either remove it or add %check > section. Thanks for noticing, I'll remove it. Context about why the tests are not used: the tests need a git submodule, but even then I'm not sure how they should be used. Half of the tests fail and it seems like they should be compared to an output file in the repo, which also seems outdated. I don't think it's worth the effort. > Also looks like this package bundles zxing library. We had it in > Fedora repos while ago but now it's retired. Anyway a proper "Provides: > bundled(zxing)" should be added. A fork is still in the repos as `zxing-cpp`, sadly the sources used by qzxing are vastly different. I'll add the provides, thanks!
The Pagure repository was created at https://src.fedoraproject.org/rpms/qzxing
FEDORA-2024-4c661e1e38 (qzxing-3.3.0-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-4c661e1e38
FEDORA-2024-4c661e1e38 (qzxing-3.3.0-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.