Spec URL: https://trix.fedorapeople.org/nnpack.spec SRPM URL: https://trix.fedorapeople.org/nnpack-1.0%5egit20230202.70a77f4-1.fc40.src.rpm NNPACK is an acceleration package for neural network computations. NNPACK aims to provide high-performance implementations of convnet layers for multi-core CPUs. NNPACK is not intended to be directly used by machine learning researchers; instead it provides low-level performance primitives leveraged in leading deep learning frameworks, such as PyTorch, Caffe2, MXNet, tiny-dnn, Caffe, Torch, and Darknet. nnpack is needed by python-torch to improve cpu performance Reproducible: Always
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 2-Clause License". 252 files have unknown license. Detailed output of licensecheck in /home/jon/Reviews/nnpack/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/doc, /usr/include, /usr/src/debug, /usr/src, /usr, /usr/lib64, /usr/lib, /usr/share, /usr/share/licenses [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr, /usr/lib64, /usr/lib, /usr/share, /usr/share/doc, /usr/include, /usr/src/debug, /usr/src, /usr/share/licenses [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 9264 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: nnpack-1.0^git20230202.70a77f4-1.fc41.x86_64.rpm nnpack-devel-1.0^git20230202.70a77f4-1.fc41.x86_64.rpm nnpack-debuginfo-1.0^git20230202.70a77f4-1.fc41.x86_64.rpm nnpack-debugsource-1.0^git20230202.70a77f4-1.fc41.x86_64.rpm nnpack-1.0^git20230202.70a77f4-1.fc41.src.rpm =================================================================== rpmlint session starts =================================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpf_2u7f5u')] checks: 32, packages: 5 nnpack.src: E: spelling-error ('convnet', '%description -l en_US convnet -> convent, convene, coronet') nnpack.src: E: spelling-error ('dnn', '%description -l en_US dnn -> den, din, inn') nnpack.x86_64: E: spelling-error ('convnet', '%description -l en_US convnet -> convent, convene, coronet') nnpack.x86_64: E: spelling-error ('dnn', '%description -l en_US dnn -> den, din, inn') nnpack-devel.x86_64: W: no-documentation ============================= 5 packages and 0 specfiles checked; 4 errors, 1 warnings, 30 filtered, 4 badness; has taken 0.4 s ============================== Rpmlint (debuginfo) ------------------- Checking: nnpack-debuginfo-1.0^git20230202.70a77f4-1.fc41.x86_64.rpm =================================================================== rpmlint session starts =================================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpcgg0l2rk')] checks: 32, packages: 1 ============================== 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.1 s ============================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4 nnpack.x86_64: E: spelling-error ('convnet', '%description -l en_US convnet -> convent, convene, coronet') nnpack.x86_64: E: spelling-error ('dnn', '%description -l en_US dnn -> den, din, inn') nnpack-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 2 errors, 1 warnings, 26 filtered, 2 badness; has taken 0.4 s Source checksums ---------------- https://github.com/Maratyszcza/nnpack/archive/70a77f485e8b934224f3a79efd8edcd84cd377b8/NNPACK-70a77f4.tar.gz : CHECKSUM(SHA256) this package : 3d8e1462a390dd0309924edbaefb15139d7135ee6be127cc82950b75bd9835bc CHECKSUM(SHA256) upstream package : 3d8e1462a390dd0309924edbaefb15139d7135ee6be127cc82950b75bd9835bc Requires -------- nnpack (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcpuinfo.so.23.11.04()(64bit) libpthreadpool.so.23.8.29()(64bit) rtld(GNU_HASH) nnpack-devel (rpmlib, GLIBC filtered): libnnpack.so.23.2.2()(64bit) nnpack(x86-64) nnpack-debuginfo (rpmlib, GLIBC filtered): nnpack-debugsource (rpmlib, GLIBC filtered): Provides -------- nnpack: libnnpack.so.23.2.2()(64bit) nnpack nnpack(x86-64) nnpack-devel: nnpack-devel nnpack-devel(x86-64) nnpack-debuginfo: debuginfo(build-id) libnnpack.so.23.2.2-1.0^git20230202.70a77f4-1.fc41.x86_64.debug()(64bit) nnpack-debuginfo nnpack-debuginfo(x86-64) nnpack-debugsource: nnpack-debugsource nnpack-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -r -n nnpack-1.0^git20230202.70a77f4-1.fc40.src.rpm Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, C/C++, Generic Disabled plugins: SugarActivity, PHP, Ocaml, Perl, fonts, R, Python, Java, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
[!]: Patches link to upstream bugs/comments/lists or are otherwise justified. I reviewed the patch and upstream cmake and wonder if it should be expanded and submitted upstream? Seems like a pretty stale project so maybe it's not worth it. With that, we are setting a downstream soname version. Is it best to use a date coded version or just set it to 0 so if upstream ever does proper versioning we wont be in the way? What is currently patched is valid, just documenting the decision. [!]: %check is present and all tests pass. Upstream tests not working so this is disabled intentionally. APPROVED
The Pagure repository was created at https://src.fedoraproject.org/rpms/nnpack