f35-backgrounds failed to build from source in Fedora rawhide/f41 https://koji.fedoraproject.org/koji/taskinfo?taskID=120651593 For details on the mass rebuild see: https://fedoraproject.org/wiki/Fedora_41_Mass_Rebuild Please fix f35-backgrounds at your earliest convenience and set the bug's status to ASSIGNED when you start fixing it. If the bug remains in NEW state for 8 weeks, f35-backgrounds will be orphaned. Before branching of Fedora 42, f35-backgrounds will be retired, if it still fails to build. For more details on the FTBFS policy, please visit: https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/
Created attachment 2041070 [details] build.log
Created attachment 2041071 [details] root.log file root.log too big, will only attach last 32768 bytes
Created attachment 2041072 [details] state.log
To fix those we just need to change the build dependency to kde*4*-filesystem. I guess the macros were moved there in the f40 release. I have mock-built successfully with this change against f40 and f41. Would you like PRs to fix this? On my Fedora 41 I have outdated builds (fc39 suffix) for a number of background packages (f25, f26, f28, f30, f31, f32, f35).
(In reply to David Auer from comment #4) > To fix those we just need to change the build dependency to > kde*4*-filesystem. I guess the macros were moved there in the f40 release. I > have mock-built successfully with this change against f40 and f41. Would you > like PRs to fix this? > > On my Fedora 41 I have outdated builds (fc39 suffix) for a number of > background packages (f25, f26, f28, f30, f31, f32, f35). Please do. Thank you.
Thanks, for f35 I triggered a build and the update should land in rawhide automatically. (https://bodhi.fedoraproject.org/updates/FEDORA-2024-24959a672f) Shall we also merge and update this in f41 and maybe even f40? I personally would like to see it in f41 because I'm kind of on a mission to reduce the number of packages on my system that are not built against the current release. (Whether or not that is a really important mission is probably debatable, so I'd totally understand if you don't think we should create those extra updates.) From a quick glance I'd say we need to apply the same fix for f23 .. f32, that is 10 pull requests for the rawhide updates and 10 builds. Depending on the response to my previous question it may be even 20 or 30 of those. For me it would be more efficient if I could push those directly as co-maintainer but I'm also happy to got the PR route if you prefer that. Just let me know how to proceed. Cheers David
Let's do the merge for all affected backgrounds to reduce burden on future update. It seems you have proven packager privilege so you can push the update. If not, let know your username to add as co-maintainer.
No, I'm packager but not provenpackager. FAS is "dreua". > Let's do the merge for all affected backgrounds to reduce burden on future update. I'm not sure I understand you correctly here. My intention is to fix all packages at least in the rawhide/main branch so for future releases and updates everything is set. The question remains if we should also merge this back into f41 and/or f40 or just leave those with the older packages until they are eol. The packages don't appear to be broken so both is fine I guess. I'd update f41 mainly for my personal taste (and maybe others who wonder why they have packages build against f39 installed on their system, who knows?). Thanks for making me co-maintainer, I'm ready to start updating once that is done :)
I see now where we you might have misunderstood me: When I talk about f40 and f41 specifically here, I mean builds/updates for those releases, not the f40/41-backgrounds packages ;) I always meant to do that for all fXX-backgrounds packages affected, i.e. f23 until including f32 and f35 (already updated for rawhide). Let me know if there are any more background packages affected which I might have missed.
I should have spoken up back with the original pull request, but how about we fix this in a more sustainable way. kde4-filesystem is a very old, package. It would have been removed long ago except so many spec files use it's macros. The macro that many people are using (including the older background rpms) is %_kde4_datadir But guess what: %_kde4_datadir = %_datadir How about we remove the dependency, and change the macro. This is all it takes -BuildRequires: kde4-filesystem -%{_kde4_datadir}/wallpapers/%{Bg_Name}/ +%{_datadir}/wallpapers/%{Bg_Name}/ -%{_kde4_datadir}/wallpapers/%{Bg_Name}_*/ +%{_datadir}/wallpapers/%{Bg_Name}_*/
Thats good to know, it's not too late ;) I don't know the backgrounds of these packages or why it was done like this in the first place but your suggestion looks good to me. There is also "Requires: kde-filesystem" should that stay as is or can that also be removed or changed to something better?
oh, I missed that. Yes, that can be removed.
(In reply to David Auer from comment #8) > > Thanks for making me co-maintainer, I'm ready to start updating once that is > done :) I added you as co-maintainer for the remaining fedora backgrounds needed an update. Thanks for taking care. =)
My packaging dashboard is quite red, so thank you :) It looks like you missed f25 and f35 though, maybe you could add those so I can do it all in one batch. Since no other opinions came up here, I'll create upgrades for rawhide and the f41 release. I assume there will be still some people upgrading from f40 which might have the older background packages installed and so they get a fresh build. @Troy: I had another look at that and found out that the kde-filesystem owns the "/usr/share/wallpapers" directory which would be used unowned otherwise. While not strictly necessary I think it is should stay as runtime requirement.
(In reply to David Auer from comment #14) > My packaging dashboard is quite red, so thank you :) It looks like you > missed f25 and f35 though, maybe you could add those so I can do it all in > one batch. > You are now added on both f25 and f35 background. =)
FEDORA-2024-f18232d800 (f35-backgrounds-35.0.1-12.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-f18232d800
FEDORA-2024-f18232d800 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-f18232d800` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-f18232d800 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
The builds for rawhide and f41 are done, just created the update: https://bodhi.fedoraproject.org/updates/FEDORA-2024-bb1677ad00 Once that hits stable I'm happy and done with the stuff I came here for. I have now some scripts in place to automate the repetitive tasks, so let me know if you want me to remove the kde4-filesystem dependency from the remaining packages I have access to or if someone wants me to update the older backgrounds. (Those with release names instead of numbers. I'd need co-maintainer access first of course and ideally a list of those names.)
FEDORA-2024-f18232d800 (f35-backgrounds-35.0.1-12.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
I believe this is all done, thanks everyone!