Bug 230164 - Review Request: rt73usb-firmware - Firmware for Ralink® RT2571W/RT2671 A/B/G network adaptors
Review Request: rt73usb-firmware - Firmware for Ralink® RT2571W/RT2671 A/B/G...
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Xavier Lamien
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-02-26 17:39 EST by Nicolas Chauvet (kwizart)
Modified: 2007-11-30 17:11 EST (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-10-02 06:52:46 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
lxtnow: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Nicolas Chauvet (kwizart) 2007-02-26 17:39:47 EST
Spec URL:
http://kwizart.free.fr/fedora/6/testing/rt2x00-firmware/rt71w-firmware.spec
SRPM URL:
http://kwizart.free.fr/fedora/6/testing/rt2x00-firmware/rt71w-firmware-1.8-2.kwizart.fc6.src.rpm
Description: Firmware for RT71 802.11 wireless devices 

This firmware allow using Ralink wireless device using the rt73usb module included since 2.6.21rc1 inside the linux kernel. It can also be used since 2.6.18 using the rt2x00 external module and older kernel can use rt73 legacy version... 

We should ask for proper redistribution permission, this firmware do not provides any documentation, it sould a least bundle permission for redistribution to be accepted on Fedora Extras...

Sending a mail to Ralink about this...
FE-LEGAL
Comment 1 Xavier Lamien 2007-02-26 20:31:12 EST
review is coming ;-)
Comment 2 Xavier Lamien 2007-02-26 22:51:13 EST
Just one thing:

 hardcoded path must not be use.

 use "%{_lib}/firmware" instead of "/lib/firmware"
Comment 3 Xavier Lamien 2007-02-26 23:05:44 EST
typo: it's Hardcoded library path 
Comment 4 Xavier Lamien 2007-02-27 08:47:10 EST
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License is Distributable
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum
OK - BuildRequires isn't required
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.

OK - Package builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
+  - rpmlint output:
SRPM: E: hardcoded-library-path -> can be ignored
RPM : E: hardcoded-library-path -> can be ignored

OK - build in mock (FC-6 and FC-devel).
OK - Should function as described.
OK - Should have dist tag
OK - Should package latest version

Comment 5 Xavier Lamien 2007-02-27 09:33:34 EST
Typo :

+  - licences and Doc are requesting
Comment 6 Bill Nottingham 2007-03-19 16:15:35 EDT
Source download link is invalid.
Comment 7 Nicolas Chauvet (kwizart) 2007-03-19 17:07:06 EDT
Updated link (changes from .com to .com.tw )
Fixed licence field

Spec URL:
http://kwizart.free.fr/fedora/6/testing/rt2x00-firmware/rt71w-firmware.spec
SRPM URL:
http://kwizart.free.fr/fedora/6/testing/rt2x00-firmware/rt71w-firmware-1.8-3.kwizart.fc6.src.rpm
Description: Firmware for RT71 802.11 wireless devices 
Comment 8 Till Maas 2007-07-30 11:09:17 EDT
It seems you forgot to block Fe-Legal and to assign this review.
Comment 9 Ivo van Doorn 2007-08-03 14:06:55 EDT
I have send a new mail to Ralink to ask them for legacl clearance for shipping 
the RT61 and RT73 firmware together with FC.
I have CC'ed Nicolas Chauvet, Bill Nottingham and John Linville.

First responce from Ralink seemed rather positive, so hopefully they will 
indeed a nice license to their firmware that allows redistribution.
Comment 10 Nicolas Chauvet (kwizart) 2007-08-16 08:44:52 EDT
Thx for your help Ivo!
I've received the Ralink license by mail, now i think we can re-distribute
Rakink's-firmware.

But from a packager point of view, I usually have to download files from a
public place...(so I can also take care of the timestamp, but this is a minor
problem)...

Actually, what could be better is to download the license from the Ralink website.
Or even better, to have it within the firmware archives...

Thx again from your help!

I will update the spec file (and drop dist tag)
Also, notting reminded me that firmware name is taken from the kernel module
which is used (rt73usb in this case, and rt61pci for rt61-firmware )
I will probably need to rename the spec file name, which was taken from the
archive name (rt71w-firmware) or taken from the chipset suffix rt2571w...



Comment 11 Nicolas Chauvet (kwizart) 2007-09-16 19:26:58 EDT
SRPM:
http://kwizart.free.fr/fedora/6/testing/rt2x00-firmware/rt73usb-firmware-1.8-4.src.rpm
SPEC:
http://kwizart.free.fr/fedora/6/testing/rt2x00-firmware/rt73usb-firmware.spec
Description: Firmware for Ralink® RT2571W/RT2671 A/B/G network adaptors

%changelog
- Disable dist tag
- Preserve timestamp
- Add license from Ralink
- Improved summary and description (taken from iwl4965-firmware scheme )

We can remove FE-Legal as the bundled firmware was provided!
(license is approved by Tom "spot" Callaway in #230161 )
Comment 12 Xavier Lamien 2007-09-21 10:27:07 EDT
Hello,

I'll check & finalize this next week ;)
Comment 13 Xavier Lamien 2007-09-26 09:47:08 EDT
ok,
this package can be approved.
Comment 14 Nicolas Chauvet (kwizart) 2007-09-26 09:54:41 EDT
New Package CVS Request
=======================
Package Name:      rt73usb-firmware
Short Description: Firmware for Ralink® RT2571W/RT2671 A/B/G network adaptors
Owners:            kwizart
Branches:          F-7
InitialCC:         <empty>
Commits by cvsextras: yes

Thx for the review
Comment 15 Kevin Fenzi 2007-09-26 12:42:50 EDT
cvs done.

Note You need to log in before you can comment on or make changes to this bug.