Spec URL: https://mohammedisam.fedorapeople.org/gnudos.spec SRPM URL: https://mohammedisam.fedorapeople.org/gnudos-2.0-1.fc40.src.rpm Description: GnuDOS package is a GNU software. It is a library designed to help new users of the GNU system, who are coming from a DOS background, fit into the picture and start using the GNU system with ease. It also addresses the console programmers of such programs that have the look and feel of old DOS system. The library is composed of core utilities and software applications: * The core library (corelib) contains three components: Kbd (for keyboard handling), Screen (for screen drawing), and Dialogs (for dialog boxes/window drawing). * The software applications are: Prime (console file manager), and Mino (console text editor). Fedora Account System Username: mohammedisam Note for reviewers: GnuDOS was a Fedora package up until f39. Due to different issues I was unable to continue maintaining this package. I wish to resume being a maintainer for this package, and the guidelines for orphaned and retired packages say I need to go through the review process from the beginning. I appreciate if someone can review the package and help me restore it to Fedora. I have completed a Koji build, which you can see here: https://koji.fedoraproject.org/koji/taskinfo?taskID=121247538
A few suggestions: > Group: System Environment/Libraries Not required > License: GPLv3+ Use SPDX short identifier: GPL-3.0-or-later > BuildRequires: make ^ add BR on make > make %{?_smp_mflags} You can use %make_build without %{?_smp_mflags} > make install Same, use %make_install macro > %{_bindir}/* Don't use wildcard, specify what binaries will be packaged. > %{_mandir}/man1/* Change to %{_mandir}/man1/FILE.X*, for example: %{_mandir}/man1/gnudos.1* > %{_libdir}/libgnudos.so.2 > %{_libdir}/libgnudos.so.2.0.0 Create a libs package with these.
Also, you would need the following once the -libs package is defined in the main spec (after the BuildRequies): > Requires: %{name}-libs = %{version}-%{release} You can check https://src.fedoraproject.org/rpms/poke/blob/rawhide/f/poke.spec as example.
(In reply to Mikel Olasagasti Uranga from comment #1) > A few suggestions: > > > Group: System Environment/Libraries > > Not required > > > License: GPLv3+ > > Use SPDX short identifier: GPL-3.0-or-later > > > BuildRequires: make > > ^ add BR on make > > > make %{?_smp_mflags} > > You can use %make_build without %{?_smp_mflags} > > > make install > > Same, use %make_install macro > > > %{_bindir}/* > > Don't use wildcard, specify what binaries will be packaged. > > > %{_mandir}/man1/* > > Change to %{_mandir}/man1/FILE.X*, for example: > > %{_mandir}/man1/gnudos.1* > > > %{_libdir}/libgnudos.so.2 > > %{_libdir}/libgnudos.so.2.0.0 > > Create a libs package with these. Hi Mikel, Thanks for your feedback. I have applied the suggested changes to the spec file. I have completed another Koji build as well: https://koji.fedoraproject.org/koji/taskinfo?taskID=121517541 Thanks
(In reply to Mohammed Isam from comment #3) > (In reply to Mikel Olasagasti Uranga from comment #1) > > A few suggestions: > > > > > Group: System Environment/Libraries > > > > Not required > > > > > License: GPLv3+ > > > > Use SPDX short identifier: GPL-3.0-or-later > > > > > BuildRequires: make > > > > ^ add BR on make > > > > > make %{?_smp_mflags} > > > > You can use %make_build without %{?_smp_mflags} > > > > > make install > > > > Same, use %make_install macro > > > > > %{_bindir}/* > > > > Don't use wildcard, specify what binaries will be packaged. > > > > > %{_mandir}/man1/* > > > > Change to %{_mandir}/man1/FILE.X*, for example: > > > > %{_mandir}/man1/gnudos.1* > > > > > %{_libdir}/libgnudos.so.2 > > > %{_libdir}/libgnudos.so.2.0.0 > > > > Create a libs package with these. > > Hi Mikel, > > Thanks for your feedback. I have applied the suggested changes to the spec > file. > I have completed another Koji build as well: > https://koji.fedoraproject.org/koji/taskinfo?taskID=121517541 > > Thanks Dear reviewers, Could someone please review my package as the ticket has been raised a while back. This is a retired package that I would like to restore and continue to maintain on Fedora. Many thanks! @psabata @sanjay.ankur
Ensure review tool can find files: Spec URL: https://mohammedisam.fedorapeople.org/gnudos.spec SRPM URL: https://mohammedisam.fedorapeople.org/gnudos-2.0-1.fc40.src.rpm
[fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/8547952 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2301667-gnudos/fedora-rawhide-x86_64/08547952-gnudos/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
The build is currently failing. main.c:50:13: error: conflicting types for ‘checkFileExtension’; have ‘void(void)’ 50 | extern void checkFileExtension(); | ^~~~~~~~~~~~~~~~~~ In file included from main.c:41: defs.h:137:6: note: previous declaration of ‘checkFileExtension’ with type ‘void(char *)’ 137 | void checkFileExtension(char *open_file_name); | ^~~~~~~~~~~~~~~~~~ main.c: In function ‘main’: main.c:654:13: error: too many arguments to function ‘checkFileExtension’; expected 0, have 1 654 | checkFileExtension(open_file_name); | ^~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~ main.c:50:13: note: declared here 50 | extern void checkFileExtension(); | ^~~~~~~~~~~~~~~~~~ make[2]: *** [Makefile:548: mino-main.o] Error 1 See also https://koji.fedoraproject.org/koji/taskinfo?taskID=128192333