Red Hat Bugzilla – Bug 230228
Review Request: perl-Crypt-PasswdMD5 - Provides interoperable MD5-based crypt() functions
Last modified: 2015-02-05 09:57:55 EST
Spec: http://mmcgrath.net/~mmcgrath/perl-Crypt-PasswdMD5/perl-Crypt-PasswdMD5.spec SRPM: http://mmcgrath.net/~mmcgrath/perl-Crypt-PasswdMD5/perl-Crypt-PasswdMD5-1.3-1fc7.src.rpm Description: Provides interoperable MD5-based crypt() functions
* source files match upstream (MD5 & SHA1) 368205b1be8c0d4f807afe25d6fbd1ad Crypt-PasswdMD5-1.3.tar.gz 368205b1be8c0d4f807afe25d6fbd1ad Crypt-PasswdMD5-1.3.tar.gz.1 887782eb7fd1568ce9514f46156a08c415c26fdf Crypt-PasswdMD5-1.3.tar.gz 887782eb7fd1568ce9514f46156a08c415c26fdf Crypt-PasswdMD5-1.3.tar.gz.1 * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included in package. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (fc6 i386, fc7 i386). * package installs properly. * rpmlint says (after applying patch below): W: perl-Crypt-PasswdMD5 mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 1) Can be ignored/cleaned up later. * %check present; Test code runs successfully. * no shared libraries are present * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets are OK * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers * no unversioned .so file * no pkconfig file * no libtool .la droppings. I noticed that the README appears to be in ISO-8859-1, but since it's PGP signed it's not possible to change it to UTF-8. So, assuming the following patch is applied, the package is APPROVED. --- perl-Crypt-PasswdMD5.spec.save 2007-02-27 10:41:07.000000000 -0600 +++ perl-Crypt-PasswdMD5.spec 2007-02-27 10:47:55.000000000 -0600 @@ -17,6 +17,8 @@ %prep %setup -q -n Crypt-PasswdMD5-%{version} +%{_bindir}/iconv -f iso-8859-1 -t utf-8 -o PasswdMD5.pm.new PasswdMD5.pm && mv PasswdMD5.pm.new PasswdMD5.pm +%{__sed} -i -e 's/ISO-8859-1/UTF-8/' PasswdMD5.pm %build %{__perl} Makefile.PL INSTALLDIRS=vendor @@ -43,5 +45,5 @@ %{_mandir}/man3/* %changelog -* Tue Feb 27 2007 Mike McGrath <mmcgrath@redhat.com> - 1.3.1 +* Tue Feb 27 2007 Mike McGrath <mmcgrath@redhat.com> - 1.3-1 - Initial Packaging
Ping?
Sorry, I forgot to close this bug. Its been imported and available for a while.
Package Change Request ====================== Package Name: perl-Crypt-PasswdMD5 New Branches: epel7 Owners: pghmcfc InitialCC: perl-sig This package is included in RHEL-7 but not for ppc64, resulting in broken dependencies on that architecture for packages needing it (such as perl-Authen-Simple). The package owner in Fedora, psabata, isn't doing any EPEL-7 packages so I'll take this, clone the RHEL-7 SRPM and prefix the release with "0." as per the EPEL guidelines for limited arch packages.
Git done (by process-git-requests).
Package Change Request ====================== Package Name: perl-Crypt-PasswdMD5 New Branches: el6 Owners: pghmcfc InitialCC: perl-sig This package is included in RHEL-6 but not for ppc64. It is needed for perl-Plack in EPEL-6 (Bug #838679) and has been requested in Bug #783740 since 2012. I'll clone the RHEL-6 SRPM and prefix the release with "0." as per the EPEL guidelines for limited arch packages, and as I already did for EPEL-7.