Spec URL: https://jjames.fedorapeople.org/gap-pkg-normalizinterface/gap-pkg-normalizinterface.spec SRPM URL: https://jjames.fedorapeople.org/gap-pkg-normalizinterface/gap-pkg-normalizinterface-1.3.6-1.fc41.src.rpm Fedora Account System Username: jjames Description: Normaliz is software for computations with rational cones and affine monoids. It pursues two main computational goals: finding the Hilbert basis, a minimal generating system of the monoid of lattice points of a cone; and counting elements degree-wise in a generating function, the Hilbert series. As a recent extension, Normaliz can handle unbounded polyhedra. The Hilbert basis computation can be considered as solving a linear diophantine system of inhomogeneous equations, inequalities and congruences. This package allows creating libnormaliz cone objects from within GAP, and gives access to it in the GAP environment. In this way GAP can be used as interactive interface to libnormaliz. I am willing to swap reviews.
I'll review it
I was confused with mentioned ```libnormaliz``` library but turned out there is one with this name. Apart from that more severe issue exists - noarch doc-subpackage contains files in /usr/lib64 directory which is arch-dependent. Should it be something like ``` %docdir %{gap_noarchdir}/pkg/%{upname}/doc/ %docdir %{gap_boarchdir}/pkg/%{upname}/examples/ ``` Also there are a few ```undefined-non-weak-symbol``` messages from rpmlint. Are these provided by Gap itself or this is a linking error (missing library?). Have you tried this already - does this package work? Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [-]: Development (unversioned) .so files in -devel subpackage but that's ok. It's a snandard practice for so-called plug0in libraries which are supposed to be dlopen-ed by main application. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license (GPLv2+). [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format (%autochangelog). [x]: Sources contain only permissible code or content. [-]: Package does not contain desktop file (not a GUI application). [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package does not contain systemd file(s). [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag except for i386 which is permitted. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 7006 bytes in 2 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: I did not check if the package functions as described. [x]: Latest version is packaged (1.3.6). [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources weren't verified with gpgverify (upstream does not publish signatures). [?]: I did not test if the package compiles and builds into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: gap-pkg-normalizinterface-1.3.6-1.fc41.x86_64.rpm gap-pkg-normalizinterface-doc-1.3.6-1.fc41.noarch.rpm gap-pkg-normalizinterface-debuginfo-1.3.6-1.fc41.x86_64.rpm gap-pkg-normalizinterface-debugsource-1.3.6-1.fc41.x86_64.rpm gap-pkg-normalizinterface-1.3.6-1.fc41.src.rpm ========================================================================================================================================== rpmlint session starts ========================================================================================================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp06843_mm')] checks: 32, packages: 5 gap-pkg-normalizinterface.src: E: spelling-error ('monoids', '%description -l en_US monoids -> mono ids, mono-ids, mongoloids') gap-pkg-normalizinterface.src: E: spelling-error ('monoid', '%description -l en_US monoid -> mono id, mono-id, monoxide') gap-pkg-normalizinterface.src: E: spelling-error ('polyhedra', '%description -l en_US polyhedra -> polyhedral, polyhedron') gap-pkg-normalizinterface.src: E: spelling-error ('diophantine', '%description -l en_US diophantine -> Diophantine, elephantine') gap-pkg-normalizinterface.src: E: spelling-error ('inhomogeneous', '%description -l en_US inhomogeneous -> in homogeneous, in-homogeneous, homogeneous') gap-pkg-normalizinterface.src: E: spelling-error ('congruences', "%description -l en_US congruences -> congruence, congruence's, congruence s") gap-pkg-normalizinterface.src: E: spelling-error ('libnormaliz', '%description -l en_US libnormaliz -> normalization, normalize') gap-pkg-normalizinterface.x86_64: E: spelling-error ('monoids', '%description -l en_US monoids -> mono ids, mono-ids, mongoloids') gap-pkg-normalizinterface.x86_64: E: spelling-error ('monoid', '%description -l en_US monoid -> mono id, mono-id, monoxide') gap-pkg-normalizinterface.x86_64: E: spelling-error ('polyhedra', '%description -l en_US polyhedra -> polyhedral, polyhedron') gap-pkg-normalizinterface.x86_64: E: spelling-error ('diophantine', '%description -l en_US diophantine -> Diophantine, elephantine') gap-pkg-normalizinterface.x86_64: E: spelling-error ('inhomogeneous', '%description -l en_US inhomogeneous -> in homogeneous, in-homogeneous, homogeneous') gap-pkg-normalizinterface.x86_64: E: spelling-error ('congruences', "%description -l en_US congruences -> congruence, congruence's, congruence s") gap-pkg-normalizinterface.x86_64: E: spelling-error ('libnormaliz', '%description -l en_US libnormaliz -> normalization, normalize') gap-pkg-normalizinterface-doc.noarch: W: only-non-binary-in-usr-lib gap-pkg-normalizinterface-doc.noarch: E: noarch-with-lib64 gap-pkg-normalizinterface-doc.noarch: W: no-documentation gap-pkg-normalizinterface-doc.noarch: W: dangling-symlink /usr/lib64/gap/pkg/NormalizInterface/doc/chooser.html /usr/share/gap/pkg/GAPDoc/styles/chooser.html gap-pkg-normalizinterface-doc.noarch: W: dangling-symlink /usr/lib64/gap/pkg/NormalizInterface/doc/lefttoc.css /usr/share/gap/pkg/GAPDoc/styles/lefttoc.css gap-pkg-normalizinterface-doc.noarch: W: dangling-symlink /usr/lib64/gap/pkg/NormalizInterface/doc/manual.css /usr/share/gap/pkg/GAPDoc/styles/manual.css gap-pkg-normalizinterface-doc.noarch: W: dangling-symlink /usr/lib64/gap/pkg/NormalizInterface/doc/manual.js /usr/share/gap/pkg/GAPDoc/styles/manual.js gap-pkg-normalizinterface-doc.noarch: W: dangling-symlink /usr/lib64/gap/pkg/NormalizInterface/doc/nocolorprompt.css /usr/share/gap/pkg/GAPDoc/styles/nocolorprompt.css gap-pkg-normalizinterface-doc.noarch: W: dangling-symlink /usr/lib64/gap/pkg/NormalizInterface/doc/ragged.css /usr/share/gap/pkg/GAPDoc/styles/ragged.css gap-pkg-normalizinterface-doc.noarch: W: dangling-symlink /usr/lib64/gap/pkg/NormalizInterface/doc/rainbow.js /usr/share/gap/pkg/GAPDoc/styles/rainbow.js gap-pkg-normalizinterface-doc.noarch: W: dangling-symlink /usr/lib64/gap/pkg/NormalizInterface/doc/times.css /usr/share/gap/pkg/GAPDoc/styles/times.css gap-pkg-normalizinterface-doc.noarch: W: dangling-symlink /usr/lib64/gap/pkg/NormalizInterface/doc/toggless.css /usr/share/gap/pkg/GAPDoc/styles/toggless.css gap-pkg-normalizinterface-doc.noarch: W: dangling-symlink /usr/lib64/gap/pkg/NormalizInterface/doc/toggless.js /usr/share/gap/pkg/GAPDoc/styles/toggless.js =================================================================================================== 5 packages and 0 specfiles checked; 15 errors, 12 warnings, 31 filtered, 15 badness; has taken 2.9 s =================================================================================================== Rpmlint (debuginfo) ------------------- Checking: gap-pkg-normalizinterface-debuginfo-1.3.6-1.fc41.x86_64.rpm ========================================================================================================================================== rpmlint session starts ========================================================================================================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpbav24gkp')] checks: 32, packages: 1 ===================================================================================================== 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.4 s ===================================================================================================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4 gap-pkg-normalizinterface.x86_64: W: undefined-non-weak-symbol /usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so AssRecFuncs (/usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so) gap-pkg-normalizinterface.x86_64: W: undefined-non-weak-symbol /usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so CopyObjFuncs (/usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so) gap-pkg-normalizinterface.x86_64: W: undefined-non-weak-symbol /usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so IsMutableObjFuncs (/usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so) gap-pkg-normalizinterface.x86_64: W: undefined-non-weak-symbol /usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so Fail (/usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so) gap-pkg-normalizinterface.x86_64: W: undefined-non-weak-symbol /usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so True (/usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so) gap-pkg-normalizinterface.x86_64: W: undefined-non-weak-symbol /usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so IsDenseListFuncs (/usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so) gap-pkg-normalizinterface.x86_64: W: undefined-non-weak-symbol /usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so QuoFuncs (/usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so) gap-pkg-normalizinterface.x86_64: W: undefined-non-weak-symbol /usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so CleanObjFuncs (/usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so) gap-pkg-normalizinterface.x86_64: W: undefined-non-weak-symbol /usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so MarkAllSubBags (/usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so) gap-pkg-normalizinterface.x86_64: W: undefined-non-weak-symbol /usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so AssListFuncs (/usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so) gap-pkg-normalizinterface.x86_64: W: undefined-non-weak-symbol /usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so False (/usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so) gap-pkg-normalizinterface.x86_64: W: undefined-non-weak-symbol /usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so InitGVarFuncsFromTable (/usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so) gap-pkg-normalizinterface.x86_64: W: undefined-non-weak-symbol /usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so AddList (/usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so) gap-pkg-normalizinterface.x86_64: W: undefined-non-weak-symbol /usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so ErrorQuit (/usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so) gap-pkg-normalizinterface.x86_64: W: undefined-non-weak-symbol /usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so ObjInt_UInt (/usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so) gap-pkg-normalizinterface.x86_64: W: undefined-non-weak-symbol /usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so InitMarkFuncBags (/usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so) gap-pkg-normalizinterface.x86_64: W: undefined-non-weak-symbol /usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so RNamName (/usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so) gap-pkg-normalizinterface.x86_64: W: undefined-non-weak-symbol /usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so InitFreeFuncBag (/usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so) gap-pkg-normalizinterface.x86_64: W: undefined-non-weak-symbol /usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so AssPRec (/usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so) gap-pkg-normalizinterface.x86_64: W: undefined-non-weak-symbol /usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so ObjInt_UInt8 (/usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so) gap-pkg-normalizinterface.x86_64: W: undefined-non-weak-symbol /usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so MakeObjInt (/usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so) gap-pkg-normalizinterface.x86_64: W: undefined-non-weak-symbol /usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so UInt8_ObjInt (/usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so) gap-pkg-normalizinterface.x86_64: W: undefined-non-weak-symbol /usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so NEW_STRING (/usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so) gap-pkg-normalizinterface.x86_64: W: undefined-non-weak-symbol /usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so InitHdlrFuncsFromTable (/usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so) gap-pkg-normalizinterface.x86_64: W: undefined-non-weak-symbol /usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so ErrorMayQuit (/usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so) gap-pkg-normalizinterface.x86_64: W: undefined-non-weak-symbol /usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so RegisterPackageTNUM (/usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so) gap-pkg-normalizinterface.x86_64: W: undefined-non-weak-symbol /usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so ObjInt_Int (/usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so) gap-pkg-normalizinterface.x86_64: W: undefined-non-weak-symbol /usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so InitCopyGVar (/usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so) gap-pkg-normalizinterface.x86_64: W: undefined-non-weak-symbol /usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so SORT_LIST (/usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so) gap-pkg-normalizinterface.x86_64: W: undefined-non-weak-symbol /usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so RetypeBagIntern (/usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so) gap-pkg-normalizinterface.x86_64: W: undefined-non-weak-symbol /usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so NEW_PREC (/usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so) gap-pkg-normalizinterface.x86_64: W: undefined-non-weak-symbol /usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so NEW_MACFLOAT (/usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so) gap-pkg-normalizinterface.x86_64: W: undefined-non-weak-symbol /usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so NewBag (/usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so) gap-pkg-normalizinterface.x86_64: E: spelling-error ('monoids', '%description -l en_US monoids -> mono ids, mono-ids, mongoloids') gap-pkg-normalizinterface.x86_64: E: spelling-error ('monoid', '%description -l en_US monoid -> mono id, mono-id, monoxide') gap-pkg-normalizinterface.x86_64: E: spelling-error ('polyhedra', '%description -l en_US polyhedra -> polyhedral, polyhedron') gap-pkg-normalizinterface.x86_64: E: spelling-error ('diophantine', '%description -l en_US diophantine -> Diophantine, elephantine') gap-pkg-normalizinterface.x86_64: E: spelling-error ('inhomogeneous', '%description -l en_US inhomogeneous -> in homogeneous, in-homogeneous, homogeneous') gap-pkg-normalizinterface.x86_64: E: spelling-error ('congruences', "%description -l en_US congruences -> congruence, congruence's, congruence s") gap-pkg-normalizinterface.x86_64: E: spelling-error ('libnormaliz', '%description -l en_US libnormaliz -> normalization, normalize') gap-pkg-normalizinterface-doc.noarch: W: only-non-binary-in-usr-lib gap-pkg-normalizinterface-doc.noarch: E: noarch-with-lib64 gap-pkg-normalizinterface-doc.noarch: W: no-documentation gap-pkg-normalizinterface-doc.noarch: W: dangling-symlink /usr/lib64/gap/pkg/NormalizInterface/doc/chooser.html /usr/share/gap/pkg/GAPDoc/styles/chooser.html gap-pkg-normalizinterface-doc.noarch: W: dangling-symlink /usr/lib64/gap/pkg/NormalizInterface/doc/lefttoc.css /usr/share/gap/pkg/GAPDoc/styles/lefttoc.css gap-pkg-normalizinterface-doc.noarch: W: dangling-symlink /usr/lib64/gap/pkg/NormalizInterface/doc/manual.css /usr/share/gap/pkg/GAPDoc/styles/manual.css gap-pkg-normalizinterface-doc.noarch: W: dangling-symlink /usr/lib64/gap/pkg/NormalizInterface/doc/manual.js /usr/share/gap/pkg/GAPDoc/styles/manual.js gap-pkg-normalizinterface-doc.noarch: W: dangling-symlink /usr/lib64/gap/pkg/NormalizInterface/doc/nocolorprompt.css /usr/share/gap/pkg/GAPDoc/styles/nocolorprompt.css gap-pkg-normalizinterface-doc.noarch: W: dangling-symlink /usr/lib64/gap/pkg/NormalizInterface/doc/ragged.css /usr/share/gap/pkg/GAPDoc/styles/ragged.css gap-pkg-normalizinterface-doc.noarch: W: dangling-symlink /usr/lib64/gap/pkg/NormalizInterface/doc/rainbow.js /usr/share/gap/pkg/GAPDoc/styles/rainbow.js gap-pkg-normalizinterface-doc.noarch: W: dangling-symlink /usr/lib64/gap/pkg/NormalizInterface/doc/times.css /usr/share/gap/pkg/GAPDoc/styles/times.css gap-pkg-normalizinterface-doc.noarch: W: dangling-symlink /usr/lib64/gap/pkg/NormalizInterface/doc/toggless.css /usr/share/gap/pkg/GAPDoc/styles/toggless.css gap-pkg-normalizinterface-doc.noarch: W: dangling-symlink /usr/lib64/gap/pkg/NormalizInterface/doc/toggless.js /usr/share/gap/pkg/GAPDoc/styles/toggless.js 4 packages and 0 specfiles checked; 8 errors, 45 warnings, 28 filtered, 8 badness; has taken 1.9 s Unversioned so-files -------------------- gap-pkg-normalizinterface: /usr/lib64/gap/pkg/NormalizInterface/bin/x86_64-redhat-linux-gnu-default64-kv9/NormalizInterface.so Source checksums ---------------- https://github.com/gap-packages/NormalizInterface/releases/download/v1.3.6/NormalizInterface-1.3.6.tar.bz2 : CHECKSUM(SHA256) this package : 7c58aa6eefc5dda0a5caafe82f24f6177d10507385974a79e619951aa7effd4c CHECKSUM(SHA256) upstream package : 7c58aa6eefc5dda0a5caafe82f24f6177d10507385974a79e619951aa7effd4c Requires -------- gap-pkg-normalizinterface (rpmlib, GLIBC filtered): /usr/bin/sh gap-core(x86-64) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgmp.so.10()(64bit) libnormaliz.so.3()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) gap-pkg-normalizinterface-doc (rpmlib, GLIBC filtered): gap-pkg-normalizinterface gap-pkg-normalizinterface-debuginfo (rpmlib, GLIBC filtered): gap-pkg-normalizinterface-debugsource (rpmlib, GLIBC filtered): Provides -------- gap-pkg-normalizinterface: gap-pkg-normalizinterface gap-pkg-normalizinterface(x86-64) gap-pkg-normalizinterface-doc: gap-pkg-normalizinterface-doc gap-pkg-normalizinterface-debuginfo: debuginfo(build-id) gap-pkg-normalizinterface-debuginfo gap-pkg-normalizinterface-debuginfo(x86-64) gap-pkg-normalizinterface-debugsource: gap-pkg-normalizinterface-debugsource gap-pkg-normalizinterface-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2303281 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Haskell, Perl, C/C++, R, Ocaml, Python, PHP, fonts, Java, SugarActivity Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
(In reply to Peter Lemenkov from comment #2) > I was confused with mentioned ```libnormaliz``` library but turned out there > is one with this name. Apart from that more severe issue exists - noarch > doc-subpackage contains files in /usr/lib64 directory which is > arch-dependent. Should it be something like > > ``` > %docdir %{gap_noarchdir}/pkg/%{upname}/doc/ > %docdir %{gap_boarchdir}/pkg/%{upname}/examples/ > ``` Yes, I'm kind of cheating here. The entire GAP ecosystem is built for 64-bit architectures only. Those files do go into /usr/lib64 for every architecture for which they are built. I understand that is kind of dodgy. Given the way the main gap package works, though, the documentation files have to be installed in the same place as the rest of the package, so they cannot go into %{gap_libdir}. The choice is either to do it this way (which "works" because of the 64-bit-only nature of the packages) or make the doc subpackage be arch-specific. I can do the latter if you object to the current approach. > Also there are a few ```undefined-non-weak-symbol``` messages from rpmlint. > Are these provided by Gap itself or this is a linking error (missing > library?). Have you tried this already - does this package work? Think of this package as a plugin. The undefined symbols are provided by /usr/bin/gap, which loads this shared object. Yes, it does work. You can see it working when the test suite is executed.
(In reply to Jerry James from comment #3) > (In reply to Peter Lemenkov from comment #2) > > I was confused with mentioned ```libnormaliz``` library but turned out there > > is one with this name. Apart from that more severe issue exists - noarch > > doc-subpackage contains files in /usr/lib64 directory which is > > arch-dependent. Should it be something like > > > > ``` > > %docdir %{gap_noarchdir}/pkg/%{upname}/doc/ > > %docdir %{gap_boarchdir}/pkg/%{upname}/examples/ > > ``` > > Yes, I'm kind of cheating here. The entire GAP ecosystem is built for > 64-bit architectures only. Those files do go into /usr/lib64 for every > architecture for which they are built. I understand that is kind of dodgy. > Given the way the main gap package works, though, the documentation files > have to be installed in the same place as the rest of the package, so they > cannot go into %{gap_libdir}. The choice is either to do it this way (which > "works" because of the 64-bit-only nature of the packages) or make the doc > subpackage be arch-specific. I can do the latter if you object to the > current approach. Ok got that. That's unfortunate but we have to live with it for a while. In the mean time please take a closer look - maybe there is something which can be done to fix/overcome it. > > Also there are a few ```undefined-non-weak-symbol``` messages from rpmlint. > > Are these provided by Gap itself or this is a linking error (missing > > library?). Have you tried this already - does this package work? > > Think of this package as a plugin. The undefined symbols are provided by > /usr/bin/gap, which loads this shared object. Yes, it does work. You can > see it working when the test suite is executed. Ah ok got it. These were my biggest concerns which were explained to me. I don't see any other issues so this package is ================ === APPROVED === ================
(In reply to Peter Lemenkov from comment #4) > Ok got that. That's unfortunate but we have to live with it for a while. In > the mean time please take a closer look - maybe there is something which can > be done to fix/overcome it. Upstream tells me that they are working on allowing GAP packages to be split into architecture-specific and noarch parts. That way, we could install only the architecture-specific bits in %{_libdir} and everything else in %{_datadir}. I don't know what kind of timeframe they are looking at, but it's in the pipeline somewhere. > These were my biggest concerns which were explained to me. I don't see any > other issues so this package is > > ================ > === APPROVED === > ================ Thank you very much for the review. I appreciate it.
The Pagure repository was created at https://src.fedoraproject.org/rpms/gap-pkg-normalizinterface
FEDORA-2024-1f9a35bdf8 (gap-pkg-normalizinterface-1.3.6-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-1f9a35bdf8
FEDORA-2024-1f9a35bdf8 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-1f9a35bdf8 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-1f9a35bdf8 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-1f9a35bdf8 (gap-pkg-normalizinterface-1.3.6-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.