Spec URL: https://jjames.fedorapeople.org/gap-pkg-lins/gap-pkg-lins.spec SRPM URL: https://jjames.fedorapeople.org/gap-pkg-lins/gap-pkg-lins-0.9-1.fc41.src.rpm Fedora Account System Username: jjames Description: This package provides an algorithm for computing the normal subgroups of a finitely presented group up to some given index bound. This algorithm is based on work of Derek Holt and David Firth. Derek Holt and David Firth implemented this algorithm in the algebra software MAGMA. The current implementation in GAP uses a table of groups that was computed by the code in `createTables.gi`. I am willing to swap reviews.
I'll review it.
LGTM. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license (GPLv2+). [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format (%autochangelog). [x]: Sources contain only permissible code or content. [-]: Package does not contain desktop file (not a GUI application). [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package does not contain systemd file(s). [x]: Package is not known to require an ExcludeArch tag (except i386 which is ok). [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 2074 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: I did not check if the package functions as described. [x]: Latest version is packaged (0.9). [x]: Package does not include license text files separate from upstream. [-]: Sources weren't verified with gpgverify (upstream does not publish signatures). [?]: I did not test if the package compiles and builds into binary rpms on all supported architectures. Noarch library anyway. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: gap-pkg-lins-0.9-1.fc41.noarch.rpm gap-pkg-lins-doc-0.9-1.fc41.noarch.rpm gap-pkg-lins-0.9-1.fc41.src.rpm ========================================================================================================================================== rpmlint session starts ========================================================================================================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp0xddy9ss')] checks: 32, packages: 3 gap-pkg-lins.noarch: E: spelling-error ('createTables', '%description -l en_US createTables -> create Tables, create-tables, respectable') gap-pkg-lins.noarch: E: spelling-error ('gi', '%description -l en_US gi -> GI, guy, gee') gap-pkg-lins.src: E: spelling-error ('createTables', '%description -l en_US createTables -> create Tables, create-tables, respectable') gap-pkg-lins.src: E: spelling-error ('gi', '%description -l en_US gi -> GI, guy, gee') gap-pkg-lins-doc.noarch: W: no-documentation gap-pkg-lins-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/LINS/doc/chooser.html ../../GAPDoc/styles/chooser.html gap-pkg-lins-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/LINS/doc/lefttoc.css ../../GAPDoc/styles/lefttoc.css gap-pkg-lins-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/LINS/doc/manual.css ../../GAPDoc/styles/manual.css gap-pkg-lins-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/LINS/doc/manual.js ../../GAPDoc/styles/manual.js gap-pkg-lins-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/LINS/doc/nocolorprompt.css ../../GAPDoc/styles/nocolorprompt.css gap-pkg-lins-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/LINS/doc/ragged.css ../../GAPDoc/styles/ragged.css gap-pkg-lins-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/LINS/doc/rainbow.js ../../GAPDoc/styles/rainbow.js gap-pkg-lins-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/LINS/doc/times.css ../../GAPDoc/styles/times.css gap-pkg-lins-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/LINS/doc/toggless.css ../../GAPDoc/styles/toggless.css gap-pkg-lins-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/LINS/doc/toggless.js ../../GAPDoc/styles/toggless.js ==================================================================================================== 3 packages and 0 specfiles checked; 4 errors, 11 warnings, 12 filtered, 4 badness; has taken 1.2 s ==================================================================================================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 gap-pkg-lins.noarch: E: spelling-error ('createTables', '%description -l en_US createTables -> create Tables, create-tables, respectable') gap-pkg-lins.noarch: E: spelling-error ('gi', '%description -l en_US gi -> GI, guy, gee') gap-pkg-lins-doc.noarch: W: no-documentation gap-pkg-lins-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/LINS/doc/chooser.html ../../GAPDoc/styles/chooser.html gap-pkg-lins-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/LINS/doc/lefttoc.css ../../GAPDoc/styles/lefttoc.css gap-pkg-lins-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/LINS/doc/manual.css ../../GAPDoc/styles/manual.css gap-pkg-lins-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/LINS/doc/manual.js ../../GAPDoc/styles/manual.js gap-pkg-lins-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/LINS/doc/nocolorprompt.css ../../GAPDoc/styles/nocolorprompt.css gap-pkg-lins-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/LINS/doc/ragged.css ../../GAPDoc/styles/ragged.css gap-pkg-lins-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/LINS/doc/rainbow.js ../../GAPDoc/styles/rainbow.js gap-pkg-lins-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/LINS/doc/times.css ../../GAPDoc/styles/times.css gap-pkg-lins-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/LINS/doc/toggless.css ../../GAPDoc/styles/toggless.css gap-pkg-lins-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/LINS/doc/toggless.js ../../GAPDoc/styles/toggless.js 2 packages and 0 specfiles checked; 2 errors, 11 warnings, 8 filtered, 2 badness; has taken 0.6 s Source checksums ---------------- https://github.com/gap-packages/LINS/archive/v0.9/LINS-0.9.tar.gz : CHECKSUM(SHA256) this package : 59aedfafa3d08f778f731982440537755e80fb77ae1212c47761b595096f1f43 CHECKSUM(SHA256) upstream package : 59aedfafa3d08f778f731982440537755e80fb77ae1212c47761b595096f1f43 Requires -------- gap-pkg-lins (rpmlib, GLIBC filtered): gap-core gap-pkg-lins-doc (rpmlib, GLIBC filtered): gap-pkg-lins gap-pkg-polycyclic-doc Provides -------- gap-pkg-lins: gap-pkg-lins gap-pkg-lins-doc: gap-pkg-lins-doc Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2303283 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Java, PHP, R, Ocaml, C/C++, Perl, SugarActivity, Python, Haskell, fonts Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH This package is ================ === APPROVED === ================
Thank you for the review!
The Pagure repository was created at https://src.fedoraproject.org/rpms/gap-pkg-lins
FEDORA-2024-d5bc2b7617 (gap-pkg-lins-0.9-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-d5bc2b7617
FEDORA-2024-d5bc2b7617 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-d5bc2b7617 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-d5bc2b7617 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-d5bc2b7617 (gap-pkg-lins-0.9-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.