Bug 2303453 - Review Request: thin-merge - Merge external snapshot's origin into thin volume
Summary: Review Request: thin-merge - Merge external snapshot's origin into thin volume
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Bryan Gurney
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-DEADREVIEW
TreeView+ depends on / blocked
 
Reported: 2024-08-07 12:54 UTC by Marian Csontos
Modified: 2025-11-25 00:45 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-11-25 00:45:20 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Marian Csontos 2024-08-07 12:54:15 UTC
Spec URL: https://gitlab.com/csonto/rpms-thin-merge
SRPM URL: https://mcsontos.fedorapeople.org/thin-merge/
Fedora Account System Username: mcsontos
Description: Merge external snapshot's origin into thin volume
thin_merge merges the data mappings of a dm-thin external snapshot with its
origin, turning the external snapshot into a regular dm-thin device. This
functionality is essential for live block copying from the external origin.

Naming does not follow rust package name guidelines, this is a standalone tool, which happens to be written in rust, and is not to be used as library.

TODO: Some rust crates are not packaged in Fedora so I will need to review them and get them packaged too

Comment 1 Marian Csontos 2024-08-07 12:57:40 UTC
rpmlint output: 

thin-merge.src: E: spelling-error ('dm', '%description -l en_US dm -> d, m, dim') - perhaps device mapper could be spelled out loud...
thin-merge.spec: W: invalid-url Source1: thin-merge-0.1.0-vendor.tar.gz

scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=121605303

Comment 2 Package Review 2025-10-25 00:45:23 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 3 Fedora Review Service 2025-11-20 14:48:24 UTC
Hello,
I do realize that this is possibly an old ticket. I am sorry that it hasn't been
reviewed yet. Let me trigger the Fedora Review Service to see if the package
builds successfully. Hopefully, a green check mark will attract some reviewer.

If I am resurrecting an old ticket that you are not interested in anymore, my
apologies, feel free to close it.

[fedora-review-service-build]

Comment 4 Fedora Review Service 2025-11-20 14:48:45 UTC
Cannot find any valid SRPM URL for this ticket. Common causes are:

- You didn't specify `SRPM URL: ...` in the ticket description
  or any of your comments
- The URL schema isn't HTTP or HTTPS
- The SRPM package linked in your URL doesn't match the package name specified
  in the ticket summary


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Package Review 2025-11-25 00:45:20 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.


Note You need to log in before you can comment on or make changes to this bug.