Bug 2303886 - Please branch and build doctest in epel10
Summary: Please branch and build doctest in epel10
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora EPEL
Classification: Fedora
Component: doctest
Version: epel10
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nick Black
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: EPEL10Tracker 2303877
TreeView+ depends on / blocked
 
Reported: 2024-08-09 19:17 UTC by Davide Cavalca
Modified: 2024-08-23 17:03 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-08-23 17:03:39 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Davide Cavalca 2024-08-09 19:17:58 UTC
Please branch and build doctest in epel10.

If you do not wish to maintain doctest in epel10,
or do not think you will be able to do this in a timely manner,
the EPEL Packagers SIG would be happy to be a co-maintainer of the package;
please add the epel-packagers-sig group through
https://src.fedoraproject.org/rpms/doctest/addgroup
and grant it commit access, or collaborator access on epel* branches.

Comment 1 Nick Black 2024-08-10 17:30:14 UTC
https://koji.fedoraproject.org/koji/taskinfo?taskID=121759784 has been kicked off

Comment 2 Nick Black 2024-08-10 17:33:15 UTC
the build failed with this error:

roject.org)
121759784 build (epel10-candidate, /rpms/doctest.git:ff546381de386d00f732bf26fab83ce4f59e4091): open (buildhw-x86-14.iad2.fedoraproject.org) -> FAILED: BuildError: package doctest not in list for tag epel10.0-testing-candidate
  0 free  1 open  0 done  1 failed
  121759799 buildSRPMFromSCM (/rpms/doctest.git:ff546381de386d00f732bf26fab83ce4f59e4091): open (buildvm-x86-25.iad2.fedoraproject.org) -> closed
  0 free  0 open  1 done  1 failed

what do i need to do to resolve this? i'm building from a branch named "epel10".

Comment 3 Carl George 🤠 2024-08-12 17:02:04 UTC
Did you request the epel10 branch by running `fedpkg request-branch epel10`?  I don't see an issue filed for the epel10 branch in the scm requests repo.

https://pagure.io/releng/fedora-scm-requests/issues?status=all&search_pattern=rpms%2Fdoctest&close_status=

Requesting the branch properly sets off a chain of events that adds the package to the tag allowlist, usually fast enough that it is in place before the packager attempts a build.  If you just pushed to the branch to create it I suspect it would lead to this outcome.

You should be able to rectify this by running `fedpkg request-branch --no-git-branch epel10`, and in the future making sure to not push to branches without running `fedpkg request-branch epel10` first.

Comment 4 Nick Black 2024-08-13 09:20:08 UTC
i did not; i forgot how to do this properly. thanks!

https://pagure.io/releng/fedora-scm-requests/issue/64448

Comment 5 Nick Black 2024-08-13 09:32:06 UTC
erp, that was for libdeflate, not doctest (the subject of this bug).

i removed my local branch "epel10", but attempting to remove the remote branch fails:

[dank@localhost doctest]$ git push -d origin epel10
remote: Branch deletion is not allowed
remote: Denied push for ref 'refs/heads/epel10' for user 'nickblack'
remote: All changes have been rejected
[dank@localhost doctest]$

and using --no-git-branch doesn't seem to work:

[dank@localhost doctest]$ fedpkg request-branch --no-git-branch epel10
Requested branch "epel10" already exists. Skipping the operation.
[dank@localhost doctest]$ 

any suggestions? sorry about this =\.

Comment 6 Carl George 🤠 2024-08-13 21:57:26 UTC
I think it should be fine now actually.  Besides the fedmsg based action that add the package to the tag allowlist, there is also a cleanup cron job that tries to rectify situations like this, and our changes there seem to have worked as intended.


carl ~ 
❯ koji list-tag-inheritance epel10.0-testing-candidate
     epel10.0-testing-candidate (93225)
....  └─epel10.0 (93217)

carl ~ 
❯ koji list-pkgs --package doctest --tag epel10.0-testing-candidate
Package                 Tag                     Extra Arches     Owner          
----------------------- ----------------------- ---------------- ---------------
doctest                 epel10.0                                 nickblack


If you try the build again, it should work now.

Comment 7 Nick Black 2024-08-15 05:40:50 UTC
thanks! build is launched. waiting on ppc64le; everything else has succeeded.


https://koji.fedoraproject.org/koji/taskinfo?taskID=121972634

Comment 8 Nick Black 2024-08-15 06:11:20 UTC
...and we are all good!

Comment 9 Davide Cavalca 2024-08-23 17:03:39 UTC
Thanks!


Note You need to log in before you can comment on or make changes to this bug.