Bug 2303917 - Re-Review Request: erlang-riak_core - Distributed systems infrastructure used by Riak
Summary: Re-Review Request: erlang-riak_core - Distributed systems infrastructure used...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Benson Muite
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/basho/%{realname}
Whiteboard:
Depends On:
Blocks: 2261081 2300645
TreeView+ depends on / blocked
 
Reported: 2024-08-09 23:17 UTC by Peter Lemenkov
Modified: 2024-11-15 20:28 UTC (History)
2 users (show)

Fixed In Version: erlang-riak_core-3.0.16-1.fc42
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-11-15 20:28:00 UTC
Type: ---
Embargoed:
benson_muite: fedora-review+


Attachments (Terms of Use)

Description Peter Lemenkov 2024-08-09 23:17:36 UTC
Spec URL: https://peter.fedorapeople.org/packages/re-review/erlang-riak_core.spec
SRPM URL: https://peter.fedorapeople.org/packages/re-review/erlang-riak_core-3.0.16-1.fc40.src.rpm
Description: Distributed systems infrastructure used by Riak
Fedora Account System Username: peter

Koji scratch build for Rawhide:

* https://koji.fedoraproject.org/koji/taskinfo?taskID=121718965

This is a re-review since the package was orphaned for a while.

Comment 1 Benson Muite 2024-11-05 17:34:00 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package does not use a name that already exists.
  Note: A package with this name already exists. Please check
  https://src.fedoraproject.org/rpms/erlang-riak_core
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/Naming/#_conflicting_package_names


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "*No copyright* Apache License 2.0", "Unknown or generated",
     "Apache License 2.0", "*No copyright* Erlang Public License v1.1",
     "MIT License", "Erlang Public License v1.1", "Mozilla Public License
     1.1". 47 files have unknown license. Detailed output of licensecheck
     in /home/FedoraPackaging/reviews/erlang-riak_core/2303917-erlang-
     riak_core/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 196437 bytes in 11 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[ ]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).
     See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.


Rpmlint
-------
Checking: erlang-riak_core-3.0.16-1.fc42.noarch.rpm
          erlang-riak_core-3.0.16-1.fc42.src.rpm
======================================= rpmlint session starts ======================================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpl8h7tekk')]
checks: 32, packages: 2

erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/app_helper.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/app_helper.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/bloom.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/bloom.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/chash.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/chash.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/chashbin.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/chashbin.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/dvvset.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/dvvset.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/gen_nb_server.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/gen_nb_server.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/hashtree.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/hashtree.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/hashtree_tree.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/hashtree_tree.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/mock_vnode.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/mock_vnode.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/pbkdf2.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/pbkdf2.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/process_proxy.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/process_proxy.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_apl.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_apl.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_app.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_app.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_bg_manager.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_bg_manager.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_broadcast.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_broadcast.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_broadcast_handler.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_broadcast_handler.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_bucket.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_bucket.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_bucket_props.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_bucket_props.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_bucket_type.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_bucket_type.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_capability.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_capability.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_cinfo_core.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_cinfo_core.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_claim_binring_alg.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_claim_binring_alg.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_claim_sim.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_claim_sim.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_claim_swapping.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_claim_swapping.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_claim_util.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_claim_util.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_claimant.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_claimant.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_cli_registry.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_cli_registry.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_cluster_cli.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_cluster_cli.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_console.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_console.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_console_table.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_console_table.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_coverage_fsm.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_coverage_fsm.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_coverage_plan.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_coverage_plan.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_dist_mon.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_dist_mon.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_dtrace.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_dtrace.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_eventhandler_guard.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_eventhandler_guard.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_eventhandler_sup.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_eventhandler_sup.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_format.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_format.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_gen_server.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_gen_server.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_gossip.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_gossip.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_handoff_cli.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_handoff_cli.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_handoff_listener.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_handoff_listener.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_handoff_listener_sup.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_handoff_listener_sup.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_handoff_manager.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_handoff_manager.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_handoff_receiver.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_handoff_receiver.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_handoff_receiver_sup.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_handoff_receiver_sup.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_handoff_sender.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_handoff_sender.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_handoff_sender_sup.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_handoff_sender_sup.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_handoff_status.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_handoff_status.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_handoff_sup.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_handoff_sup.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_location.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_location.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_membership_claim.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_membership_claim.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_membership_leave.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_membership_leave.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_metadata.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_metadata.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_metadata_exchange_fsm.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_metadata_exchange_fsm.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_metadata_hashtree.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_metadata_hashtree.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_metadata_manager.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_metadata_manager.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_metadata_object.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_metadata_object.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_net_ticktime.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_net_ticktime.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_node_watcher.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_node_watcher.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_node_watcher_events.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_node_watcher_events.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_node_worker_pool.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_node_worker_pool.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_node_worker_pool_sup.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_node_worker_pool_sup.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_nodeid.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_nodeid.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_priority_queue.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_priority_queue.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_pw_auth.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_pw_auth.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_repair.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_repair.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_ring.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_ring.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_ring_events.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_ring_events.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_ring_handler.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_ring_handler.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_ring_manager.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_ring_manager.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_ring_util.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_ring_util.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_security.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_security.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_send_msg.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_send_msg.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_ssl_util.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_ssl_util.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_stat.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_stat.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_stat_cache.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_stat_cache.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_stat_calc_proc.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_stat_calc_proc.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_stat_calc_sup.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_stat_calc_sup.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_stat_q.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_stat_q.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_stat_sup.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_stat_sup.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_stat_xform.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_stat_xform.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_stats_sup.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_stats_sup.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_status.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_status.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_sup.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_sup.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_sysmon_handler.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_sysmon_handler.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_sysmon_minder.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_sysmon_minder.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_table_owner.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_table_owner.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_tcp_mon.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_tcp_mon.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_test_util.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_test_util.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_throttle.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_throttle.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_tracer.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_tracer.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_util.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_util.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_vnode.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_vnode.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_vnode_manager.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_vnode_manager.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_vnode_master.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_vnode_master.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_vnode_proxy.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_vnode_proxy.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_vnode_proxy_sup.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_vnode_proxy_sup.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_vnode_sup.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_vnode_sup.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_vnode_worker.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_vnode_worker.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_vnode_worker_pool.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_vnode_worker_pool.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_worker_pool.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_worker_pool.erl
erlang-riak_core.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_core-3.0.16/ebin/vclock.beam /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/vclock.erl
= 2 packages and 0 specfiles checked; 0 errors, 103 warnings, 7 filtered, 0 badness; has taken 4.6 s 




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 3 filtered, 0 badness; has taken 2.7 s 



Source checksums
----------------
https://github.com/basho/riak_core/archive/riak_kv-3.0.16/riak_core-3.0.16.tar.gz :
  CHECKSUM(SHA256) this package     : 4dbfdecaf42995bc2b2ab628b429e6cebe042cf28fb28134c0243e38f4ff83b5
  CHECKSUM(SHA256) upstream package : 4dbfdecaf42995bc2b2ab628b429e6cebe042cf28fb28134c0243e38f4ff83b5


Requires
--------
erlang-riak_core (rpmlib, GLIBC filtered):
    erlang-basho_stats
    erlang-clique
    erlang-cluster_info
    erlang-crypto(x86-64)
    erlang-cuttlefish
    erlang-eleveldb(x86-64)
    erlang-erts(x86-64)
    erlang-exometer_core
    erlang-folsom
    erlang-inets(x86-64)
    erlang-kernel(x86-64)
    erlang-lager
    erlang-mochiweb
    erlang-poolboy
    erlang-public_key(x86-64)
    erlang-riak_ensemble(x86-64)
    erlang-riak_sysmon
    erlang-runtime_tools(x86-64)
    erlang-ssl(x86-64)
    erlang-stdlib(x86-64)



Provides
--------
erlang-riak_core:
    erlang-riak_core



Diff spec file in url and in SRPM
---------------------------------
--- /home/benson/Projects/FedoraPackaging/reviews/erlang-riak_core/2303917-erlang-riak_core/srpm/erlang-riak_core.spec       2024-11-05 18:51:27.794871723 +0300
+++ /home/benson/Projects/FedoraPackaging/reviews/erlang-riak_core/2303917-erlang-riak_core/srpm-unpacked/erlang-riak_core.spec      2024-08-09 03:00:00.000000000 +0300
@@ -1,2 +1,12 @@
+## START: Set by rpmautospec
+## (rpmautospec version 0.6.5)
+## RPMAUTOSPEC: autorelease, autochangelog
+%define autorelease(e:s:pb:n) %{?-p:0.}%{lua:
+    release_number = 1;
+    base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}"));
+    print(release_number + base_release_number - 1);
+}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}}
+## END: Set by rpmautospec
+
 %global realname riak_core
 
@@ -78,3 +88,121 @@
 
 %changelog
-%autochangelog
+## START: Generated by rpmautospec
+* Fri Aug 09 2024 Peter Lemenkov <lemenkov> - 3.0.16-1
+- Uncommitted changes
+
+* Wed Jul 21 2021 Fedora Release Engineering <releng> - 2.1.10-14
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_35_Mass_Rebuild
+
+* Tue Jan 26 2021 Fedora Release Engineering <releng> - 2.1.10-13
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_34_Mass_Rebuild
+
+* Mon Jul 27 2020 Fedora Release Engineering <releng> - 2.1.10-12
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild
+
+* Tue Jan 28 2020 Fedora Release Engineering <releng> - 2.1.10-11
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_32_Mass_Rebuild
+
+* Tue Nov 12 2019 Peter Lemenkov <lemenkov> - 2.1.10-10
+- Rebuilt with fixed Rebar
+
+* Wed Jul 24 2019 Fedora Release Engineering <releng> - 2.1.10-9
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild
+
+* Thu Jan 31 2019 Fedora Release Engineering <releng> - 2.1.10-8
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild
+
+* Thu Sep 13 2018 Peter Lemenkov <lemenkov> - 2.1.10-7
+- Load schema files from noarch directories as well
+
+* Tue Sep 11 2018 Peter Lemenkov <lemenkov> - 2.1.10-6
+- Get rid of folsom
+
+* Fri Jul 13 2018 Fedora Release Engineering <releng> - 2.1.10-5
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_29_Mass_Rebuild
+
+* Wed Jun 13 2018 Randy Barlow <bowlofeggs> - 2.1.10-4
+- Convert into a noarch package.
+- Rebuild against the noarch lager (#1589611).
+
+* Wed Mar 21 2018 Peter Lemenkov <lemenkov> - 2.1.10-3
+- Rebuild for Erlang 20 (with proper builddeps)
+- Fix FTBFS with Erlang 20
+
+* Wed Feb 07 2018 Fedora Release Engineering <releng> - 2.1.10-2
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_28_Mass_Rebuild
+
+* Sun Aug 13 2017 Peter Lemenkov <lemenkov> - 2.1.10-1
+- Ver. 2.1.10
+
+* Wed Aug 02 2017 Fedora Release Engineering <releng> - 2.1.5-4
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Binutils_Mass_Rebuild
+
+* Wed Jul 26 2017 Fedora Release Engineering <releng> - 2.1.5-3
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Mass_Rebuild
+
+* Fri Feb 10 2017 Fedora Release Engineering <releng> - 2.1.5-2
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_26_Mass_Rebuild
+
+* Fri Apr 22 2016 Peter Lemenkov <lemenkov> - 2.1.5-1
+- Ver. 2.1.5
+
+* Wed Feb 03 2016 Fedora Release Engineering <releng> - 1.3.2-5
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_24_Mass_Rebuild
+
+* Wed Jun 17 2015 Fedora Release Engineering <rel-eng.org> - 1.3.2-4
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_23_Mass_Rebuild
+
+* Sat Aug 16 2014 Fedora Release Engineering <rel-eng.org> - 1.3.2-3
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_21_22_Mass_Rebuild
+
+* Sat Jun 07 2014 Fedora Release Engineering <rel-eng.org> - 1.3.2-2
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_21_Mass_Rebuild
+
+* Tue Jul 02 2013 Peter Lemenkov <lemenkov> - 1.3.2-1
+- Ver. 1.3.2
+
+* Sun Mar 24 2013 Peter Lemenkov <lemenkov> - 1.3.1-2
+- Fix webmachine dep
+
+* Sun Mar 24 2013 Peter Lemenkov <lemenkov> - 1.3.1-1
+- Ver. 1.3.1
+
+* Mon Mar 11 2013 Peter Lemenkov <lemenkov> - 1.3.0-1
+- Ver. 1.3.0
+
+* Wed Feb 13 2013 Fedora Release Engineering <rel-eng.org> - 1.2.1-4.p1
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_19_Mass_Rebuild
+
+* Sat Oct 20 2012 Peter Lemenkov <lemenkov> - 1.2.1-3.p1
+- Ver. 1.2.1p1
+
+* Fri Oct 19 2012 Peter Lemenkov <lemenkov> - 1.2.1-2
+- Rebuild with new lager
+
+* Wed Oct 10 2012 Peter Lemenkov <lemenkov> - 1.2.1-1
+- Ver. 1.2.1
+
+* Wed Sep 05 2012 Peter Lemenkov <lemenkov> - 1.2.0-1
+- Ver. 1.2.0
+
+* Thu Jul 19 2012 Peter Lemenkov <lemenkov> - 1.1.2-3
+- Re-export one handy function
+
+* Wed Jul 18 2012 Fedora Release Engineering <rel-eng.org> - 1.1.2-2
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_18_Mass_Rebuild
+
+* Fri May 18 2012 Peter Lemenkov <lemenkov> - 1.1.2-1
+- Ver. 1.1.2
+
+* Fri Feb 25 2011 Peter Lemenkov <lemenkov> - 0.14.1-1
+- Ver. 0.14.1
+
+* Sat Jan 22 2011 Peter Lemenkov <lemenkov> - 0.14.0-1
+- Ver. 0.14.0
+- Dropped upstreamed patch
+
+* Fri Nov 12 2010 Peter Lemenkov <lemenkov> - 0.13.0-1
+- Initial build
+
+## END: Generated by rpmautospec


Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2303917
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Generic
Disabled plugins: C/C++, fonts, Perl, Haskell, PHP, Ocaml, Java, SugarActivity, Python, R
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Comments:
a) A number of other licenses seem to be used:
*No copyright* Erlang Public License v1.1
-----------------------------------------
erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/bloom.erl
rlang Public License v1.1
--------------------------
erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_gen_server.erl

MIT License
-----------
erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/dvvset.erl
erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/gen_nb_server.erl

Mozilla Public License 1.1
--------------------------
erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/riak_core_priority_queue.erl

Comment 2 Peter Lemenkov 2024-11-06 17:39:22 UTC
Thank you for starting reviewing this!

(In reply to Benson Muite from comment #1)
> Package Review
> ==============
> 
> Legend:
> [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
> [ ] = Manual review needed
> 
> 
> Issues:
> =======
> - Package does not use a name that already exists.
>   Note: A package with this name already exists. Please check
>   https://src.fedoraproject.org/rpms/erlang-riak_core
>   See: https://docs.fedoraproject.org/en-US/packaging-
>   guidelines/Naming/#_conflicting_package_names
> 
> 
> ===== MUST items =====
> 
> Generic:
> [x]: Package is licensed with an open-source compatible license and meets
>      other legal requirements as defined in the legal section of Packaging
>      Guidelines.
> [!]: License field in the package spec file matches the actual license.
>      Note: Checking patched sources after %prep for licenses. Licenses
>      found: "*No copyright* Apache License 2.0", "Unknown or generated",
>      "Apache License 2.0", "*No copyright* Erlang Public License v1.1",
>      "MIT License", "Erlang Public License v1.1", "Mozilla Public License
>      1.1". 47 files have unknown license. Detailed output of licensecheck
>      in /home/FedoraPackaging/reviews/erlang-riak_core/2303917-erlang-
>      riak_core/licensecheck.txt

Inproved licensing info, added licensing breakdown.

> [x]: Package contains no bundled libraries without FPC exception.
> [x]: Changelog in prescribed format.
> [x]: Sources contain only permissible code or content.
> [-]: Package contains desktop file if it is a GUI application.
> [-]: Development files must be in a -devel package
> [x]: Package uses nothing in %doc for runtime.
> [x]: Package consistently uses macros (instead of hard-coded directory
>      names).
> [x]: Package is named according to the Package Naming Guidelines.
> [x]: Package does not generate any conflict.
> [x]: Package obeys FHS, except libexecdir and /usr/target.
> [ ]: If the package is a rename of another package, proper Obsoletes and
>      Provides are present.

This is not a rename of another package.

> [x]: Requires correct, justified where necessary.
> [x]: Spec file is legible and written in American English.
> [-]: Package contains systemd file(s) if in need.
> [x]: Package is not known to require an ExcludeArch tag.
> [-]: Large documentation must go in a -doc subpackage. Large could be size
>      (~1MB) or number of files.
>      Note: Documentation size is 196437 bytes in 11 files.
> [ ]: Package complies to the Packaging Guidelines

Erlang packaging is still w.i.p.
I'll restart working on the current draft. Hopefully this time I'll make it official.

> [x]: Package successfully compiles and builds into binary rpms on at least
>      one supported primary architecture.
> [x]: Package installs properly.
> [x]: Rpmlint is run on all rpms the build produces.
>      Note: There are rpmlint messages (see attachment).
> [x]: If (and only if) the source package includes the text of the
>      license(s) in its own file, then that file, containing the text of the
>      license(s) for the package is included in %license.
> [x]: The License field must be a valid SPDX expression.
> [x]: Package requires other packages for directories it uses.
> [x]: Package must own all directories that it creates.
> [x]: Package does not own files or directories owned by other packages.
> [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
> [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>      beginning of %install.
> [x]: Macros in Summary, %description expandable at SRPM build time.
> [x]: Dist tag is present.
> [x]: Package does not contain duplicates in %files.
> [x]: Permissions on files are set properly.
> [x]: Package must not depend on deprecated() packages.
> [x]: Package use %makeinstall only when make install DESTDIR=... doesn't
>      work.
> [x]: Package is named using only allowed ASCII characters.
> [x]: Package is not relocatable.
> [x]: Sources used to build the package match the upstream source, as
>      provided in the spec URL.
> [x]: Spec file name must match the spec package %{name}, in the format
>      %{name}.spec.
> [x]: File names are valid UTF-8.
> [x]: Packages must not store files under /srv, /opt or /usr/local
> 
> ===== SHOULD items =====
> 
> Generic:
> [ ]: If the source package does not include license text(s) as a separate
>      file from upstream, the packager SHOULD query upstream to include it.

Upstream only ships Apache-2.0 license. I'll work with them on a proper solution. Actually I believe that the old cruft licensed under different terms should be just dropped/rewritten.

> [x]: Final provides and requires are sane (see attachments).
> [ ]: Package functions as described.

It passes unit-tests so likely it does. This is a part of a bigger application - we'll know the answer eventually.

> [x]: Latest version is packaged.
> [x]: Package does not include license text files separate from upstream.
> [x]: Patches link to upstream bugs/comments/lists or are otherwise
>      justified.
> [-]: Sources are verified with gpgverify first in %prep if upstream
>      publishes signatures.
>      Note: gpgverify is not used.
> [x]: Package should compile and build into binary rpms on all supported
>      architectures.
> [x]: %check is present and all tests pass.
> [x]: Packages should try to preserve timestamps of original installed
>      files.
> [x]: Reviewer should test that the package builds in mock.
> [x]: Buildroot is not present
> [x]: Package has no %clean section with rm -rf %{buildroot} (or
>      $RPM_BUILD_ROOT)
> [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
> [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
> [x]: Sources can be downloaded from URI in Source: tag
> [x]: SourceX is a working URL.
> [x]: Spec use %global instead of %define unless justified.
> 
> ===== EXTRA items =====
> 
> Generic:
> [!]: Spec file according to URL is the same as in SRPM.
>      Note: Spec file as given by url is not the same as in SRPM (see
>      attached diff).
>      See: (this test has no URL)

Uploaded a new spec-file. This time in sync with the one provided in SRPM.

> [x]: Rpmlint is run on all installed packages.
>      Note: No rpmlint messages.
> 
> 
> Rpmlint
> -------
> Checking: erlang-riak_core-3.0.16-1.fc42.noarch.rpm
>           erlang-riak_core-3.0.16-1.fc42.src.rpm
> ======================================= rpmlint session starts
> ======================================
> rpmlint: 2.5.0
> configuration:
>     /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
>     /etc/xdg/rpmlint/fedora-legacy-licenses.toml
>     /etc/xdg/rpmlint/fedora-spdx-licenses.toml
>     /etc/xdg/rpmlint/fedora.toml
>     /etc/xdg/rpmlint/scoring.toml
>     /etc/xdg/rpmlint/users-groups.toml
>     /etc/xdg/rpmlint/warn-on-functions.toml
> rpmlintrc: [PosixPath('/tmp/tmpl8h7tekk')]
> checks: 32, packages: 2
> 
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/app_helper.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/app_helper.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/bloom.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/bloom.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/chash.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/chash.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/chashbin.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/chashbin.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/dvvset.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/dvvset.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/gen_nb_server.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/gen_nb_server.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/hashtree.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/hashtree.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/hashtree_tree.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/hashtree_tree.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/mock_vnode.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/mock_vnode.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/pbkdf2.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/pbkdf2.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/process_proxy.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/process_proxy.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_apl.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_apl.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_app.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_app.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_bg_manager.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_bg_manager.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_broadcast.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_broadcast.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_broadcast_handler.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_broadcast_handler.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_bucket.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_bucket.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_bucket_props.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_bucket_props.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_bucket_type.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_bucket_type.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_capability.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_capability.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_cinfo_core.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_cinfo_core.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_claim_binring_alg.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_claim_binring_alg.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_claim_sim.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_claim_sim.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_claim_swapping.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_claim_swapping.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_claim_util.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_claim_util.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_claimant.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_claimant.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_cli_registry.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_cli_registry.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_cluster_cli.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_cluster_cli.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_console.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_console.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_console_table.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_console_table.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_coverage_fsm.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_coverage_fsm.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_coverage_plan.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_coverage_plan.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_dist_mon.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_dist_mon.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_dtrace.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_dtrace.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_eventhandler_guard.
> beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_eventhandler_guard.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_eventhandler_sup.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_eventhandler_sup.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_format.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_format.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_gen_server.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_gen_server.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_gossip.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_gossip.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_handoff_cli.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_handoff_cli.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_handoff_listener.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_handoff_listener.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_handoff_listener_sup.
> beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_handoff_listener_sup.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_handoff_manager.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_handoff_manager.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_handoff_receiver.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_handoff_receiver.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_handoff_receiver_sup.
> beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_handoff_receiver_sup.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_handoff_sender.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_handoff_sender.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_handoff_sender_sup.
> beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_handoff_sender_sup.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_handoff_status.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_handoff_status.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_handoff_sup.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_handoff_sup.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_location.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_location.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_membership_claim.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_membership_claim.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_membership_leave.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_membership_leave.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_metadata.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_metadata.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_metadata_exchange_fsm.
> beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_metadata_exchange_fsm.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_metadata_hashtree.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_metadata_hashtree.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_metadata_manager.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_metadata_manager.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_metadata_object.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_metadata_object.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_net_ticktime.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_net_ticktime.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_node_watcher.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_node_watcher.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_node_watcher_events.
> beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_node_watcher_events.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_node_worker_pool.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_node_worker_pool.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_node_worker_pool_sup.
> beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_node_worker_pool_sup.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_nodeid.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_nodeid.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_priority_queue.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_priority_queue.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_pw_auth.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_pw_auth.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_repair.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_repair.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_ring.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_ring.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_ring_events.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_ring_events.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_ring_handler.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_ring_handler.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_ring_manager.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_ring_manager.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_ring_util.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_ring_util.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_security.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_security.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_send_msg.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_send_msg.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_ssl_util.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_ssl_util.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_stat.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_stat.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_stat_cache.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_stat_cache.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_stat_calc_proc.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_stat_calc_proc.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_stat_calc_sup.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_stat_calc_sup.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_stat_q.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_stat_q.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_stat_sup.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_stat_sup.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_stat_xform.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_stat_xform.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_stats_sup.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_stats_sup.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_status.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_status.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_sup.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_sup.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_sysmon_handler.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_sysmon_handler.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_sysmon_minder.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_sysmon_minder.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_table_owner.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_table_owner.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_tcp_mon.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_tcp_mon.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_test_util.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_test_util.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_throttle.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_throttle.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_tracer.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_tracer.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_util.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_util.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_vnode.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_vnode.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_vnode_manager.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_vnode_manager.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_vnode_master.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_vnode_master.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_vnode_proxy.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_vnode_proxy.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_vnode_proxy_sup.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_vnode_proxy_sup.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_vnode_sup.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_vnode_sup.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_vnode_worker.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_vnode_worker.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_vnode_worker_pool.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_vnode_worker_pool.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/riak_core_worker_pool.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/riak_core_worker_pool.erl
> erlang-riak_core.noarch: W: beam-was-not-recompiled
> /usr/share/erlang/lib/riak_core-3.0.16/ebin/vclock.beam
> /builddir/build/BUILD/erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/
> src/vclock.erl
> = 2 packages and 0 specfiles checked; 0 errors, 103 warnings, 7 filtered, 0
> badness; has taken 4.6 s 
> 

^^^ These are false positives. I'll work on a proper solution for rpmlint.

> 
> 
> Rpmlint (installed packages)
> ----------------------------
> ============================ rpmlint session starts
> ============================
> rpmlint: 2.5.0
> configuration:
>     /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
>     /etc/xdg/rpmlint/fedora-spdx-licenses.toml
>     /etc/xdg/rpmlint/fedora.toml
>     /etc/xdg/rpmlint/scoring.toml
>     /etc/xdg/rpmlint/users-groups.toml
>     /etc/xdg/rpmlint/warn-on-functions.toml
> checks: 32, packages: 1
> 
>  1 packages and 0 specfiles checked; 0 errors, 0 warnings, 3 filtered, 0
> badness; has taken 2.7 s 
> 
> 
> 
> Source checksums
> ----------------
> https://github.com/basho/riak_core/archive/riak_kv-3.0.16/riak_core-3.0.16.
> tar.gz :
>   CHECKSUM(SHA256) this package     :
> 4dbfdecaf42995bc2b2ab628b429e6cebe042cf28fb28134c0243e38f4ff83b5
>   CHECKSUM(SHA256) upstream package :
> 4dbfdecaf42995bc2b2ab628b429e6cebe042cf28fb28134c0243e38f4ff83b5
> 
> 
> Requires
> --------
> erlang-riak_core (rpmlib, GLIBC filtered):
>     erlang-basho_stats
>     erlang-clique
>     erlang-cluster_info
>     erlang-crypto(x86-64)
>     erlang-cuttlefish
>     erlang-eleveldb(x86-64)
>     erlang-erts(x86-64)
>     erlang-exometer_core
>     erlang-folsom
>     erlang-inets(x86-64)
>     erlang-kernel(x86-64)
>     erlang-lager
>     erlang-mochiweb
>     erlang-poolboy
>     erlang-public_key(x86-64)
>     erlang-riak_ensemble(x86-64)
>     erlang-riak_sysmon
>     erlang-runtime_tools(x86-64)
>     erlang-ssl(x86-64)
>     erlang-stdlib(x86-64)
> 
> 
> 
> Provides
> --------
> erlang-riak_core:
>     erlang-riak_core
> 
> 
> 
> Diff spec file in url and in SRPM
> ---------------------------------
> ---
> /home/benson/Projects/FedoraPackaging/reviews/erlang-riak_core/2303917-
> erlang-riak_core/srpm/erlang-riak_core.spec       2024-11-05
> 18:51:27.794871723 +0300
> +++
> /home/benson/Projects/FedoraPackaging/reviews/erlang-riak_core/2303917-
> erlang-riak_core/srpm-unpacked/erlang-riak_core.spec      2024-08-09
> 03:00:00.000000000 +0300
> @@ -1,2 +1,12 @@
> +## START: Set by rpmautospec
> +## (rpmautospec version 0.6.5)
> +## RPMAUTOSPEC: autorelease, autochangelog
> +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua:
> +    release_number = 1;
> +    base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}"));
> +    print(release_number + base_release_number - 1);
> +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}}
> +## END: Set by rpmautospec
> +
>  %global realname riak_core
>  
> @@ -78,3 +88,121 @@
>  
>  %changelog
> -%autochangelog
> +## START: Generated by rpmautospec
> +* Fri Aug 09 2024 Peter Lemenkov <lemenkov> - 3.0.16-1
> +- Uncommitted changes
> +
> +* Wed Jul 21 2021 Fedora Release Engineering <releng> -
> 2.1.10-14
> +- Rebuilt for https://fedoraproject.org/wiki/Fedora_35_Mass_Rebuild
> +
> +* Tue Jan 26 2021 Fedora Release Engineering <releng> -
> 2.1.10-13
> +- Rebuilt for https://fedoraproject.org/wiki/Fedora_34_Mass_Rebuild
> +
> +* Mon Jul 27 2020 Fedora Release Engineering <releng> -
> 2.1.10-12
> +- Rebuilt for https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild
> +
> +* Tue Jan 28 2020 Fedora Release Engineering <releng> -
> 2.1.10-11
> +- Rebuilt for https://fedoraproject.org/wiki/Fedora_32_Mass_Rebuild
> +
> +* Tue Nov 12 2019 Peter Lemenkov <lemenkov> - 2.1.10-10
> +- Rebuilt with fixed Rebar
> +
> +* Wed Jul 24 2019 Fedora Release Engineering <releng> -
> 2.1.10-9
> +- Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild
> +
> +* Thu Jan 31 2019 Fedora Release Engineering <releng> -
> 2.1.10-8
> +- Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild
> +
> +* Thu Sep 13 2018 Peter Lemenkov <lemenkov> - 2.1.10-7
> +- Load schema files from noarch directories as well
> +
> +* Tue Sep 11 2018 Peter Lemenkov <lemenkov> - 2.1.10-6
> +- Get rid of folsom
> +
> +* Fri Jul 13 2018 Fedora Release Engineering <releng> -
> 2.1.10-5
> +- Rebuilt for https://fedoraproject.org/wiki/Fedora_29_Mass_Rebuild
> +
> +* Wed Jun 13 2018 Randy Barlow <bowlofeggs> - 2.1.10-4
> +- Convert into a noarch package.
> +- Rebuild against the noarch lager (#1589611).
> +
> +* Wed Mar 21 2018 Peter Lemenkov <lemenkov> - 2.1.10-3
> +- Rebuild for Erlang 20 (with proper builddeps)
> +- Fix FTBFS with Erlang 20
> +
> +* Wed Feb 07 2018 Fedora Release Engineering <releng> -
> 2.1.10-2
> +- Rebuilt for https://fedoraproject.org/wiki/Fedora_28_Mass_Rebuild
> +
> +* Sun Aug 13 2017 Peter Lemenkov <lemenkov> - 2.1.10-1
> +- Ver. 2.1.10
> +
> +* Wed Aug 02 2017 Fedora Release Engineering <releng> -
> 2.1.5-4
> +- Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Binutils_Mass_Rebuild
> +
> +* Wed Jul 26 2017 Fedora Release Engineering <releng> -
> 2.1.5-3
> +- Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Mass_Rebuild
> +
> +* Fri Feb 10 2017 Fedora Release Engineering <releng> -
> 2.1.5-2
> +- Rebuilt for https://fedoraproject.org/wiki/Fedora_26_Mass_Rebuild
> +
> +* Fri Apr 22 2016 Peter Lemenkov <lemenkov> - 2.1.5-1
> +- Ver. 2.1.5
> +
> +* Wed Feb 03 2016 Fedora Release Engineering <releng> -
> 1.3.2-5
> +- Rebuilt for https://fedoraproject.org/wiki/Fedora_24_Mass_Rebuild
> +
> +* Wed Jun 17 2015 Fedora Release Engineering
> <rel-eng.org> - 1.3.2-4
> +- Rebuilt for https://fedoraproject.org/wiki/Fedora_23_Mass_Rebuild
> +
> +* Sat Aug 16 2014 Fedora Release Engineering
> <rel-eng.org> - 1.3.2-3
> +- Rebuilt for https://fedoraproject.org/wiki/Fedora_21_22_Mass_Rebuild
> +
> +* Sat Jun 07 2014 Fedora Release Engineering
> <rel-eng.org> - 1.3.2-2
> +- Rebuilt for https://fedoraproject.org/wiki/Fedora_21_Mass_Rebuild
> +
> +* Tue Jul 02 2013 Peter Lemenkov <lemenkov> - 1.3.2-1
> +- Ver. 1.3.2
> +
> +* Sun Mar 24 2013 Peter Lemenkov <lemenkov> - 1.3.1-2
> +- Fix webmachine dep
> +
> +* Sun Mar 24 2013 Peter Lemenkov <lemenkov> - 1.3.1-1
> +- Ver. 1.3.1
> +
> +* Mon Mar 11 2013 Peter Lemenkov <lemenkov> - 1.3.0-1
> +- Ver. 1.3.0
> +
> +* Wed Feb 13 2013 Fedora Release Engineering
> <rel-eng.org> - 1.2.1-4.p1
> +- Rebuilt for https://fedoraproject.org/wiki/Fedora_19_Mass_Rebuild
> +
> +* Sat Oct 20 2012 Peter Lemenkov <lemenkov> - 1.2.1-3.p1
> +- Ver. 1.2.1p1
> +
> +* Fri Oct 19 2012 Peter Lemenkov <lemenkov> - 1.2.1-2
> +- Rebuild with new lager
> +
> +* Wed Oct 10 2012 Peter Lemenkov <lemenkov> - 1.2.1-1
> +- Ver. 1.2.1
> +
> +* Wed Sep 05 2012 Peter Lemenkov <lemenkov> - 1.2.0-1
> +- Ver. 1.2.0
> +
> +* Thu Jul 19 2012 Peter Lemenkov <lemenkov> - 1.1.2-3
> +- Re-export one handy function
> +
> +* Wed Jul 18 2012 Fedora Release Engineering
> <rel-eng.org> - 1.1.2-2
> +- Rebuilt for https://fedoraproject.org/wiki/Fedora_18_Mass_Rebuild
> +
> +* Fri May 18 2012 Peter Lemenkov <lemenkov> - 1.1.2-1
> +- Ver. 1.1.2
> +
> +* Fri Feb 25 2011 Peter Lemenkov <lemenkov> - 0.14.1-1
> +- Ver. 0.14.1
> +
> +* Sat Jan 22 2011 Peter Lemenkov <lemenkov> - 0.14.0-1
> +- Ver. 0.14.0
> +- Dropped upstreamed patch
> +
> +* Fri Nov 12 2010 Peter Lemenkov <lemenkov> - 0.13.0-1
> +- Initial build
> +
> +## END: Generated by rpmautospec
> 
> 
> Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
> Command line :/usr/bin/fedora-review -b 2303917
> Buildroot used: fedora-rawhide-x86_64
> Active plugins: Shell-api, Generic
> Disabled plugins: C/C++, fonts, Perl, Haskell, PHP, Ocaml, Java,
> SugarActivity, Python, R
> Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
> 
> Comments:
> a) A number of other licenses seem to be used:
> *No copyright* Erlang Public License v1.1
> -----------------------------------------
> erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/bloom.erl
> rlang Public License v1.1
> --------------------------
> erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/
> riak_core_gen_server.erl
> 
> MIT License
> -----------
> erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/dvvset.erl
> erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/gen_nb_server.erl
> 
> Mozilla Public License 1.1
> --------------------------
> erlang-riak_core-3.0.16-build/riak_core-riak_kv-3.0.16/src/
> riak_core_priority_queue.erl

New package:

Spec URL: https://peter.fedorapeople.org/packages/re-review/erlang-riak_core.spec
SRPM URL: https://peter.fedorapeople.org/packages/re-review/erlang-riak_core-3.0.16-1.fc41.src.rpm

Koji scratch build for Rawhide:

* https://koji.fedoraproject.org/koji/taskinfo?taskID=125560403

Comment 3 Fedora Review Service 2024-11-06 17:52:39 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8223285
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2303917-erlang-riak_core/fedora-rawhide-x86_64/08223285-erlang-riak_core/fedora-review/review.txt

Found issues:

- Not a valid SPDX expression 'Apache-2.0 and ErlPL-1.1 and MIT and MPL-1.1'.
  Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1
- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/erlang-riak_core
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Benson Muite 2024-11-07 02:06:43 UTC
Comments:
a) Please change
Apache-2.0 and ErlPL-1.1 and MIT and MPL-1.1
to
Apache-2.0 AND ErlPL-1.1 AND MIT AND MPL-1.1
b) Approved. Above can be done on import.

Comment 5 Peter Lemenkov 2024-11-07 04:38:53 UTC
(In reply to Benson Muite from comment #4)
> Comments:
> a) Please change
> Apache-2.0 and ErlPL-1.1 and MIT and MPL-1.1
> to
> Apache-2.0 AND ErlPL-1.1 AND MIT AND MPL-1.1

Done.

> b) Approved. Above can be done on import.

Thank you!


Note You need to log in before you can comment on or make changes to this bug.