Bug 2304221 - Review Request: rust-ash - Vulkan bindings for Rust
Summary: Review Request: rust-ash - Vulkan bindings for Rust
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2292541
TreeView+ depends on / blocked
 
Reported: 2024-08-13 01:05 UTC by Jonathan Steffan
Modified: 2024-08-30 15:40 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-08-30 15:40:45 UTC
Type: ---
Embargoed:
michel: fedora-review+


Attachments (Terms of Use)

Description Jonathan Steffan 2024-08-13 01:05:54 UTC
Spec URL: https://jsteffan.fedorapeople.org/envision/rust-ash.spec
SRPM URL: https://jsteffan.fedorapeople.org/envision/rust-ash-0.38.0-1.fc39/rust-ash-0.38.0-1.fc40.src.rpm
Description: Vulkan bindings for Rust
Fedora Account System Username: jsteffan

Comment 1 Jonathan Steffan 2024-08-13 01:18:18 UTC
[tests]
comments = [
  "Skip the doctests",
]
run = ["lib", "tests"]

Comment 2 Michel Lind 2024-08-27 22:45:22 UTC
small nit: please expand on why doctests are skipped. Otherwise this looks good, approved.

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks (use `fedora-sig-onboard onboard rust-$crate` to automate):

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 3 Fedora Admin user for bugzilla script actions 2024-08-27 22:50:50 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-ash

Comment 4 Fabio Valentini 2024-08-27 23:14:41 UTC
> - package builds and installs without errors on rawhide

This is a lie. ;)

Package fails to build on i686, exposing that this one ships pre-generated code that MUST be regenerated with bindgen during the build.

Comment 5 Jonathan Steffan 2024-08-28 00:15:14 UTC
Yup, and they wrote their own generator https://github.com/ash-rs/ash/blob/master/generator/Cargo.toml so I think this means at least two additional packages vk-parse and vkxml (and anything those need) so we can actually run it at build time.

I'll get started on adding the needed additional packages to be able to build and run the generator.

Comment 6 Fedora Update System 2024-08-30 15:38:30 UTC
FEDORA-2024-e6a82fb408 (rust-ash-0.38.0-3.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-e6a82fb408

Comment 7 Fedora Update System 2024-08-30 15:40:45 UTC
FEDORA-2024-e6a82fb408 (rust-ash-0.38.0-3.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.