SPEC: https://download.copr.fedorainfracloud.org/results/frantisekz/mozjs128/fedora-rawhide-x86_64/07908165-mozjs128/mozjs128.spec

SRPM: https://download.copr.fedorainfracloud.org/results/frantisekz/mozjs128/fedora-rawhide-x86_64/07908165-mozjs128/mozjs128-128.1.0-2.fc41.src.rpm

I suppose that this is not quite ready yet, but it would be good to get the results from bug 2304756, regardless. Should the gcc dependencies be behind a conditional, if the toolchain is clang?

(In reply to David King from comment #2)
> I suppose that this is not quite ready yet, but it would be good to get the
> results from bug 2304756, regardless. Should the gcc dependencies be behind
> a conditional, if the toolchain is clang?

Yes, I can (and will) conditionalize it, good point.

Apart from that, it should be ready for review/based on and very similar other mozjs packages I own.

SPEC: https://download.copr.fedorainfracloud.org/results/frantisekz/mozjs128/fedora-rawhide-x86_64/07910331-mozjs128/mozjs128.spec

SRPM: https://download.copr.fedorainfracloud.org/results/frantisekz/mozjs128/fedora-rawhide-x86_64/07910331-mozjs128/mozjs128-128.1.0-2.fc41.src.rpm

Added ifs around clang/gcc BRs. clang-devel is needed even when using gcc to build. Should be ready for review.

Taking this for review.

Review notes:

* Package builds and installs
* Package follows Fedora packaging guidelines
* Licensing is correct and license files are captured

Some nits:

> %if 0%{?build_with_lto}
> # LTO is the default
> %else
> %define _lto_cflags %{nil}
> %endif

This can be written more simply:

> %if ! 0%{?build_with_lto}
> # LTO is the default
> %define _lto_cflags %{nil}
> %endif

Otherwise, this looks good.

PACKAGE APPROVED.

The Pagure repository was created at https://src.fedoraproject.org/rpms/mozjs128