Bug 2305262 - rust2rpm --patch hides cargo metadate error messages
Summary: rust2rpm --patch hides cargo metadate error messages
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: cargo2rpm
Version: rawhide
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Rust SIG
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-08-16 02:40 UTC by Orion Poplawski
Modified: 2024-09-17 02:58 UTC (History)
3 users (show)

Fixed In Version: cargo2rpm-0.1.17-1.fc41 cargo2rpm-0.1.17-1.el9 cargo2rpm-0.1.17-1.fc39 cargo2rpm-0.1.17-1.fc40
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-09-13 20:55:20 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Orion Poplawski 2024-08-16 02:40:56 UTC
$ rust2rpm crc-any --patch
Subcommand failed with code 101: cargo metadata --quiet --format-version 1 --offline --no-deps --manifest-path /tmp/tmp76b90d62/crc-any-2.5.0/Cargo.toml

I save and exit the editor, but then the /tmp file is gone and the cargo-metadata command fails

rust2rpm-26.1.1-3.fc41.noarch

Reproducible: Always

Comment 1 Fabio Valentini 2024-08-20 11:21:59 UTC
I cannot reproduce this issue ... do you have any special setup for /tmp on your system?

Comment 2 Orion Poplawski 2024-08-21 02:18:43 UTC
Okay, the problem is that I am editing the Cargo.toml in such a way that it cannot be parsed.  But the error message that cargo metadata produces is not output so it is very hard to tell what is going on.  If I run the command on the file manually I get:

error: failed to parse manifest at `/home/orion/rust-crc-any/rust-crc-any-2.5.0-build/crc-any-2.5.0/Cargo.toml`

Caused by:
  feature `alloc` includes `debug-helper` which is neither a dependency nor another feature

Can we get rust2rpm to output that message?

Comment 3 Fabio Valentini 2024-09-08 15:36:08 UTC
Hum, looks like there's a bug in cargo2rpm that makes it eat command output in case the return code from "cargo metadata" is non-zero.

I'm testing a fix now - if it resolves this issue, I'll tag a new release and update the package in Fedora.

Comment 4 Fedora Update System 2024-09-08 19:42:26 UTC
FEDORA-EPEL-2024-b73358ead7 (cargo2rpm-0.1.17-1.el9) has been submitted as an update to Fedora EPEL 9.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-b73358ead7

Comment 5 Fedora Update System 2024-09-08 19:42:27 UTC
FEDORA-2024-4eb27d6b90 (cargo2rpm-0.1.17-1.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-4eb27d6b90

Comment 6 Fedora Update System 2024-09-08 19:42:27 UTC
FEDORA-2024-5109f41e83 (cargo2rpm-0.1.17-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-5109f41e83

Comment 7 Fedora Update System 2024-09-08 19:42:27 UTC
FEDORA-2024-f72de18097 (cargo2rpm-0.1.17-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-f72de18097

Comment 8 Fedora Update System 2024-09-09 01:12:25 UTC
FEDORA-EPEL-2024-b73358ead7 has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-b73358ead7

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2024-09-09 02:07:52 UTC
FEDORA-2024-f72de18097 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-f72de18097`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-f72de18097

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2024-09-09 15:19:34 UTC
FEDORA-2024-4eb27d6b90 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-4eb27d6b90`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-4eb27d6b90

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2024-09-09 19:25:49 UTC
FEDORA-2024-5109f41e83 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-5109f41e83`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-5109f41e83

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2024-09-13 20:55:20 UTC
FEDORA-2024-f72de18097 (cargo2rpm-0.1.17-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2024-09-17 00:42:59 UTC
FEDORA-EPEL-2024-b73358ead7 (cargo2rpm-0.1.17-1.el9) has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2024-09-17 02:07:30 UTC
FEDORA-2024-4eb27d6b90 (cargo2rpm-0.1.17-1.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 15 Fedora Update System 2024-09-17 02:58:16 UTC
FEDORA-2024-5109f41e83 (cargo2rpm-0.1.17-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.