Bug 230617 - Kernel spec file 'sublevel' can break compile if sublevel is not integer
Summary: Kernel spec file 'sublevel' can break compile if sublevel is not integer
Status: CLOSED NOTABUG
Alias: None
Product: Red Hat Enterprise Linux 4
Classification: Red Hat
Component: kernel (Show other bugs)
(Show other bugs)
Version: 4.0
Hardware: All Linux
medium
low
Target Milestone: ---
: ---
Assignee: Kernel Maintainer List
QA Contact: Brian Brock
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-03-01 19:47 UTC by Matthew Callaway
Modified: 2007-11-30 22:07 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-03-07 21:13:19 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

Description Matthew Callaway 2007-03-01 19:47:04 UTC
Description of problem:

If you set 'sublevel' to a non-integer value, say 19.3 or 20.1, you will break
the toplevel kernel Makefile, and cause failure to compile.  Specifically, in
the Makefile:

define filechk_version.h
        (echo \#define LINUX_VERSION_CODE $(shell                             \
        expr $(VERSION) \* 65536 + $(PATCHLEVEL) \* 256 + $(SUBLEVEL));     \
        echo '#define KERNEL_VERSION(a,b,c) (((a) << 16) + ((b) << 8) + (c))';)
endef

This 'expr' will fail with non-numeric value in $SUBLEVEL.  This leaves
LINUX_VERSION_CODE undefined, and causes syntax errors.  The first one appears
in drivers/usb/core/hcd.c line 133.

Not a big deal for your products, but someday you might find yourself building a
kernel of version a.b.c.d and wonder why it doesn't compile.


Version-Release number of selected component (if applicable):

kernel 2.6.9 specfile.

How reproducible:

Always.

Steps to Reproduce:
1. Try to build a newer kernel with sublevel 19.3 or 20.1.
2. rpmbuild -ba --target i686 kernel-2.6.spec
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Jason Baron 2007-03-07 21:13:19 UTC
sublevel will not change over the life of rhel4 it is fixed at '9'. thus,
although it would be nice to make the code more general i don't see this as a bug.


Note You need to log in before you can comment on or make changes to this bug.