Spec URL: https://farchord.fedorapeople.org/reviews/wayqt/wayqt.spec SRPM URL: https://farchord.fedorapeople.org/reviews/wayqt/wayqt-0.2.0-1.fc40.src.rpm Description: The Qt-based library to handle Wayland and Wlroots protocols to be used with any Qt project. Additionally, Wayfire's private protocol as well is supported. As the project develops, support for custom protocols may be added. Fedora Account System Username: farchord
Copr build: https://copr.fedorainfracloud.org/coprs/build/7932241 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2306884-wayqt/fedora-rawhide-x86_64/07932241-wayqt/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
As per #devel:fedoraproject.org discussion, the `cmake` BuildRequires can be dropped: https://copr.fedorainfracloud.org/coprs/samcday/wayqt/build/7932232/ Additionally the `cmake(Qt6Foo)` build-deps could also be changed to `pkgconfig(Qt6Foo)`, which is perhaps more appropriate? Finally, `fedpkg lint` is complaining about line length on pkgdesc, I propose this alternative: ``` %global _description \ A Qt-based library to handle Wayland and Wlroots protocols, to be used with \ any Qt project. \ Wayfire's private protocol is also supported. As the project develops, support \ for custom protocols may be added. \ ``` I lack the necessary permissions to set the Whiteboard status for these early nits.
Meson searches by pkgconfig, so it does make sense to use the pkgconfig() names instead.
Spec URL: https://farchord.fedorapeople.org/reviews/wayqt/wayqt.spec SRPM URL: https://farchord.fedorapeople.org/reviews/wayqt/wayqt-0.2.0-1.fc40.src.rpm Updated buildrequires and description
Created attachment 2044606 [details] The .spec file difference from Copr build 7932241 to 7934744
Copr build: https://copr.fedorainfracloud.org/coprs/build/7934744 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2306884-wayqt/fedora-rawhide-x86_64/07934744-wayqt/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I am not currently sponsored as a packager so I can't assign/approve this, but am performing reviews to learn more about the guidelines and process. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - v0.3.0 has been released - %check is present but there are no tests to run - ReleaseNotes is empty and should not be installed - /usr/include/DFL is unowned, it should probably be owned by this package and co-owned by future DFL packages (or have a separate dfl-filesystem) - devel package has an invalid require for base and cannot be installed, it should use %{name}%{?_isa} = %{version}-%{release} - libwayland and libpng requires should be pkgconfig(libwayland-client) pkgconfig(libpng) per https://docs.fedoraproject.org/en-US/packaging-guidelines/PkgConfigBuildRequires/ ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License", "GNU General Public License, Version 3", "Historical Permission Notice and Disclaimer - sell variant and/or NTP License (legal disclaimer)", "GNU Lesser General Public License v2.1 or later". 20 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/wayqt/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [-]: Package requires other packages for directories it uses. Note: No known owner of /usr/include/DFL/DF6, /usr/include/DFL [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/include/DFL/DF6, /usr/include/DFL [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [!]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 4197 bytes in 2 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in wayqt- devel [x]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: wayqt-0.2.0-1.fc42.x86_64.rpm wayqt-devel-0.2.0-1.fc42.x86_64.rpm wayqt-debuginfo-0.2.0-1.fc42.x86_64.rpm wayqt-debugsource-0.2.0-1.fc42.x86_64.rpm wayqt-0.2.0-1.fc42.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp0vouc7ae')] checks: 32, packages: 5 wayqt.x86_64: E: zero-length /usr/share/doc/wayqt/ReleaseNotes wayqt.src: E: spelling-error ("Wayfire's", "%description -l en_US Wayfire's -> Way fire's, Way-fire's, Wayfarer's") wayqt.x86_64: E: spelling-error ("Wayfire's", "%description -l en_US Wayfire's -> Way fire's, Way-fire's, Wayfarer's") wayqt-devel.x86_64: E: spelling-error ('subpackage', "Summary(en_US) subpackage -> sub package, sub-package, package's") wayqt-devel.x86_64: E: spelling-error ("Wayfire's", "%description -l en_US Wayfire's -> Way fire's, Way-fire's, Wayfarer's") wayqt-devel.x86_64: W: no-documentation 5 packages and 0 specfiles checked; 5 errors, 1 warnings, 32 filtered, 5 badness; has taken 0.8 s Rpmlint (debuginfo) ------------------- Checking: wayqt-debuginfo-0.2.0-1.fc42.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp9kikx73u')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.2 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "wayqt-debuginfo". (none): E: there is no installed rpm "wayqt". (none): E: there is no installed rpm "wayqt-devel". (none): E: there is no installed rpm "wayqt-debugsource". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://gitlab.com/desktop-frameworks/wayqt/-/archive/v0.2.0/wayqt-v0.2.0.tar.gz : CHECKSUM(SHA256) this package : 0636d666d5ca09448336bf3eda42a016832a20bb82e4b7dc09bf79e428b02fef CHECKSUM(SHA256) upstream package : 0636d666d5ca09448336bf3eda42a016832a20bb82e4b7dc09bf79e428b02fef Requires -------- wayqt (rpmlib, GLIBC filtered): libQt6Core.so.6()(64bit) libQt6Core.so.6(Qt_6)(64bit) libQt6Core.so.6(Qt_6.7)(64bit) libQt6Gui.so.6()(64bit) libQt6Gui.so.6(Qt_6)(64bit) libQt6Gui.so.6(Qt_6.7_PRIVATE_API)(64bit) libQt6WaylandClient.so.6()(64bit) libQt6WaylandClient.so.6(Qt_6.7_PRIVATE_API)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libwayland-client.so.0()(64bit) rtld(GNU_HASH) wayqt-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libwayqt-qt6.so.0()(64bit) wayqt.fc42 wayqt-debuginfo (rpmlib, GLIBC filtered): wayqt-debugsource (rpmlib, GLIBC filtered): Provides -------- wayqt: libwayqt-qt6.so.0()(64bit) wayqt wayqt(x86-64) wayqt-devel: pkgconfig(wayqt-qt6) wayqt-devel wayqt-devel(x86-64) wayqt-debuginfo: debuginfo(build-id) libwayqt-qt6.so.0.2.0-0.2.0-1.fc42.x86_64.debug()(64bit) wayqt-debuginfo wayqt-debuginfo(x86-64) wayqt-debugsource: wayqt-debugsource wayqt-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name wayqt --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: Python, SugarActivity, Perl, fonts, R, Ocaml, Haskell, Java, PHP Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH