Spec URL: https://farchord.fedorapeople.org/reviews/wayqt/wayqt.spec SRPM URL: https://farchord.fedorapeople.org/reviews/wayqt/wayqt-0.2.0-1.fc40.src.rpm Description: The Qt-based library to handle Wayland and Wlroots protocols to be used with any Qt project. Additionally, Wayfire's private protocol as well is supported. As the project develops, support for custom protocols may be added. Fedora Account System Username: farchord
Copr build: https://copr.fedorainfracloud.org/coprs/build/7932241 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2306884-wayqt/fedora-rawhide-x86_64/07932241-wayqt/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
As per #devel:fedoraproject.org discussion, the `cmake` BuildRequires can be dropped: https://copr.fedorainfracloud.org/coprs/samcday/wayqt/build/7932232/ Additionally the `cmake(Qt6Foo)` build-deps could also be changed to `pkgconfig(Qt6Foo)`, which is perhaps more appropriate? Finally, `fedpkg lint` is complaining about line length on pkgdesc, I propose this alternative: ``` %global _description \ A Qt-based library to handle Wayland and Wlroots protocols, to be used with \ any Qt project. \ Wayfire's private protocol is also supported. As the project develops, support \ for custom protocols may be added. \ ``` I lack the necessary permissions to set the Whiteboard status for these early nits.
Meson searches by pkgconfig, so it does make sense to use the pkgconfig() names instead.
Spec URL: https://farchord.fedorapeople.org/reviews/wayqt/wayqt.spec SRPM URL: https://farchord.fedorapeople.org/reviews/wayqt/wayqt-0.2.0-1.fc40.src.rpm Updated buildrequires and description
Created attachment 2044606 [details] The .spec file difference from Copr build 7932241 to 7934744
Copr build: https://copr.fedorainfracloud.org/coprs/build/7934744 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2306884-wayqt/fedora-rawhide-x86_64/07934744-wayqt/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.