Spec URL: http://visionfutur.com/fedora/jwm.spec SRPM URL: http://visionfutur.com/fedora/jwm-1.8-1.src.rpm Description: JWM is a window manager for the X Window System. It's very simple and fast.
You should use the macro %{buildroot} instead of $RPM_BUILD_ROOT. You souldn't mix macro and variable style. "You should pick a style and use it consistently throughout your packaging." (http://www.fedoraproject.org/wiki/Packaging/Guidelines#head-f3d77b27a5d29dfc1f5600ef3fc836f2e317badf)
Sorry, I can't sponsor you. This isn't a full review, I just found some thing you have to fix. BuildRequires: libX11 isn't needed jwm doesn't honor $RPM_OPT_FLAGS, which means it's built without any compiler provided security features and other distro wide CFLAGS. Also, the debuginfo package is useless because the binary is explicitly stripped. One way to fix these issues is to add these after %configure: sed -i -e 's/^\(CFLAGS.*\)/\1 $(RPM_OPT_FLAGS)/' src/Makefile sed -i -e '/^\s*strip /d' src/Makefile
(In reply to comment #1) > You should use the macro %{buildroot} instead of $RPM_BUILD_ROOT. > You souldn't mix macro and variable style. > > "You should pick a style and use it consistently throughout your packaging." > (http://www.fedoraproject.org/wiki/Packaging/Guidelines#head-f3d77b27a5d29dfc1f5600ef3fc836f2e317badf) In the spec file $RPM_BUILD_ROOT is used consistently, no need to use %{buildroot}.
(In reply to comment #2) > jwm doesn't honor $RPM_OPT_FLAGS, which means it's built without any compiler > provided security features and other distro wide CFLAGS. As far as I can see it does. > Also, the debuginfo package is useless because the binary is explicitly > stripped. Indeed. > One way to fix these issues is to add these after %configure: As a suggestion, an even better solution would be to make a patch for src/Makefile.in to remove the strip, such that it doesn't fail silently if the Makefile.in is changed.
Remove: Requires: xorg-x11-server-Xorg think about vnc or ssh session. There seems to be many missing BuildRequires, as shown by the build log, along (to be verified): libpng-devel fribidi-devel libXpm-devel libXinerama-devel libXft-devel libfreetype-devel pkgconfig. A file installed in /usr/share/xsessions is missing.
What is the status of this bug?
Robert, could you, please, update according to the above suggestions?
Ping!
I will close this bug as NOTABUG if no response is received from submitter within one week.
CLOSING as NOTABUG. If someone wants to maintain jwm on Fedora, please file a new review request. Thank you!