Bug 230738 - (jwm) Review Request - jwm - Very light window manager
Review Request - jwm - Very light window manager
Status: CLOSED NOTABUG
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
6
i386 Linux
medium Severity medium
: ---
: ---
Assigned To: Nobody's working on this, feel free to take it
Fedora Package Reviews List
:
Depends On:
Blocks: FE-DEADREVIEW
  Show dependency treegraph
 
Reported: 2007-03-02 11:18 EST by robert
Modified: 2007-11-30 17:11 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-06-04 07:43:34 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:


Attachments (Terms of Use)

  None (edit)
Description robert 2007-03-02 11:18:58 EST
Spec URL: http://visionfutur.com/fedora/jwm.spec
SRPM URL: http://visionfutur.com/fedora/jwm-1.8-1.src.rpm
Description: JWM is a window manager for the X Window System.
It's very simple and fast.
Comment 1 Maxime Carron 2007-03-04 10:03:14 EST
You should use the macro %{buildroot} instead of $RPM_BUILD_ROOT.
You souldn't mix macro and variable style.

"You should pick a style and use it consistently throughout your packaging."
(http://www.fedoraproject.org/wiki/Packaging/Guidelines#head-f3d77b27a5d29dfc1f5600ef3fc836f2e317badf)
Comment 2 Alain Portal 2007-03-04 10:45:25 EST
Sorry, I can't sponsor you.
This isn't a full review, I just found some thing you have to fix.

BuildRequires: libX11 isn't needed

jwm doesn't honor $RPM_OPT_FLAGS, which means it's built without any compiler
provided security features and other distro wide CFLAGS.

Also, the debuginfo package is useless because the binary is explicitly 
stripped.

One way to fix these issues is to add these after %configure:
sed -i -e 's/^\(CFLAGS.*\)/\1 $(RPM_OPT_FLAGS)/' src/Makefile
sed -i -e '/^\s*strip /d' src/Makefile

Comment 3 Patrice Dumas 2007-03-04 10:56:02 EST
(In reply to comment #1)
> You should use the macro %{buildroot} instead of $RPM_BUILD_ROOT.
> You souldn't mix macro and variable style.
> 
> "You should pick a style and use it consistently throughout your packaging."
>
(http://www.fedoraproject.org/wiki/Packaging/Guidelines#head-f3d77b27a5d29dfc1f5600ef3fc836f2e317badf)

In the spec file $RPM_BUILD_ROOT is used consistently, no need to use
%{buildroot}.
Comment 4 Patrice Dumas 2007-03-04 11:11:13 EST
(In reply to comment #2)

> jwm doesn't honor $RPM_OPT_FLAGS, which means it's built without any compiler
> provided security features and other distro wide CFLAGS.

As far as I can see it does.
 
> Also, the debuginfo package is useless because the binary is explicitly 
> stripped.

Indeed.

> One way to fix these issues is to add these after %configure:

As a suggestion, an even better solution would be to make a patch 
for src/Makefile.in to remove the strip, such that it doesn't fail
silently if the Makefile.in is changed.
Comment 5 Patrice Dumas 2007-03-04 11:16:45 EST
Remove:
Requires: xorg-x11-server-Xorg
think about vnc or ssh session.

There seems to be many missing BuildRequires, as shown by the build
log, along (to be verified):
libpng-devel fribidi-devel libXpm-devel libXinerama-devel libXft-devel
libfreetype-devel pkgconfig.

A file installed in /usr/share/xsessions is missing.
Comment 6 Mamoru TASAKA 2007-04-09 12:19:59 EDT
What is the status of this bug?
Comment 7 Peter Lemenkov 2007-04-10 15:50:28 EDT
Robert, could you, please, update according to the above suggestions?
Comment 8 Peter Lemenkov 2007-05-18 07:48:37 EDT
Ping!
Comment 9 Mamoru TASAKA 2007-05-24 13:58:35 EDT
I will close this bug as NOTABUG if no response
is received from submitter within one week.
Comment 10 Mamoru TASAKA 2007-06-04 07:43:34 EDT
CLOSING as NOTABUG.

If someone wants to maintain jwm on Fedora, please file
a new review request. Thank you!

Note You need to log in before you can comment on or make changes to this bug.