Bug 2307697 - Review Request: libklvanc - VANC Processing Framework
Summary: Review Request: libklvanc - VANC Processing Framework
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neel Chauhan
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/stoth68000/libklvanc
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-08-24 07:17 UTC by Simone Caronni
Modified: 2024-09-13 20:45 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-09-06 00:41:21 UTC
Type: ---
Embargoed:
neel: fedora-review+


Attachments (Terms of Use)

Description Simone Caronni 2024-08-24 07:17:38 UTC
Spec URL: https://slaanesh.fedorapeople.org/libklvanc.spec
SRPM URL: https://slaanesh.fedorapeople.org/libklvanc-1.6.0-1.fc40.src.rpm
Description:
Libklvanc is a library which can be used for parsing/generation of Vertical
Ancillary Data (VANC) commonly found in the Serial Digital Interface (SDI) wire
protocol.

The library includes a general parser/decoder and an encoder for VANC lines, as
well as the ability to both decode and generate protocols commonly found in SDI,
including:

- SMPTE ST 334 - CEA-708 closed captions in VANC
- SMPTE ST 2016 Active Format Descriptor (AFD) and Bar Data
- SCTE-104 Ad triggers
- SMPTE ST 2038 arbitrary VANC encapsulation
- SMPTE ST 12-2 Timecodes
- SMPTE RDD 8 Subtitle Distribution packets
- SMPTE ST 2108-1 HDR/WCG Metadata Packing and Signaling

By providing both encoders and decoders, the library can be used for common use
cases involving both capture of SDI (and subsequent decoding) as well as
generation of VANC for inclusion in an SDI output interface. This includes
computing/validating checksums at various levels and dealing with subtle edge
cases related to VANC line formatting such as ensuring packets are contiguous.

The library also provides utility functions for various colorspaces VANC may be
represented in, including the V210 format typically used by BlackMagic Decklink
SDI cards.

Fedora Account System Username: slaanesh

Comment 1 Fedora Review Service 2024-08-24 07:22:02 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7939924
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2307697-libklvanc/fedora-rawhide-x86_64/07939924-libklvanc/fedora-review/review.txt

Found issues:

- Not a valid SPDX expression 'LGPL-2.1'.
  Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Neel Chauhan 2024-08-24 18:48:19 UTC
Let me review your package.

Comment 3 Neel Chauhan 2024-08-24 18:52:20 UTC
When I try to download your spec file, I get a "403 forbidden" issue. This makes it to see your source spec file.

Comment 4 Simone Caronni 2024-08-25 07:50:17 UTC
(In reply to Neel Chauhan from comment #3)
> When I try to download your spec file, I get a "403 forbidden" issue. This
> makes it to see your source spec file.

Fixed, sorry.

Comment 5 Neel Chauhan 2024-08-25 16:33:56 UTC
LGTM.

Comment 6 Simone Caronni 2024-08-28 09:05:49 UTC
Thanks for the review!

Comment 7 Fedora Admin user for bugzilla script actions 2024-08-28 09:06:42 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/libklvanc

Comment 8 Fedora Update System 2024-08-28 13:26:41 UTC
FEDORA-EPEL-2024-1943b9d958 (libklvanc-1.6.0-1.el8) has been submitted as an update to Fedora EPEL 8.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-1943b9d958

Comment 9 Fedora Update System 2024-08-28 13:26:42 UTC
FEDORA-EPEL-2024-95ef9a12e2 (libklvanc-1.6.0-1.el9) has been submitted as an update to Fedora EPEL 9.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-95ef9a12e2

Comment 10 Fedora Update System 2024-08-28 13:26:42 UTC
FEDORA-2024-2bb7d37cbe (libklvanc-1.6.0-1.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-2bb7d37cbe

Comment 11 Fedora Update System 2024-08-28 13:26:43 UTC
FEDORA-2024-4228bd8091 (libklvanc-1.6.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-4228bd8091

Comment 12 Fedora Update System 2024-08-29 01:59:26 UTC
FEDORA-2024-4228bd8091 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-4228bd8091 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-4228bd8091

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2024-08-29 02:38:43 UTC
FEDORA-2024-2bb7d37cbe has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-2bb7d37cbe \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-2bb7d37cbe

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2024-08-29 02:41:25 UTC
FEDORA-2024-829a38f356 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-829a38f356 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-829a38f356

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2024-08-29 02:48:13 UTC
FEDORA-EPEL-2024-1943b9d958 has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-1943b9d958

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 16 Fedora Update System 2024-08-29 02:52:10 UTC
FEDORA-EPEL-2024-95ef9a12e2 has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-95ef9a12e2

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 17 Fedora Update System 2024-09-06 00:41:21 UTC
FEDORA-EPEL-2024-95ef9a12e2 (libklvanc-1.6.0-1.el9) has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 18 Fedora Update System 2024-09-06 03:52:45 UTC
FEDORA-2024-2bb7d37cbe (libklvanc-1.6.0-1.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 19 Fedora Update System 2024-09-06 04:02:41 UTC
FEDORA-2024-829a38f356 (libklvanc-1.6.0-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 20 Fedora Update System 2024-09-06 04:42:16 UTC
FEDORA-EPEL-2024-1943b9d958 (libklvanc-1.6.0-1.el8) has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 21 Fedora Update System 2024-09-13 20:45:25 UTC
FEDORA-2024-4228bd8091 (libklvanc-1.6.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.