Bug 2307793 - Review Request: rust-cli-table - For printing tables on command line
Summary: Review Request: rust-cli-table - For printing tables on command line
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/cli-table
Whiteboard:
: 2294577 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-08-25 16:17 UTC by Fabio Valentini
Modified: 2024-09-08 14:08 UTC (History)
2 users (show)

Fixed In Version: rust-cli-table-0.4.9-1.fc42
Clone Of:
Environment:
Last Closed: 2024-09-08 14:08:19 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2024-08-25 16:17:11 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-cli-table.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-cli-table-0.4.9-1.fc40.src.rpm

Description:
A crate for printing tables on command line.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2024-08-25 16:17:14 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=122468608

Comment 2 Fabio Valentini 2024-08-25 16:33:46 UTC
*** Bug 2294577 has been marked as a duplicate of this bug. ***

Comment 3 Fedora Review Service 2024-08-25 17:11:23 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7941448
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2307793-rust-cli-table/fedora-rawhide-x86_64/07941448-rust-cli-table/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Neal Gompa 2024-09-01 18:28:59 UTC
This package says it does not build:

> Problem: nothing provides requested (crate(cli-table-derive/default) >= 0.4.6 with crate(cli-table-derive/default) < 0.5.0~)

Comment 5 Fabio Valentini 2024-09-01 18:29:43 UTC
[fedora-review-service-build]

Comment 6 Fedora Review Service 2024-09-01 18:34:52 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7960858
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2307793-rust-cli-table/fedora-rawhide-x86_64/07960858-rust-cli-table/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 7 Neal Gompa 2024-09-01 19:56:48 UTC
Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 8 Fabio Valentini 2024-09-08 13:36:25 UTC
Thank you for the review!

Comment 9 Fedora Admin user for bugzilla script actions 2024-09-08 13:37:09 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cli-table

Comment 10 Fabio Valentini 2024-09-08 14:08:19 UTC
Imported and built:
https://bodhi.fedoraproject.org/updates/FEDORA-2024-610c99ac2f


Note You need to log in before you can comment on or make changes to this bug.