Bug 230892 - Review Request: gtk-recordmydesktop - GUI Desktop session recorder with audio and video
Review Request: gtk-recordmydesktop - GUI Desktop session recorder with audio...
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: manuel wolfshant
Fedora Package Reviews List
Depends On: 230891
  Show dependency treegraph
Reported: 2007-03-04 05:46 EST by Sindre Pedersen Bjørdal
Modified: 2012-02-08 08:04 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2007-03-14 12:25:41 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
wolfy: fedora‑review+
limburgher: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description Sindre Pedersen Bjørdal 2007-03-04 05:46:56 EST
Spec URL: http://folk.ntnu.no/sindrb/packages/gtk-recordmydesktop.spec
SRPM URL: http://folk.ntnu.no/sindrb/packages/gtk-recordmydesktop-


Graphical frontend for the recordmydesktop desktop session recorder.

recordMyDesktop is a desktop session recorder for linux that attempts to be 
easy to use, yet also effective at it's primary task.
Comment 1 manuel wolfshant 2007-03-05 07:10:06 EST
MUSTFIXes: missing BR gettext,desktop-file-utils


- package meets naming guidelines
- package meets packaging guidelines
- license (GPL ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream, is latest available version, sha1sum
d1ba549ebff68157912b41e332941d84836d1fbb gtk-recordmydesktop-
- package compiles on devel (x86_64) [*]
- no unnecessary BR
- locales properly handled [*]
- not relocatable
- owns all files/directories that it creates, does not take ownership of foreign
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for separate -docs
- nothing in %doc affects runtime
- there are no scriptlets, no static code, no libtool/pkgconfig files

- the package compiles and builds into binary rpms on FC6 and rawhide (tested
only on x86_64); generated binary is a noarch so no issues should exist for x86 [*]
- the package runs as advertised [*]

[*] after adding the missing BRs

Sindre, please fix the spec adding the missing BRs and I'll reverify/approve the
package. As a sidenote, in the future I think it would be a good ideaif you
would test your packages using rpmlint and by bulding in mock before submitting
Comment 3 manuel wolfshant 2007-03-05 19:24:20 EST
Good, we are almost done. All problems mentioned have been solved. There is one
more left: please preserve the timestamps when installing. This can be done by
adding INSTALL="{__install} -c -p" either to the %configure line or to the "make
install" line.

Additional review bits not touched before
- python libs are properly installed (package follows the guidelines from
- program is a GUI; a desktop file is properly installed for it
- the desktop file respects packaging guidelines (no output from
desktop-file-validate fedora-gtk-recordmydesktop.desktop)

As I see no further blockers, the package is APPROVED. I'll trust you to fix 
preserving of timestamps before importing into CVS.
Comment 4 Sindre Pedersen Bjørdal 2007-03-06 02:42:27 EST
New Package CVS Request
Package Name: gtk-recordmydesktop
Short Description: GUI Desktop session recorder with audio and video
Owners: foolish@guezz.net
Branches: FC-5 FC-6

Comment 5 Andy Grover 2012-02-07 20:21:26 EST
Package Change Request
Package Name: gtk-recordmydesktop
New Branches: el5 el6
Owners: mbooth narasim grover
Comment 6 Jon Ciesla 2012-02-08 08:04:16 EST
Git done (by process-git-requests).

Note You need to log in before you can comment on or make changes to this bug.