Spec URL: http://folk.ntnu.no/sindrb/packages/gtk-recordmydesktop.spec SRPM URL: http://folk.ntnu.no/sindrb/packages/gtk-recordmydesktop-0.3.3.1-1.src.rpm Description: Graphical frontend for the recordmydesktop desktop session recorder. recordMyDesktop is a desktop session recorder for linux that attempts to be easy to use, yet also effective at it's primary task.
MUSTFIXes: missing BR gettext,desktop-file-utils GOOD - package meets naming guidelines - package meets packaging guidelines - license (GPL ) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream, is latest available version, sha1sum d1ba549ebff68157912b41e332941d84836d1fbb gtk-recordmydesktop-0.3.3.1.tar.g - package compiles on devel (x86_64) [*] - no unnecessary BR - locales properly handled [*] - not relocatable - owns all files/directories that it creates, does not take ownership of foreign files/directories - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for separate -docs - nothing in %doc affects runtime - there are no scriptlets, no static code, no libtool/pkgconfig files SHOULD: - the package compiles and builds into binary rpms on FC6 and rawhide (tested only on x86_64); generated binary is a noarch so no issues should exist for x86 [*] - the package runs as advertised [*] [*] after adding the missing BRs Sindre, please fix the spec adding the missing BRs and I'll reverify/approve the package. As a sidenote, in the future I think it would be a good ideaif you would test your packages using rpmlint and by bulding in mock before submitting them.
Updated SPEC: http://folk.ntnu.no/sindrb/packages/gtk-recordmydesktop.spec SRPM: http://folk.ntnu.no/sindrb/packages/gtk-recordmydesktop-0.3.3.1-2.src.rpm
Good, we are almost done. All problems mentioned have been solved. There is one more left: please preserve the timestamps when installing. This can be done by adding INSTALL="{__install} -c -p" either to the %configure line or to the "make install" line. Additional review bits not touched before - python libs are properly installed (package follows the guidelines from http://fedoraproject.org/wiki/Packaging/Python) - program is a GUI; a desktop file is properly installed for it - the desktop file respects packaging guidelines (no output from desktop-file-validate fedora-gtk-recordmydesktop.desktop) As I see no further blockers, the package is APPROVED. I'll trust you to fix preserving of timestamps before importing into CVS.
New Package CVS Request ======================= Package Name: gtk-recordmydesktop Short Description: GUI Desktop session recorder with audio and video Owners: foolish Branches: FC-5 FC-6 InitialCC:
Package Change Request ====================== Package Name: gtk-recordmydesktop New Branches: el5 el6 Owners: mbooth narasim grover
Git done (by process-git-requests).