Bug 2309661 - Review Request: egl-x11 - NVIDIA XLib and XCB EGL Platform Library
Summary: Review Request: egl-x11 - NVIDIA XLib and XCB EGL Platform Library
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-09-04 08:05 UTC by Simone Caronni
Modified: 2024-09-13 20:50 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-09-09 01:18:06 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Simone Caronni 2024-09-04 08:05:13 UTC
Spec URL: https://slaanesh.fedorapeople.org/egl-x11.spec
SRPM URL: https://slaanesh.fedorapeople.org/egl-x11-0.1-1.20240828git2be2296.fc40.src.rpm
Description:
This is an EGL platform library for the NVIDIA driver to support XWayland via
xlib (using EGL_KHR_platform_x11) or xcb (using EGL_EXT_platform_xcb).
Fedora Account System Username: slaanesh

Comment 1 Simone Caronni 2024-09-04 08:09:10 UTC
Requires eglexternalplatform-devel 1.2 just built for Fedora release. Will be pushed to updates along with this one.

Comment 2 Neal Gompa 2024-09-04 09:53:12 UTC
Review notes:

* Package follows Fedora packaging guidelines
* Package builds and installs
* Package licensing is correct
* Some issues from rpmlint:

You need to add to the spec to own/co-own as there are no owners:
%dir %{_datadir}/egl
%dir %{_datadir}/egl/egl_external_platform.d

This can be done on import. Otherwise this is good to go and...

PACKAGE APPROVED.

Comment 3 Simone Caronni 2024-09-04 10:21:06 UTC
(In reply to Neal Gompa from comment #2)
> You need to add to the spec to own/co-own as there are no owners:
> %dir %{_datadir}/egl
> %dir %{_datadir}/egl/egl_external_platform.d

Both directories are owned by libglvnd-egl. egl-gbm and egl-wayland (that all put files there) have this:

# Required for directory ownership
Requires:       libglvnd-egl%{?_isa}

I'll use the same. Thanks!

Comment 4 Fedora Admin user for bugzilla script actions 2024-09-04 10:23:02 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/egl-x11

Comment 5 Fedora Update System 2024-09-04 11:57:46 UTC
FEDORA-2024-d299ce11fa (eglexternalplatform-1.2-2.fc40 and egl-wayland-1.1.17-2.20240828git2d5ecff.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-d299ce11fa

Comment 6 Fedora Update System 2024-09-04 11:58:25 UTC
FEDORA-2024-654b1553f4 (eglexternalplatform-1.2-2.fc39 and egl-wayland-1.1.17-2.20240828git2d5ecff.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-654b1553f4

Comment 7 Fedora Update System 2024-09-04 11:58:54 UTC
FEDORA-2024-76ecf133ab (eglexternalplatform-1.2-2.fc41 and egl-wayland-1.1.17-2.20240828git2d5ecff.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-76ecf133ab

Comment 8 Fedora Update System 2024-09-05 01:49:10 UTC
FEDORA-2024-654b1553f4 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-654b1553f4`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-654b1553f4

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2024-09-05 03:01:32 UTC
FEDORA-2024-76ecf133ab has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-76ecf133ab`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-76ecf133ab

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2024-09-05 03:28:36 UTC
FEDORA-2024-d299ce11fa has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-d299ce11fa`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-d299ce11fa

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2024-09-09 01:18:06 UTC
FEDORA-2024-d299ce11fa (eglexternalplatform-1.2-2.fc40, egl-wayland-1.1.17-2.20240828git2d5ecff.fc40, and 1 more) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2024-09-13 01:36:16 UTC
FEDORA-2024-654b1553f4 (eglexternalplatform-1.2-2.fc39, egl-wayland-1.1.17-2.20240828git2d5ecff.fc39, and 1 more) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2024-09-13 20:50:21 UTC
FEDORA-2024-76ecf133ab (eglexternalplatform-1.2-2.fc41, egl-wayland-1.1.17-2.20240828git2d5ecff.fc41, and 1 more) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.