Spec URL: https://jussilehtola.fedorapeople.org/python-orderly-set.spec SRPM URL: https://jussilehtola.fedorapeople.org/python-orderly-set-5.2.2-1.fc40.src.rpm Fedora Account System Username: jussilehtola Description: Orderly Set is a package containing multiple implementations of Ordered Set. This package is required by newer versions of python-deepdiff.
[fedora-review-service-build]
Notes: 1) tests are failing (submitter has opened https://github.com/seperman/orderly-set/issues/7 to track); ignoring this 2) python-mock is deprecated and should not be used, see https://fedoraproject.org/wiki/Changes/DeprecatePythonMock for options and more info 3) license file should be included and marked as %license
Disabled tests till upstream fixes them. python-mock doesn't appear to be used by the project at all, even though setup.py lists is as a dependency - which is why pip2rpm put that in the spec. There is no license file in the sources, and adding extraneous license files is explicitly forbidden by Fedora policy. https://jussilehtola.fedorapeople.org/python-orderly-set.spec https://jussilehtola.fedorapeople.org/python-orderly-set-5.2.2-2.fc40.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/8091456 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2309681-python-orderly-set/fedora-rawhide-x86_64/08091456-python-orderly-set/fedora-review/review.txt Found issues: - python3-pytest7 is deprecated, you must not depend on it. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packages/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
> There is no license file in the sources, and adding extraneous license files is explicitly forbidden by Fedora policy. I see a license file here, which is what prompted my note after it was reported by rpmlint: https://github.com/seperman/orderly-set/blob/master/MIT-LICENSE APPROVED, once license file is added. Thanks for the review swap!
Thanks for the review! $ find . -name *LICENSE* $ The pypi source package referenced by pyp2rpm lacked the license file. Switching to a source tarball directly from GitHub fixed the issue. https://jussilehtola.fedorapeople.org/python-orderly-set.spec https://jussilehtola.fedorapeople.org/python-orderly-set-5.2.2-3.fc40.src.rpm
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-orderly-set
FEDORA-2024-5d1498a78f (python-orderly-set-5.2.2-3.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-5d1498a78f
FEDORA-2024-767e507cd9 (python-orderly-set-5.2.2-3.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-767e507cd9
FEDORA-2024-5d1498a78f has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-5d1498a78f \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-5d1498a78f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-767e507cd9 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-767e507cd9 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-767e507cd9 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-767e507cd9 (python-orderly-set-5.2.2-3.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-5d1498a78f (python-orderly-set-5.2.2-3.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.