Please branch and build python-flask for EPEL10
python-flask requires the following packages in epel10 to build: python-asgiref python-dotenv python-Pallets-Sphinx-Themes python-sphinxcontrib-log-cabinet python-sphinx-tabs If we turn off tests, we still need the following to build: python-Pallets-Sphinx-Themes python-sphinxcontrib-log-cabinet python-sphinx-tabs If we turn off docs also (which means we will not have python3-flask-doc) I think we can get it to build. We'll need to eventually turn them back on as dependency packages make it into epel10. What do people think? Should we wait, or should we build it without docs or tests?
(In reply to Troy Dawson from comment #1) > What do people think? I do not consider myself an expert here, and certainly not someone in the decision tree, but as the reporter, for almost all of my use of RHEL/EPEL (not just this package), I mostly care about runtime (and -devel where appropriate), not the various documentation(s). Tests during build are nice, and recommended by the packaging guidelines (but are SHOULD, not MUST, as I recall), but as all of these packages have run the tests in their Fedora builds, would seem to me to be to be deferrable (how often do the tests fail in an EPEL build if they succeeded in a Fedora build?)
(In reply to Gary Buhrmaster from comment #2) > […] Tests during build are > nice, and recommended by the packaging guidelines (but are SHOULD, not MUST, > as I recall), but as all of these packages have run the tests in their > Fedora builds, would seem to me to be to be deferrable (how often do the > tests fail in an EPEL build if they succeeded in a Fedora build?) I agree that disabling tests in EPEL can sometimes be justifiable, but I would claim that the answer to this question is actually “reasonably often,” since test failures are often triggered by unexpected behavior changes in dependencies, and EPEL packages usually end up with a different combination of dependencies that the Fedora releases they were branched from – especially after some time has passed.
Trying a fedpkg mockbuild from the rawhide content right now, I get: No matching package to install: 'python3dist(pallets-sphinx-themes)' No matching package to install: 'python3dist(python-dotenv)' No matching package to install: 'python3dist(sphinx-tabs)' No matching package to install: 'python3dist(sphinxcontrib-log-cabinet)'
I tried a local mock build assuming python-dotenv, bug 2330576 (and its dependency python-sh, bug 2330578) are branched, and https://src.fedoraproject.org/rpms/python-flask/pull-request/16 or something similar is applied to winnow out the Sphinx dependencies. Then I get this: No matching package to install: 'python3dist(blinker) >= 1.9' No matching package to install: 'python3dist(itsdangerous) >= 2.2' So both python-blinker and python-itsdangerous would also need to be branched and built.
So there is an agreement on dropping the doc dependencies ? Shall I remove the dependant bug to ask for python-pallets-sphinx-themes ?
(In reply to Romain Geissler from comment #6) > So there is an agreement on dropping the doc dependencies ? Shall I remove > the dependant bug to ask for python-pallets-sphinx-themes ? No, the PR was just a suggestion on my part, and I don’t normally contribute to maintaining python-flask. Maybe the usual maintainers are extremely committed to branching with documentation – I have no idea. Might as well keep the bug open until we get some feedback.
Ok so I keep it open for now (but won't try to open other doc related package request, we still miss sphinx-tabs and sphinxcontrib-log-cabinet). Locally I have built all other packages, used your pull request, and was able to build a local python3-flask package.
I'm good without the docs. If the dependencies make it into epel10, then we can add them at a later date.
FEDORA-EPEL-2024-20f6407508 (python-flask-3.1.0-2.el10_0) has been submitted as an update to Fedora EPEL 10.0. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-20f6407508
FEDORA-EPEL-2024-20f6407508 has been pushed to the Fedora EPEL 10.0 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-20f6407508 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2024-20f6407508 (python-flask-3.1.0-2.el10_0) has been pushed to the Fedora EPEL 10.0 stable repository. If problem still persists, please make note of it in this bug report.