Spec URL: https://raw.githubusercontent.com/tylerfanelli/rust-criterion-f42-candidate/main/rust-criterion.spec SRPM URL: https://github.com/tylerfanelli/rust-criterion-f42-candidate/raw/main/rust-criterion-0.5.1-1.fc42.src.rpm Description: Statistics-driven benchmarking library for Rust Fedora Account System Username: tfanelli
Welcome to this (apparently?) initiation ritual for Rust packagers! This is the fourth or fifth (?) time it was submitted for review :D - criterion is a benchmarking library. - benchmarks are neither compiled nor run during package builds. - you can just patch out the dev-dependency with "rust2rpm -p". Unless you are packaging a tool that uses criterion (or other benchmarking libraries) at runtime, there's no reason to have this in Fedora.
Copr build: https://copr.fedorainfracloud.org/coprs/build/7997592 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2310677-rust-criterion/fedora-rawhide-x86_64/07997592-rust-criterion/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
(In reply to Fabio Valentini from comment #1) > Welcome to this (apparently?) initiation ritual for Rust packagers! > This is the fourth or fifth (?) time it was submitted for review :D > > - criterion is a benchmarking library. > - benchmarks are neither compiled nor run during package builds. > - you can just patch out the dev-dependency with "rust2rpm -p". > > Unless you are packaging a tool that uses criterion (or other benchmarking > libraries) at runtime, there's no reason to have this in Fedora. And with that, I'll close this issue as not needed. Thanks for clearing this up :)