Bug 2310713 - fedpkg clog produces multiple duplicate line
Summary: fedpkg clog produces multiple duplicate line
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: fedpkg
Version: 41
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Ondřej Nosek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 2332089 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-09-08 13:22 UTC by Mamoru TASAKA
Modified: 2025-03-15 00:39 UTC (History)
12 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-03-05 01:15:04 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Mamoru TASAKA 2024-09-08 13:22:55 UTC
It seems that `$ fedpkg clog` produces multiple duplicate lines on F-41

F-40 I don't see this issue.

Reproducible: Always

Steps to Reproduce:
1. $ fedpkg co -a --branches deluge
2. $ cd deluge/f40
3. $ fedpkg clog
4. $ cat clog
Actual Results:  
On Fedora 41 (fedpkg-1.45-3.fc41.noarch)

$ cat clog
Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild

Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild
Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild
Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild
Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild
Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild
Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild


Expected Results:  
On Fedora 40 (fedpkg-1.45-2.fc40.noarch):

$ cat clog
Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild

Comment 2 Zdenek Dohnal 2024-11-25 15:22:12 UTC
I hit the same issue :( .

Comment 3 Richard W.M. Jones 2024-12-12 15:30:50 UTC
*** Bug 2332089 has been marked as a duplicate of this bug. ***

Comment 4 Richard W.M. Jones 2024-12-12 15:31:23 UTC
Also fedpkg commit -c & fedpkg update.

Comment 5 Remi Collet 2024-12-18 06:21:27 UTC
Same issue

Comment 6 Ondřej Nosek 2025-01-21 05:03:32 UTC
I guess, the issue comes from rpm.
when commit -c is run, the clog method is executing:
`rpm -q --qf '%{CHANGELOGTEXT}\n' --undefine '_changelog_trimtime' --specfile <SPECFILE>`
The duplication occurs in Fedora 41, where rpm-4.20 is installed.
On Fedora 40 with rpm-4.19 the behaviour is unchanged.

Comment 7 Panu Matilainen 2025-01-21 07:21:22 UTC
That rpm query is buggy, %{CHANGELOGTEXT} is an array and so needs to be queried as such. See https://rpm-software-management.github.io/rpm/manual/queryformat.html for whole story but for TLDR version: "--qf '[%{CHANGELOGTEXT}\n]'" produces all the changelog entry texts with no other info, if that's the intention.

On a mostly unrelated note, for any spec queries you'd be better off using "rpmspec" directly. That's what "rpm -q <spec>" ends up executing anyhow but using it directly gives you direct access to things "rpm -q <spec>" cannot do.

Comment 8 Parag Nemade 2025-01-22 02:59:38 UTC
Recently I also noticed the commit log is appearing multiple times in 'clog` file when you run 'fedpkg clog'.

Comment 9 Ondřej Nosek 2025-01-22 03:05:44 UTC
The fix is being prepared:
https://pagure.io/rpkg/pull-request/729

Comment 10 Fedora Update System 2025-03-03 23:59:06 UTC
FEDORA-2025-1ef7283bb9 (rpkg-1.67-7.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-1ef7283bb9

Comment 11 Fedora Update System 2025-03-03 23:59:07 UTC
FEDORA-2025-6d5589b0ee (rpkg-1.67-7.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-6d5589b0ee

Comment 12 Fedora Update System 2025-03-03 23:59:08 UTC
FEDORA-2025-a771ea5819 (rpkg-1.67-7.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-a771ea5819

Comment 13 Fedora Update System 2025-03-03 23:59:08 UTC
FEDORA-EPEL-2025-675f00561c (rpkg-1.67-7.el8) has been submitted as an update to Fedora EPEL 8.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-675f00561c

Comment 14 Fedora Update System 2025-03-03 23:59:08 UTC
FEDORA-EPEL-2025-916d2b6a29 (rpkg-1.67-7.el10_1) has been submitted as an update to Fedora EPEL 10.1.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-916d2b6a29

Comment 15 Fedora Update System 2025-03-04 01:14:16 UTC
FEDORA-2025-a771ea5819 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-a771ea5819`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-a771ea5819

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 16 Fedora Update System 2025-03-04 01:44:46 UTC
FEDORA-2025-1ef7283bb9 has been pushed to the Fedora 42 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-1ef7283bb9`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-1ef7283bb9

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 17 Fedora Update System 2025-03-04 02:15:14 UTC
FEDORA-2025-6d5589b0ee has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-6d5589b0ee`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-6d5589b0ee

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 18 Fedora Update System 2025-03-04 02:45:46 UTC
FEDORA-EPEL-2025-916d2b6a29 has been pushed to the Fedora EPEL 10.1 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-916d2b6a29

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 19 Fedora Update System 2025-03-04 02:47:25 UTC
FEDORA-EPEL-2025-45e700672a has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-45e700672a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 20 Fedora Update System 2025-03-04 02:53:59 UTC
FEDORA-EPEL-2025-675f00561c has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-675f00561c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 21 Fedora Update System 2025-03-05 01:15:04 UTC
FEDORA-2025-a771ea5819 (rpkg-1.67-7.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 22 Fedora Update System 2025-03-12 02:08:55 UTC
FEDORA-2025-6d5589b0ee (rpkg-1.67-7.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 23 Fedora Update System 2025-03-12 02:58:52 UTC
FEDORA-EPEL-2025-916d2b6a29 (rpkg-1.67-7.el10_1) has been pushed to the Fedora EPEL 10.1 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 24 Fedora Update System 2025-03-12 03:20:27 UTC
FEDORA-EPEL-2025-45e700672a (rpkg-1.67-7.el9) has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 25 Fedora Update System 2025-03-12 03:30:53 UTC
FEDORA-EPEL-2025-675f00561c (rpkg-1.67-7.el8) has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 26 Fedora Update System 2025-03-15 00:39:03 UTC
FEDORA-2025-1ef7283bb9 (rpkg-1.67-7.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.