Bug 2310821 - rubygem-rugged FTBFS due to libgit2 1.8.0 constness change which is already reverted
Summary: rubygem-rugged FTBFS due to libgit2 1.8.0 constness change which is already r...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: libgit2
Version: 41
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Pete Walter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-09-09 10:23 UTC by Mamoru TASAKA
Modified: 2024-10-04 00:16 UTC (History)
2 users (show)

Fixed In Version: libgit2-1.8.2~rc1-1.fc42 libgit2-1.8.2~rc1-1.fc41
Clone Of:
Environment:
Last Closed: 2024-10-02 07:20:43 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Mamoru TASAKA 2024-09-09 10:23:16 UTC
rubygem-rugged (which depends on libgit2) FTBFS with recent
libgit2 update: 1.7.2->1.8.1:

```
rugged_commit.c: In function ‘rb_git_commit_create’:
rugged_commit.c:567:28: error: passing argument 10 of ‘git_commit_create’ from incompatible pointer type [-Wincompatible-pointer-types]
  567 |                 commit_data.parents);
      |                 ~~~~~~~~~~~^~~~~~~~
      |                            |
      |                            const git_commit **
In file included from /usr/include/git2/repository.h:14,
                 from /usr/include/git2/annotated_commit.h:11,
                 from /usr/include/git2.h:11,
                 from rugged.h:26,
                 from rugged_commit.c:8:
/usr/include/git2/commit.h:369:28: note: expected ‘git_commit * const*’ but argument is of type ‘const git_commit **’
  369 |         git_commit * const parents[]);
```

This is due to libgit2 this commit:
https://github.com/libgit2/libgit2/commit/cf19ddc52227f4ec2efd4c0a84aa5d2362f0ffc7

and the above is reverted in 1.8.2-rc1:
https://github.com/libgit2/libgit2/commit/49d3fadfca4ce8e7a643525eb301a2d45956641e

Would you backport the above fix on F41 and F42?

Reproducible: Always

Comment 1 Mamoru TASAKA 2024-09-09 10:28:28 UTC
Forgot rubygem-rugged koschei status link:

https://koschei.fedoraproject.org/package/rubygem-rugged

Comment 2 Fedora Update System 2024-10-02 06:53:26 UTC
FEDORA-2024-64d4d32636 (gnome-builder-47.1-2.fc42, libgit2-1.8.2~rc1-1.fc42, and 3 more) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-64d4d32636

Comment 3 Fedora Update System 2024-10-02 06:53:55 UTC
FEDORA-2024-223f514840 (gnome-builder-47.1-2.fc41, libgit2-1.8.2~rc1-1.fc41, and 3 more) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-223f514840

Comment 4 Fedora Update System 2024-10-02 07:20:43 UTC
FEDORA-2024-64d4d32636 (gnome-builder-47.1-2.fc42, libgit2-1.8.2~rc1-1.fc42, and 3 more) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 5 Fedora Update System 2024-10-03 02:02:57 UTC
FEDORA-2024-223f514840 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-223f514840`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-223f514840

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2024-10-04 00:16:09 UTC
FEDORA-2024-223f514840 (gnome-builder-47.1-2.fc41, libgit2-1.8.2~rc1-1.fc41, and 3 more) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.