Bug 2310847 - Review Request: perl-Auth-Yubikey_WebClient - Authenticating the Yubikey against the Yubico Web API
Summary: Review Request: perl-Auth-Yubikey_WebClient - Authenticating the Yubikey agai...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL: http://metacpan.org/dist/Auth-Yubikey...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-09-09 13:44 UTC by Xavier Bachelot
Modified: 2024-09-26 03:51 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-09-26 00:17:56 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Xavier Bachelot 2024-09-09 13:44:30 UTC
Spec URL: https://www.bachelot.org/fedora/SPECS/perl-Auth-Yubikey_WebClient.spec
SRPM URL: https://www.bachelot.org/fedora/SRPMS/perl-Auth-Yubikey_WebClient-4.02-1.fc42.src.rpm
Description: Authenticate against the Yubico server via the Web API in Perl.
Fedora Account System Username: xavierb

Comment 1 Fedora Review Service 2024-09-12 00:19:51 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8010396
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2310847-perl-auth-yubikey_webclient/fedora-rawhide-x86_64/08010396-perl-Auth-Yubikey_WebClient/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Jitka Plesnikova 2024-09-17 15:28:10 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires are ok
FIX: Add build-require 'coreutils' it is needed for %{_fixperms}

$ rpm -qp --requires perl-Auth-Yubikey_WebClient-4.02-1.fc42.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(Digest::HMAC_SHA1)
      1 perl-libs
      1 perl(LWP::UserAgent)
      1 perl(MIME::Base64)
      1 perl(strict)
      1 perl(URI::Escape)
      1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-Auth-Yubikey_WebClient-4.02-1.fc42.noarch.rpm | sort | uniq -c
      1 perl(Auth::Yubikey_WebClient) = 4.02
      1 perl-Auth-Yubikey_WebClient = 4.02-1.fc42
Binary provides are Ok.

$ rpmlint ./perl-Auth-Yubikey_WebClient*
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3
perl-Auth-Yubikey_WebClient.spec:33: W: macro-in-comment %{version}
perl-Auth-Yubikey_WebClient.spec:33: W: macro-in-comment %{version}
 2 packages and 1 specfiles checked; 0 errors, 2 warnings, 8 filtered, 0 badness; has taken 0.3 s
Rpmlint 
FIX: the warning 'macro-in-comment %{version}'

Otherwise the package is in line with Fedora and Perl packaging guide lines.
Please correct all 'FIX' items.

Resolution:
Approved

Comment 3 Fedora Admin user for bugzilla script actions 2024-09-17 15:58:07 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Auth-Yubikey_WebClient

Comment 4 Xavier Bachelot 2024-09-17 16:38:07 UTC
I've fixed the 2 items before importing.
Thanks for the review Jitka :-)

Comment 5 Fedora Update System 2024-09-17 16:51:57 UTC
FEDORA-2024-9b4bca61b8 (perl-Auth-Yubikey_WebClient-4.02-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-9b4bca61b8

Comment 6 Fedora Update System 2024-09-17 16:51:57 UTC
FEDORA-2024-e730a4f319 (perl-Auth-Yubikey_WebClient-4.02-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-e730a4f319

Comment 7 Fedora Update System 2024-09-17 16:52:00 UTC
FEDORA-2024-0fcfb8415f (perl-Auth-Yubikey_WebClient-4.02-1.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-0fcfb8415f

Comment 8 Fedora Update System 2024-09-17 16:52:01 UTC
FEDORA-EPEL-2024-590850e1cd (perl-Auth-Yubikey_WebClient-4.02-1.el9) has been submitted as an update to Fedora EPEL 9.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-590850e1cd

Comment 9 Fedora Update System 2024-09-17 16:52:02 UTC
FEDORA-EPEL-2024-565aeaa35c (perl-Auth-Yubikey_WebClient-4.02-1.el8) has been submitted as an update to Fedora EPEL 8.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-565aeaa35c

Comment 10 Fedora Update System 2024-09-18 16:53:24 UTC
FEDORA-2024-9b4bca61b8 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-9b4bca61b8 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-9b4bca61b8

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2024-09-18 17:20:06 UTC
FEDORA-2024-e730a4f319 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-e730a4f319 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-e730a4f319

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2024-09-18 17:27:57 UTC
FEDORA-EPEL-2024-590850e1cd has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-590850e1cd

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2024-09-18 17:34:44 UTC
FEDORA-EPEL-2024-565aeaa35c has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-565aeaa35c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2024-09-18 17:54:47 UTC
FEDORA-2024-0fcfb8415f has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-0fcfb8415f \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-0fcfb8415f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2024-09-26 00:17:56 UTC
FEDORA-2024-9b4bca61b8 (perl-Auth-Yubikey_WebClient-4.02-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 16 Fedora Update System 2024-09-26 02:30:46 UTC
FEDORA-2024-0fcfb8415f (perl-Auth-Yubikey_WebClient-4.02-1.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 17 Fedora Update System 2024-09-26 02:44:51 UTC
FEDORA-2024-e730a4f319 (perl-Auth-Yubikey_WebClient-4.02-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 18 Fedora Update System 2024-09-26 03:32:20 UTC
FEDORA-EPEL-2024-590850e1cd (perl-Auth-Yubikey_WebClient-4.02-1.el9) has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 19 Fedora Update System 2024-09-26 03:51:48 UTC
FEDORA-EPEL-2024-565aeaa35c (perl-Auth-Yubikey_WebClient-4.02-1.el8) has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.