Spec URL: http://folk.ntnu.no/sindrb/packages/nrg2iso.spec SRPM URL: http://folk.ntnu.no/sindrb/packages/nrg2iso-0.4-1.src.rpm Description: Nrg2Iso is a linux utiity for converting CD (or DVD) image generated by Nero Burning Rom to ISO format.
The version you have submitted ignores $RPM_OPT_FLAGS. Please find attached two patches which fix that.
Created attachment 149392 [details] patch which makes Makefile honor $RPM_OPT_FLAGS
Created attachment 149393 [details] spec file patch fixes a typo and adds $RPM_OPT_FLAGS into equation
Updated Spec URL: http://folk.ntnu.no/sindrb/packages/nrg2iso.spec SRPM URL: http://folk.ntnu.no/sindrb/packages/nrg2iso-0.4-2.src.rpm
GOOD - rpmlint is silent on source and binary rpm - package meets naming guidelines - package meets packaging guidelines - license (GPL ) OK, text in %doc (as gpl.txt), matches source - spec file legible, in am. english - source matches upstream, is latest version, sha1sum 26dfa9b489c9165dbc578ef3fddf6e491349df12 nrg2iso-0.4.tar.gz - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all files/directories that it creates, does not take ownership of foreign files/directories - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs (no docs at all but the GPL license and a very very short Changelog) - nothing in %doc affects runtime - not a GUI so no need for .desktop file - no libtool,pkgconfig,static files - no scriptlets - no need for separate -devel SHOULD - builds fine in mock for Centos-4/x86, Fedora 6 and devel/x86 - runs OK in Centos 4 and FC6 Package APPROVED
New Package CVS Request ======================= Package Name: nrg2iso Short Description: Convert Nero Burning Rom image files into ISO Owners: foolish Branches: FC-5 FC-6 InitialCC:
Sindre, I suggest asking for a branch for EPEL-4, too, if you feel like maintaining it over there. If this a problem for you, I will be glad to take it over (or co-maintain it with you) for EPEL.
Sure I can maintain it for EPEL-4: Updated CVS Request: New Package CVS Request ======================= Package Name: nrg2iso Short Description: Convert Nero Burning Rom image files into ISO Owners: foolish Branches: FC-5 FC-6 EPEL-4 InitialCC: