Bug 2312451 - Review Request: rust-vfs - Virtual filesystem for Rust
Summary: Review Request: rust-vfs - Virtual filesystem for Rust
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/vfs
Whiteboard:
Depends On:
Blocks: FE-DEADREVIEW 2312452
TreeView+ depends on / blocked
 
Reported: 2024-09-15 16:11 UTC by Davide Cavalca
Modified: 2025-04-29 00:45 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-04-29 00:45:38 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Davide Cavalca 2024-09-15 16:11:11 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-vfs/rust-vfs.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-vfs/rust-vfs-0.12.0-1.fc42.src.rpm

Description:
A virtual filesystem for Rust.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2024-09-15 16:11:14 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=123441040

Comment 2 Davide Cavalca 2024-09-15 16:14:01 UTC
$ cat rust2rpm.toml 
[package]
cargo-toml-patch-comments = [
  "Bump uuid to 1",
  "Relax rust-embed version pin",
]

Comment 3 Fedora Review Service 2024-09-16 08:47:51 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8023385
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2312451-rust-vfs/fedora-rawhide-x86_64/08023385-rust-vfs/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Fabio Valentini 2024-09-21 15:28:36 UTC
Package looks pretty good to me - but can you exclude the `test` directory from the packaged files?
It's just used for tests, as far as I can tell, and the files inside aren't useful for other things.

If possible, please also submit your Cargo.toml changes upstream.
uuid 0.8 is pretty old at this point, I don't think anything should still use that (especially if porting is as simple as just bumping the dependency).

Comment 5 Fabio Valentini 2025-03-29 22:21:12 UTC
Are you still interested in this package?

Comment 6 Package Review 2025-04-29 00:45:38 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.


Note You need to log in before you can comment on or make changes to this bug.