Bug 2312453 - Incorrect check for static configs with bootupd leads to no /boot/loader/grub.cfg after reboot
Summary: Incorrect check for static configs with bootupd leads to no /boot/loader/grub...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: ostree
Version: 41
Hardware: All
OS: Linux
high
high
Target Milestone: ---
Assignee: Timothée Ravier
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2150982
TreeView+ depends on / blocked
 
Reported: 2024-09-15 16:43 UTC by Timothée Ravier
Modified: 2024-09-18 01:54 UTC (History)
13 users (show)

Fixed In Version: ostree-2024.7-3.fc42 ostree-2024.7-3.fc41
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-09-16 19:08:22 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker FC-1301 0 None None None 2024-09-15 16:43:59 UTC

Description Timothée Ravier 2024-09-15 16:43:03 UTC
https://github.com/ostreedev/ostree/pull/3205 added a check that looks for `"static-configs"` in bootupd state file: `/boot/bootupd-state.json`.

Unfortunately, bootup will always write this entry (even if null) since https://github.com/coreos/bootupd/pull/609.

Thus old systems that are still using dynamic GRUB configs and that are updated with bootupd will stop generating GRUB configs and will thus fail to boot.

See initial report: https://github.com/fedora-silverblue/issue-tracker/issues/595
Ostree upstream issue: https://github.com/ostreedev/ostree/issues/3295
Pull request: https://github.com/ostreedev/ostree/pull/3300

Reproducible: Always

Steps to Reproduce:
1. Install Fedora Atomic 40
2. Rebase to Fedora Atomic 41
3. Update the bootloader using `bootupctl update`
4. Create a new deployment, for example by installing a package: `rpm-ostree install strace`
5. Finalize the staged ostree deployment early (normally happens on shutdown): `ostree admin finalize-staged`
Actual Results:  
No GRUB config in `/boot/loader/grub.cfg`

Expected Results:  
GRUB config in `/boot/loader/grub.cfg`

Comment 1 Timothée Ravier 2024-09-15 16:45:52 UTC
Sorry, incorrectly filed that for cockpit-ostree by mistake.

Comment 2 Timothée Ravier 2024-09-15 16:56:59 UTC
https://src.fedoraproject.org/rpms/ostree/pull-request/39

Comment 3 Fedora Update System 2024-09-16 14:14:31 UTC
FEDORA-2024-99cef23966 (ostree-2024.7-3.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-99cef23966

Comment 4 Fedora Update System 2024-09-16 14:27:09 UTC
FEDORA-2024-3945fdf385 (ostree-2024.7-3.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-3945fdf385

Comment 5 Fedora Update System 2024-09-16 19:08:22 UTC
FEDORA-2024-99cef23966 (ostree-2024.7-3.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 6 Fedora Update System 2024-09-17 03:07:58 UTC
FEDORA-2024-3945fdf385 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-3945fdf385`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-3945fdf385

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2024-09-18 01:54:39 UTC
FEDORA-2024-3945fdf385 (ostree-2024.7-3.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.