Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://music.fedorapeople.org/python-inline-snapshot.spec SRPM URL: https://music.fedorapeople.org/python-inline-snapshot-0.13.0-1.fc40.src.rpm Description: Golden master/snapshot/approval testing library which puts the values right into your source code. Fedora Account System Username: music This is a new test dependency for python-fastapi.
Copr build: https://copr.fedorainfracloud.org/coprs/build/8030558 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2313221-python-inline-snapshot/fedora-rawhide-x86_64/08030558-python-inline-snapshot/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I revised the tomllib PR to make upstream’s typecheckers pass. Here’s a version with an updated (but basically equivalent) patch: New Spec URL: https://music.fedorapeople.org/20240918/python-inline-snapshot.spec New SRPM URL: https://music.fedorapeople.org/20240918/python-inline-snapshot-0.13.0-1.fc40.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/8031204 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2313221-python-inline-snapshot/fedora-rawhide-x86_64/08031204-python-inline-snapshot/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Notes ====== 1. tomcli get pyproject.toml -F newline-list tool.hatch.envs.hatch-test.extra-dependencies | grep -v -e pyright -e mypy (or tomcli-get if you prefer) is the tomcli command to query for the test dependencies if you prefer that to manually maintaining version constraints. Otherwise, your current approach is fine. 2. Please update to the latest version. See below. Maxwell's Python Package Review Template ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated - [x] The License tag reflects the package contents and uses the correct identifiers. - [x] The license text is included and marked with %license. NOTE: Included in dist-info - [x] The package builds successfully in mock. - [x] The package is installable (checked by mock --postinstall). - [x] There are no relevant rpmlint errors. - [x] The package runs tests in %check. - [!] The latest version is packaged or packaging an earlier version is justified. Please update to 0.13.1 on import. Then you can also drop your patch. - [x] The packager considers avoiding confusing `%foo_name` macros. (Not a blocker) - [x] Libraries: The package name has a `python3-` prefix and uses the canonical project name - [x] The pyproject macros are used. - [x] There are no bundled libraries. - [x] The package complies with the Python and general Packaging Guidelines. Package approved, but don't forget to update to the latest version. On import, don't forget to add the package to release-monitoring.org. You can give @python-packagers-sig `commit` if you wish` Thanks!
If you don't mind taking a look at https://bugzilla.redhat.com/show_bug.cgi?id=2275006, also, that'd be great.
Thank you for the review! (In reply to Maxwell G from comment #4) > 1. > > tomcli get pyproject.toml -F newline-list > tool.hatch.envs.hatch-test.extra-dependencies | grep -v -e pyright -e mypy > > (or tomcli-get if you prefer) is the tomcli command to query for the > test dependencies if you prefer that to manually maintaining version > constraints. Otherwise, your current approach is fine. Hmm, that might be a worthwhile change. I tend to resort to listing test dependencies manually once there is a lot I need to filter out, but here there are only two things, so unless upstream starts adding a bunch of coverage and linting tools, it might be worth using the suggested approach. > > 2. Please update to the latest version. See below. Will do! This will be easy, since the only change was that the tomllib PR I was carrying as a patch was merged. (In reply to Maxwell G from comment #5) > If you don't mind taking a look at > https://bugzilla.redhat.com/show_bug.cgi?id=2275006, also, that'd be great. I will take a look at this within the next few days.
https://release-monitoring.org/project/270611/
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-inline-snapshot
FEDORA-2024-9ebd352aed (python-inline-snapshot-0.13.1-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-9ebd352aed
FEDORA-2024-9ebd352aed (python-inline-snapshot-0.13.1-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-7e3087125a (python-fastapi-0.114.2-2.fc41, python-inline-snapshot-0.13.3-1.fc41, and 3 more) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-7e3087125a
FEDORA-2024-7e3087125a has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-7e3087125a` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-7e3087125a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-7e3087125a (python-fastapi-0.115.0-1.fc41, python-inline-snapshot-0.13.3-1.fc41, and 3 more) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.