Bug 2313340 - Review Request: rust-rocket_codegen - Procedural macros for the Rocket web framework
Summary: Review Request: rust-rocket_codegen - Procedural macros for the Rocket web fr...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/rocket_codegen
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-09-18 15:12 UTC by wojnilowicz
Modified: 2024-09-19 15:26 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-09-19 15:26:42 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description wojnilowicz 2024-09-18 15:12:44 UTC
Spec URL: https://wojnilowicz.fedorapeople.org/rust-rocket_codegen.spec
SRPM URL: https://wojnilowicz.fedorapeople.org/rust-rocket_codegen-0.5.1-1.fc39.src.rpm

rust2rpm.toml: https://wojnilowicz.fedorapeople.org/rocket_codegen/rust2rpm.toml

Description:
Procedural macros for the Rocket web framework.

Fedora Account System Username: wojnilowicz

I plan on packaging https://github.com/ActivityWatch/aw-server-rust and rocket_codegen package is in its requirements chain. The chain is as follows: aw-server-rust->rocket->rocket_codegen.

Comment 1 Fedora Review Service 2024-09-18 15:26:22 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8031522
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2313340-rust-rocket_codegen/fedora-rawhide-x86_64/08031522-rust-rocket_codegen/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2024-09-19 11:34:24 UTC
> can't find crate for `rocket`

This usually means that tests can only be compiled + run inside the upstream git repository / cargo workspace due to path-based dependencies. In this case, it would introduce a dependency loop too, so it's fine to keep this disabled. But it would be good to include a better documentation than just pasting the error message verbatim.

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
🫤 test suite is run and all unit tests pass (disabled with justification)
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 3 Fedora Admin user for bugzilla script actions 2024-09-19 14:26:25 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-rocket_codegen

Comment 4 Fedora Update System 2024-09-19 14:46:04 UTC
FEDORA-2024-a547572a11 (rust-rocket_codegen-0.5.1-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-a547572a11

Comment 5 wojnilowicz 2024-09-19 14:53:31 UTC
(In reply to Fabio Valentini from comment #2)
> > can't find crate for `rocket`
> 
> This usually means that tests can only be compiled + run inside the upstream
> git repository / cargo workspace due to path-based dependencies. In this
> case, it would introduce a dependency loop too, so it's fine to keep this
> disabled. But it would be good to include a better documentation than just
> pasting the error message verbatim.

Thanks. I rephrased the cause in the final package to be more informative.

Comment 6 Fedora Update System 2024-09-19 15:26:42 UTC
FEDORA-2024-a547572a11 (rust-rocket_codegen-0.5.1-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.