Copr build:
https://copr.fedorainfracloud.org/coprs/build/8042161
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2313507-xapian-haystack/fedora-rawhide-x86_64/08042161-python-xapian-haystack/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Is anything else needed from me on this? As the review link throws 404 for me and the build succeeded.

Sorry, didn't end up having time to do this during the conference last week. Not sure what happens to the COPR-generated reviews, it probably failed to run (but the build itself did finish)

There are some issues

Issues:
=======
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/

Problem: conflicting requests
  - nothing provides python3dist(xapian) >= 1.4 needed by python3-xapian-haystack-3.1.0-1.fc42.noarch from @commandline

Looks like python3-xapian (from xapian-bindings) is not properly packaged? It does not provide the expected 'python3dist(MODNAME)' dependency

michel in ~/src/fedora 
⬢ [f40-packaging] ❯ fedrq pkgs '*xapian*'
python3-xapian-1.4.26-2.fc42.x86_64
tcl-xapian-1.4.26-2.fc42.x86_64
xapian-bindings-1.4.26-2.fc42.src
xapian-bindings-1.4.26-2.fc42.x86_64
xapian-bindings-ruby-1.4.26-2.fc42.x86_64
xapian-core-1.4.26-1.fc42.i686
xapian-core-1.4.26-1.fc42.src
xapian-core-1.4.26-1.fc42.x86_64
xapian-core-devel-1.4.26-1.fc42.i686
xapian-core-devel-1.4.26-1.fc42.x86_64
xapian-core-libs-1.4.26-1.fc42.i686
xapian-core-libs-1.4.26-1.fc42.x86_64

michel in ~/src/fedora took 17s 
⬢ [f40-packaging] ❯ fedrq pkgs python3-xapian -F provides
python-xapian = 1.4.26-2.fc42
python3-xapian = 1.4.26-2.fc42
python3-xapian(x86-64) = 1.4.26-2.fc42
python3.13-xapian = 1.4.26-2.fc42




- The License field must be a valid SPDX expression.
  Note: Not a valid SPDX expression 'GPL2'.
  See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1

=> Is this GPL-2.0-only or GPL-2.0-or-later ?

- Spec file name must match the spec package %{name}, in the format
  %{name}.spec.
  Note: xapian-haystack.spec should be python-xapian-haystack.spec
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/#_spec_file_naming
=> as the issue says

In COPR, I just tried to build it for EPEL9. I will look at building it for rawhide as well.

Will address all the other issues.

I fixed the license and spec file name issues. I built the package for F42 and encountered the install issue. I opened a bug on the xapian-bindings issue about this https://bugzilla.redhat.com/show_bug.cgi?id=2314414

I was able to solve https://bugzilla.redhat.com/show_bug.cgi?id=2314414 in latest build of python3-xapian-haystack https://copr.fedorainfracloud.org/coprs/zlopez/xapian-haystack/build/8105726/.

So everything should be now fixed. Do I get a green for the package now?

Taking over this review as Michel is on vacation.

Spec review notes:

> Source0:        %{url}/archive/refs/tags/%{version}.tar.gz

This should be "%{url}/archive/%{version}/xapian-haystack-%{version}.tar.gz"

> %{python3_sitelib}/__pycache__/*
> %{python3_sitelib}/xapian_backend.py

This should be replaced with "%pycached %{python3_sitelib}/xapian_backend.py"

The spec file also needs to be renamed to python-xapian-haystack.spec.

You should also consider modernizing this package to follow the current Python packaging guidelines, which are supported on EPEL 9 and above.

Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/

After some struggling with the packaging guidelines I was able to finally get it to build.

Here is the new spec file: https://download.copr.fedorainfracloud.org/results/zlopez/xapian-haystack/fedora-rawhide-x86_64/08118458-python-xapian-haystack/python-xapian-haystack.spec

And here is the successful build on copr: https://copr.fedorainfracloud.org/coprs/zlopez/xapian-haystack/build/8118458/

Let me know if I missed something.

> BuildRequires:  python3dist(django) >= 3.2
> BuildRequires:  python3dist(django-haystack) >= 2.8
> BuildRequires:  python3dist(filelock) >= 3.4
> BuildRequires:  python3dist(setuptools)
> [...]
> %{?python_provide:%python_provide python3-xapian-haystack}
> 
> Requires:       python3dist(django) >= 3.2
> Requires:       python3dist(django-haystack) >= 2.8
> Requires:       python3dist(filelock) >= 3.4
> Requires:       python3-xapian >= 1.4

This can all be dropped since %generate_buildrequires will get the BRs and Requires would be autogenerated (except python3-xapian, that would stick around)

(FYI, pyp2spec produces spec files with the newer style if you want to use that going forward)

I think I addressed the the last comment in new version of spec file https://download.copr.fedorainfracloud.org/results/zlopez/xapian-haystack/fedora-rawhide-x86_64/08121701-python-xapian-haystack/python-xapian-haystack.spec

The file was originally generated by using COPR build from pypi capability and I started with that.

At this point, it looks good to me.

PACKAGE APPROVED.

Thanks for the review, I will start with repo request right away :-)

The Pagure repository was created at https://src.fedoraproject.org/rpms/python-xapian-haystack

Build the package for rawhide without issue https://koji.fedoraproject.org/koji/buildinfo?buildID=2565293. Closing review bug.