Spec URL: https://copr-dist-git.fedorainfracloud.org/cgit/meeuw/vim-surround/vim-surround.git/plain/vim-surround.spec SRPM URL: https://mrns.nl/~meeuw/912119722a66dc9510f8948d1400f91d77a74f11b6f0daeb80457066-vim-surround-2.2-3.fc40.src.rpm Description: Delete/change/add parentheses/quotes/XML-tags/much more with ease Fedora Account System Username: meeuw
Copr build: https://copr.fedorainfracloud.org/coprs/build/8056800 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2314109-vim-surround/fedora-rawhide-x86_64/08056800-vim-surround/fedora-review/review.txt Found issues: - Not a valid SPDX expression 'Vim and MIT'. It seems that you are using the old Fedora license abbreviations. Try `license-fedora2spdx' for converting it to SPDX. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
fedora-review-service-build
[fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/8091457 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2314109-vim-surround/fedora-rawhide-x86_64/08091457-vim-surround/fedora-review/review.txt Found issues: - Not a valid SPDX expression 'Vim and MIT'. It seems that you are using the old Fedora license abbreviations. Try `license-fedora2spdx' for converting it to SPDX. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Created attachment 2049926 [details] The .spec file difference from Copr build 8091457 to 8098581
Copr build: https://copr.fedorainfracloud.org/coprs/build/8098581 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2314109-vim-surround/fedora-rawhide-x86_64/08098581-vim-surround/fedora-review/review.txt Found issues: - Not a valid SPDX expression 'Vim AND LGPL-2.1-or-later AND MIT AND GPL-1.0-only AND (GPL-2.0-only OR Vim) AND Apache-2.0 AND BSD-2-Clause AND BSD-3-Clause AND GPL-2.0-or-later AND GPL-3.0-or-later AND OPUBL-1.0 AND Apache-2.0 WITH Swift-exception'. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Please consider adding AppData for gnome-software. The upstream documentation is here: https://www.freedesktop.org/software/appstream/docs/sect-Metadata-Addon.html Some real examples might be found here: https://src.fedoraproject.org/rpms/vim-fugitive/tree/rawhide https://src.fedoraproject.org/rpms/vim-commentary/tree/rawhide However, the Vim metadata are likely broken ATM due to [1], so there might be needed some changes. Specifically, the `<extends>gvim.desktop</extends>` should be probably changed to `<extends>org.vim.Vim</extends>` and the `<id>` tag should use rDNS identifier, as specified in the documentation. [1]: https://src.fedoraproject.org/rpms/vim/pull-request/25
It would also likely made sense to update the VIM documentation: ~~~ %post vim -c ":helptags %{vimfiles_root}/doc" -c :q &> /dev/null %postun > %{vimfiles_root}/doc/tags vim -c ":helptags %{vimfiles_root}/doc" -c :q &> /dev/null ~~~ And yes, please consider usage of the `%{vimfiles_root}` provided by the vim-filesystem. Not sure if there is some equivalent for neovim.
(In reply to Vít Ondruch from comment #9) > It would also likely made sense to update the VIM documentation: > > ~~~ > %post > vim -c ":helptags %{vimfiles_root}/doc" -c :q &> /dev/null > > %postun > > %{vimfiles_root}/doc/tags > vim -c ":helptags %{vimfiles_root}/doc" -c :q &> /dev/null > ~~~ Ah, sorry. I have forgotten Vim already ships `%transfiletriggerin` / `%transfiletriggerpostun` which should take care about the refresh, so please disregard.
Thanks for the suggestion to add AppData, I just added it in release 3.